[Vm-dev] [Pharo-dev] fun with announcers

[Denis Kudriashov]

Ok. I fixed found places in Calypso

2018-05-15 16:06 GMT+03:00 Pavel Krivanek <pavel.krivanek at gmail.com>:

>
> small correction, the leaking variable is "available", not "next"
>
>
> 2018-05-15 14:56 GMT+02:00 Pavel Krivanek <pavel.krivanek at gmail.com>:
>
>> I'm not sure if it a cause of all leaks but I realized that the method
>> ClyDataSourceUpdateScheduler>>#processQueue that looks like this:
>>
>> processQueue
>>
>> | available next |
>> [
>> available := OrderedCollection with: updateQueue next.
>> [ next := updateQueue nextOrNil ] whileNotNil: [ available add: next ].
>> self runUpdateFor: available.
>> ] repeat
>>
>> keeps always an indirect pointer to the full Calypso browser window
>> because of the escaping variable (next) of the closure. Moving the
>> temporaries definition to the inner closure fixes the leak.
>>
>> -- Pavel
>>
>>
>>
>>
>> 2018-05-09 21:44 GMT+02:00 Denis Kudriashov <dionisiydk at gmail.com>:
>>
>>>
>>>
>>>
>>> 2018-05-09 22:18 GMT+03:00 Stephan Eggermont <stephan at stack.nl>:
>>>
>>>>
>>>> Eliot Miranda <eliot.miranda at gmail.com> wrote:
>>>>
>>>> > Can you tell me whether this is an application bug or possibly a bug
>>>> with
>>>> > the Spur VMs weak collections?  I'd hate for this to be an
>>>> undiagnosed and
>>>> > unfixed VM bug.
>>>>
>>>> Much more likely an application bug. Copying Morphs that contain Rubric
>>>> editors is non-trivial.
>>>>
>>>
>>> Yes. I am sure it can't be VM issue.
>>> My candidate for leak is spotter windows history. I remember I detect
>>> some leaks when it was integrated in Pharo7. But I was not sure, it was
>>> very fast test. And it can be wrong.
>>>
>>>
>>>>
>>>> Stephan
>>>>
>>>>
>>>
>>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180515/3d519113/attachment-0001.html>