[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

[Eliot Miranda]

eliotmiranda commented on this pull request.

Hi Esteban,

    this looks good, but there is at least one remaining issue.  For example, the changes to platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c eliminate necessary "if (f->isStdioStream) Read/WriteConsole(..." variants.  Can you take a pass over platforms/win32/vm and roll back any incidental changes?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181108/35fb4ed3/attachment.html>