[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Support for musl when building the VM for embedded system (#304)
Eliot Miranda
notifications at github.com
Fri Nov 9 19:31:46 UTC 2018
Hi, making the change to config.sub is fine. What I don't get is the explicit definition for struct _IO_FILE in sqVirtualMachine.c. Shouldn't we do something like
#if TheDefimneThatSaysWereUsingMUSL
# include <whereever/lives/stdio.h>
#endif
The key here is to not break the existing build, and including a possibly incompatible definition of struct _IO_FILE in sqVirtualMachine.c is almost guaranteed to break the build somewhere :-)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/304#issuecomment-437469980
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181109/af2316f5/attachment.html>
More information about the Vm-dev
mailing list