[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows (#285)

akgrant43 notifications at github.com
Tue Oct 2 07:03:58 UTC 2018

Restructure FileAttributesPlugin to move platform specific functionality out to separate files. This is required as Windows requires the "wide" versions of posix functions to be used, e.g. access() vs. _waccess(), while other seem to require the Windows native functions, e.g. iterating over directories, and interleaving #ifdef _WIN32 was becoming unwieldy.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * faSupport: initial commit for windows testing
  * FileAttributesPlugin: restructure platform support files
  * FileAttributesPlugin: Manual FileAttributesPlugin.c fixes
  * FileAttributesPlugin: OSX and Windows fixes
  * FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows
  * Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200

-- File Changes --

    A platforms/Cross/plugins/FileAttributesPlugin/faCommon.c (67)
    A platforms/Cross/plugins/FileAttributesPlugin/faCommon.h (14)
    A platforms/Cross/plugins/FileAttributesPlugin/faConstants.h (32)
    M platforms/iOS/plugins/FileAttributesPlugin/Makefile (6)
    A platforms/unix/plugins/FileAttributesPlugin/faSupport.c (515)
    A platforms/unix/plugins/FileAttributesPlugin/faSupport.h (71)
    A platforms/win32/plugins/FileAttributesPlugin/faSupport.c (657)
    A platforms/win32/plugins/FileAttributesPlugin/faSupport.h (72)
    M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (1092)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181002/a931b333/attachment.html>

More information about the Vm-dev mailing list