[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Do only handle events that correspond to the VM window (#295)

[Guille Polito]

While playing with SDL on OSX we have noticed that the main window in the VM is randomly eating events that belong to other windows. This happens because we are consuming events regardless the window they come from.

The corresponding code is in the method pumpRunLoopEventSendAndSignal: in
   https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/iOS/vm/OSX/sqSqueakOSXApplication%2Bevents.m

I've playing around with making the VM consume only events that come from its own window or from no window (window=null). This seems to work correctly, and I've had run into no issues in the last couple of hours.

I've put a guard so my code is only valid for PHAROVM builds, but I'd gladly remove the guards if people think this is a good move for all the community.
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295

-- Commit Summary --

  * Do only handle events that correspond to the VM window

-- File Changes --

    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (18)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181022/a39b8292/attachment.html>