[Vm-dev] Pull request: changes for Mac build system

[Eliot Miranda]

Hi Tim,
On Tue, Oct 23, 2018 at 8:58 AM Tim Johnson <digit at sonic.net> wrote:

>
> Hi,
>
> I've made a branch with the following commit message:
>
>     Use output of xcode-select to determine path of Xcode in Mac Makefile,
> instead of hard-coding.
>     xcode-select allows for multiple versions of Xcode to be installed and
> to be selected by the user.
>     DO NOT put a space in a renamed Xcode.app, however: this will break
> SDK detection in the Makefile.
>
>     Add OS X 10.14 SDKs for x64 build, as supplied by Xcode 10.
>
> which does the following:
>
> build.macos32x86/common/Makefile.flags &
> build.macos64x64/common/Makefile.flags:
>
> -XCODE:=/Applications/Xcode.app/Contents/Developer
> +XCODE:=$(shell /usr/bin/xcode-select -p)
>
> and:
>
> build.macos64x64/common/Makefile.flags
>
> -SDKs:=MacOSX10.10.sdk MacOSX10.11.sdk MacOSX10.12.sdk MacOSX10.13.sdk
> +SDKs:=MacOSX10.10.sdk MacOSX10.11.sdk MacOSX10.12.sdk MacOSX10.13.sdk
> MacOSX10.14.sdk
>
> However, I'm not sure I have permissions to push my branch and create a
> pull request.  If that's the model you use, please let me know.  I am use
> @tcj on github.
>

Yes, that's the model.  Talk to Fabio about permissions if you're denied
access.  And if that fails I can make the above edits for you but would
prefer you are granted sufficient permission.


_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181023/4a980285/attachment-0001.html>