[Vm-dev] Squeak.rc FILEVERSIONVALUES

[Alistair Grant]

Hi Ben,



On Wed., 19 Sep. 2018, 16:50 Ben Coman, <btc at openinworld.com> wrote:

>
> Well spotted. But next puzzle...  Where do "those" numbers come from?
> i.e...
> Appveyor defines...    -DFILEVERSIONVALUES=2018,8,29,1622
> My build defines...     -DFILEVERSIONVALUES=,,,
>


Yeah, sorry, I had to run for other things, but hoped it would provide
enough of a clue.



> Ahh, found it...
> common/Makefile.tools:RCFLAGS:= --include-dir $(PLATDIR)/win32/misc
> -D_WIN32 -DFILEVERSIONVALUES=$(SVNMAJOR),$(SVNMINOR),$(SVNREV),$(SVNBUILD)
> '-DFILEVERSIONSTRING=\"$(SVNMAJOR).$(SVNMINOR).$(SVNREV).$(SVNBUILD)\\0\"'
>
>
> Damn! Forgetting to run ```updateSCCSversions``` on a fresh clone bites me
> again! :( :(
>


I have a script that I always use to run the compilation. :-)  (I don't
care about the overhead of repeatedly executing ```updateSCCSversions``)

Cheers,
Alistair




Better now, thx Alistair.
> cheers -ben
>
> On Wed, 19 Sep 2018 at 21:25, Alistair Grant <akgrant0710 at gmail.com>
> wrote:
>
>>
>> Hi Ben,
>>
>> I've never built squeak.cog.spur on windows (or any other platform
>> :-)), but if you look at the appveyor log you can see that
>> FILEVERSIONVALUES being defined:
>>
>>
>> https://ci.appveyor.com/project/OpenSmalltalk/vm/build/job/a6x5mg5uw7p8c882?fullLog=true
>>
>> hth,
>> Alistair
>>
>> On Wed, 19 Sep 2018 at 15:17, Ben Coman <btc at openinworld.com> wrote:
>> >
>> >
>> > I tried to build via "build.win32x86/squeak.cog.spur/mvm" but got an
>> error with the resource file...
>> > ```
>> > i686-w64-mingw32-windres \
>> >     --include-dir ../../platforms/win32/misc \
>> >     -D_WIN32 \
>> >     -DFILEVERSIONVALUES=,,, '-DFILEVERSIONSTRING=\"...\\0\"'  \
>> >     -i Squeak.rc \
>> >     -o builddbg/vm/Squeak.res
>> > ==>
>> > i686-w64-mingw32-windres: Squeak.rc:7: syntax error
>> > make[1]: *** [../common/Makefile:296: Squeak.res] Error 1
>> > ```
>> >
>> > I see a reference at the top of [1] to this for Pharo but no direct
>> resolution is mentioned.
>> > [1]
>> http://forum.world.st/Compiling-the-windows-32-bits-vm-td5072691.html
>> >
>> > [Squeak.rc:7](
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/squeak.cog.spur/Squeak.rc#L7)
>> is...
>> > ```
>> > FILEVERSION FILEVERSIONVALUES
>> > ```
>> > and the value ",,," supplied for FILEVERSIONVALUES on the command line
>> seems invalid.
>> >
>> >
>> > I see Pharo has hardcoded the value...
>> > https://www.diffchecker.com/O36vXV5b
>> >
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/pharo.cog.spur/Pharo.rc#L7
>> > ```
>> >  FILEVERSION 5,0,0,0
>> > ```
>> >
>> > and if I do the same in Squeak.rc the build completes.
>> > So should I submit a PR for that, or does anyone know how the command
>> line "FILEVERSIONVALUES"
>> > is supposed to be supplied a proper value?  Searching the repo doesn't
>> give any hints...
>> >
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=FILEVERSIONVALUES
>> >
>> >
>> > cheers -ben
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180919/1eacd319/attachment-0001.html>