[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Nuke mac roman (#460)

Nicolas Cellier notifications at github.com
Thu Dec 26 08:03:33 UTC 2019

This will do 2 things:
- 1) expunge the macRoman encoding from event charCode (event at: 3) on unix and OSX
- 2) revert the change that transformed Ctrl+a from ASCII control character code 1 to $a for Squeak VM (no change for PharoVM though).

1) has been done on windows VM, and need to be done on over OSes
2) is essentially a fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/456

I have reverted deeper changes aimed at using a platform independent keycode in (event at: 3).
This will be for another time and another branch.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Convert charCode to latin1 encoding rather than macRoman on iOS.
  * Let default sqTextEncoding be latin1 instead of macRoman on unix VM
  * Nuke recode entirely from unix X11
  * Directly use the symbolic (=virtual) key code, that's what we want.
  * Use translateCode primarily for translating symbolic X11 keysym to OSVM keycode
  * Remove ux2st & st2ux deadcode
  * Revert "Use translateCode primarily for translating symbolic X11 keysym to OSVM keycode"
  * Revert "Directly use the symbolic (=virtual) key code, that's what we want."
  * Let unix Squeak VM generate ASCII control characters like it always did

-- File Changes --

    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (6)
    M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (10)
    M platforms/unix/vm-display-X11/sqUnixX11.c (120)
    M platforms/unix/vm/sqUnixCharConv.c (4)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20191226/7139fc93/attachment.html>

More information about the Vm-dev mailing list