[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] fix event memory leak (#373)

[Tobias Pape]

krono commented on this pull request.



> @@ -73,6 +73,8 @@ @implementation sqSqueakOSXApplication (events)
 // If the event does not correspond to this window, we take it from the event queue anyways and re-post it afterwards
 // This gives other windows the opportunity to consume their events
 - (void) pumpRunLoopEventSendAndSignal:(BOOL)signal {
+
+	@autoreleasepool {
        NSEvent *event;
        NSMutableArray *alienEventQueue = [[NSMutableArray alloc] init];

@johnmci tries to make sure that everything builds on ARC and non-ARC, so maybe do this:
```suggestion
       NSMutableArray *alienEventQueue = AUTORELEASEOBJ([[NSMutableArray alloc] init]);
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/373#pullrequestreview-209017358
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190228/21ffedce/attachment.html>