[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] fix event memory leak (#373)

[johnmci]

johnmci requested changes on this pull request.

Ok, as @krono pointed out 
NSMutableArray *alienEventQueue = AUTORELEASEOBJ([[NSMutableArray alloc] init]);
with the autoreleasepool. 

I'm not sure anything is build without ARC anymore, but it should be there to be correct for people who need to build on older platforms. 

AUTORELEASEOBJ with ARC does nothing, and the autoreleasepool wrapper then is freeing autorelease objects in the scope of this routine. Since it is pumped from the VM processing requests there isn't a wrapping autorelease pool higher up in the stack.  Easy test is to do invoke the "About Menu" 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/373#pullrequestreview-209221414
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190228/76010447/attachment.html>