[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Be explicit about which test image version - move to CI config (#331)

[Fabio Niephaus]

fniephaus requested changes on this pull request.

LGTM

>      compiler: clang
 
   - stage: "Other Mac builds"
-    env: ARCH="macos64x64" FLAVOR="newspeak.cog.spur"
+    env: ARCH="macos64x64"    FLAVOR="newspeak.cog.spur"        TESTIMAGE="refer newspeakBootstrap.sh"

I don't really have a better suggestion, so let's go with *refer newspeakBootstrap.sh* for now.

> @@ -28,97 +28,98 @@ jobs:
   fast_finish: true
   include:
   - stage: "Main Squeak and Pharo builds"
-    env: ARCH="linux32x86" FLAVOR="squeak.cog.spur"
-  - env: ARCH="macos32x86" FLAVOR="squeak.cog.spur"
+    env: ARCH="linux32x86"    FLAVOR="squeak.cog.spur"          TESTIMAGE="Squeak-5.1"

Not that https://github.com/hpi-swa/smalltalkCI/issues/407 is fixed, please update all image names accordingly (`Squeak32-5.1`, ...).

>      LINUX_BINARY="pharo"
     MACOS_BINARY="Pharo"
     ;;
   *)
-    echo "Skipping SUnit testing for ${FLAVOR}..."
+    echo "Skipping SUnit testing for unknown flavor ${FLAVOR}..."

Thanks for cleaning all of this up!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331#pullrequestreview-188569756
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190101/c329dad0/attachment.html>