[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Win64 fixes (#338)

[Nicolas Cellier]

This fixes are mainly
- my own failure to respect the invariant _imageName and imageNameW must always be synched_, writing in imageNameT (the TCHAR* facade) cannot work!
- SecurityPlugin broken by merge win minheadless experiments. I agree with the spirit of the changes (UNICODE), but this is unfinished.
- a few potential security flaws coming from the past

[skip travis] i don't know if this incantation will work the way i wish... These are platforms/win32 changes only
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338

-- Commit Summary --

  * fix: squeakIniName cannot be both a WCHAR* (sqWin32Security.c) and TCHAR*
  * fix: remove superfluous TEXT macro
  * fix:  wcsncpy does not necessarily writes the terminating NULL
  * fix: B3DAccelerator: dwState is used un-initialized if value is not 0,1 or 2.
  * fix issue #336 potential buffer overrun in sqWin32Midi.c
  * fix: use LoadLibraryA for -DUNICODE compatibility
  * fix: LoadLibrary could fail
  * fix: SecurityPlugin: RegQueryValueExW dwSize is buffer size in bytes
  * SecurityPlugin: prefer wcs* functions to lstr*W
  * Fix: securityPlugin: use WideCharToMultiByte and CP_UTF8
  * SecurityPlugin use MultiByteToWideChar rather than sqUTF8toUTF16Copy
  * fix: SecurityPlugin: restore expandMyDocuments

-- File Changes --

    M platforms/win32/plugins/B3DAcceleratorPlugin/sqWin32D3D.c (9)
    M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c (1)
    M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c (4)
    M platforms/win32/plugins/SecurityPlugin/sqWin32Security.c (138)
    M platforms/win32/vm/sqWin32.h (4)
    M platforms/win32/vm/sqWin32Backtrace.c (4)
    M platforms/win32/vm/sqWin32Main.c (16)
    M platforms/win32/vm/sqWin32Prefs.c (23)
    M platforms/win32/vm/sqWin32Window.c (25)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190103/947886dc/attachment-0001.html>