[Vm-dev] longRunningPrimitiveCheckSequenceNumber compiler warning
Nicolas Cellier
nicolas.cellier.aka.nice at gmail.com
Fri Jan 4 11:39:35 UTC 2019
We have this code
voidLongRunningPrimitive: reason
...
<inline: false>
longRunningPrimitiveCheckMethod := nil.
longRunningPrimitiveCheckSequenceNumber = 0. "not strictly necessary
but prevents this being inlined into checkForLongRunningPrimitive"
...
which generates
static void NoDbgRegParms
voidLongRunningPrimitive(char *reason)
{ DECL_MAYBE_SQ_GLOBAL_STRUCT
GIV(longRunningPrimitiveCheckMethod) = null;
GIV(longRunningPrimitiveCheckSequenceNumber) == 0;
...
and a compiler warning suggesting to replace == with =
So it seems to effectively be a hack, but it seems fragile.
Couldn't we remove this line (don't we have inline: #never for that
purpose?).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190104/4c318664/attachment-0001.html>
More information about the Vm-dev
mailing list