[Vm-dev] .travis.yml CHROOT for linux32ARM6 builds

[Ben Coman]

On Mon, 21 Jan 2019 at 05:48, Fabio Niephaus <lists at fniephaus.com> wrote:

>
> On Sun, Jan 20, 2019 at 3:08 AM Ben Coman <btc at openinworld.com> wrote:
> >
> > How is the CHROOT variable used for linux32ARM6 builds?
> > https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/.travis.yml
> >
> >   - stage: "linux32ARMv6 builds"
> >     env: ARCH="linux32ARMv6" FLAVOR="newspeak.cog.spur" CHROOT="schroot
> -p -c rpi
> >       -- bash -c "
> >     dist: trusty
> >     group: edge
> >
> > I don't see it referenced anywhere else...
> >
> https://github.com/OpenSmalltalk/opensmalltalk-vm/search?utf8=%E2%9C%93&q=chroot
>
> GitHub's code search is terrible, do not trust it! It might have been
> too obvious, but CHROOT is actually only been used in the .travis.yml:
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/5a38b3483dc5c82c7ecc85a590fdf1b095377a1f/.travis.yml#L133


Thanks.  I had completely missed that use in .travis.yml and only noticed
the definitions.

In my other thread "condensing Travis build matrix" I tried to
not-repeat-myself to reduce the line length of the ARM job definitions
by making a global CHROOT defintion...

    env:
      global:
        - CHROOT="schroot -p -c rpi -- bash -c "

...but now I see that obviously won't work.

What about moving the per job repetitions of CHROOT definition to be more
localised like this...

    before_script:
        - if [[ $ARCH == *"ARM"* ]] ; then
               CHROOT="schroot -p -c rpi -- bash -c "
          fi
        - $CHROOT ./scripts/ci/travis_build.sh

where
   ARCH=linux32ARMv6

If that sounds worth a try I can test it.

cheers -ben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190121/2a89d6eb/attachment.html>