[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add --quiet option to allow an app to own stdout and stderr (#395)
Ben Coman
notifications at github.com
Wed May 15 13:37:13 UTC 2019
bencoman commented on this pull request.
> @@ -863,13 +863,13 @@ sqInt primitivePluginRequestState(void) { return dpy->primitivePluginRequestSta
static void outOfMemory(void)
{
- /* pushing stderr outputs the error report on stderr instead of stdout */
+ /* pushing VM_ERR() outputs the error report on VM_ERR() instead of stdout */
What is the significance of changing this comment? (I'm not familiar with *pushOutputFile*)
> pushOutputFile((char *)STDERR_FILENO);
error("out of memory\n");
}
/* Print an error message, possibly a stack trace, do /not/ exit.
- * Allows e.g. writing to a log file and stderr.
+ * Allows e.g. writing to a log file and VM_ERR().
Same again. Search/replaced within comment useful?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395#pullrequestreview-237823696
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190515/8ed05596/attachment.html>
More information about the Vm-dev
mailing list