[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] f1bc1c: Fix copy/paste typo when printing registers

[Eliot Miranda]

Hi Nicolas, Hi git mavens,

On Tue, Oct 22, 2019 at 3:24 AM Nicolas Cellier <noreply at github.com> wrote:

>
>   Branch: refs/heads/small_fixes
>   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>   Commit: f1bc1cce999b3bcca317baa84bd0b28f21a4d7b0
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f1bc1cce999b3bcca317baa84bd0b28f21a4d7b0
>   Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>   Date:   2019-10-20 (Sun, 20 Oct 2019)
>
>   Changed paths:
>     M platforms/unix/vm/sqUnixMain.c
>
>   Log Message:
>   -----------
>   Fix copy/paste typo when printing registers
>

Why is this commit not showing up when I pull?  We need this fix asap.  I
don't understand where it is.  Did I fail to merge it and overwrote it?


>
>
>   Commit: 0e8de8580aedea1052fc771d6f301ba8fd17ef4e
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e8de8580aedea1052fc771d6f301ba8fd17ef4e
>   Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>   Date:   2019-10-20 (Sun, 20 Oct 2019)
>
>   Changed paths:
>     M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c
>
>   Log Message:
>   -----------
>   Remove a pointer aliasing (replace by memcpy).
>
> Reason: gcc compiler barks.
> platforms/unix/plugins/SocketPlugin/sqUnixSocket.c:1452:3: warning:
> dereferencing type-punned pointer will break strict-aliasing rules
> [-Wstrict-aliasing]
>    *(int *)buf= 1;
> It's probably benign in this case, but rather than trying to confirm this
> for all current and future versions of compilers, it's far easier to just
> avoid breaking strict aliasing.
>
>
>   Commit: 86e976be8ca1a830d16c2e9f320258e6e69f291e
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/86e976be8ca1a830d16c2e9f320258e6e69f291e
>   Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>   Date:   2019-10-20 (Sun, 20 Oct 2019)
>
>   Changed paths:
>     M platforms/unix/vm-display-X11/sqUnixX11.c
>
>   Log Message:
>   -----------
>   Remove a (false positive) -Wmaybe-uninitialized warning
>
> Tell why we do it, why it's not necessary (as long as int have 32 bits).
> Analyzing warnings again and again is time consuming.
> So even false positive should better be eliminated.
>
>
>   Commit: 09878ce6d3ae50385ecd63685fb486f4b925d7d8
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/09878ce6d3ae50385ecd63685fb486f4b925d7d8
>   Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>   Date:   2019-10-20 (Sun, 20 Oct 2019)
>
>   Changed paths:
>     M platforms/unix/vm-display-X11/sqUnixX11.c
>
>   Log Message:
>   -----------
>   Remove two warnings about incompatible pointer type
>
> Implementation should conform to SqDisplay.h
>
> platforms/unix/vm-display-X11/sqUnixX11.c:7453:1: warning: incompatible
> pointer types initializing 'long (*)(char *, int)' with an expression of
> type 'long (char *, long)' [-Wincompatible-pointer-types]
> SqDisplayDefine(X11);
> ^~~~~~~~~~~~~~~~~~~~
> platforms/unix/vm/SqDisplay.h:108:3: note: expanded from macro
> 'SqDisplayDefine'
>   display_winImageFind,                         \
>   ^~~~~~~~~~~~~~~~~~~~
> /platforms/unix/vm-display-X11/sqUnixX11.c:7453:1: warning: incompatible
> pointer types initializing 'long (*)(unsigned int *, long, long, long,
> long, long, long, long, long)' with an expression of type 'long (unsigned
> int *, long, long, long, int, int, int, int, int)'
> [-Wincompatible-pointer-types]
> SqDisplayDefine(X11);
> ^~~~~~~~~~~~~~~~~~~~
> platforms/unix/vm/SqDisplay.h:157:3: note: expanded from macro
> 'SqDisplayDefine'
>   display_hostWindowShowDisplay,                \
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>   Commit: 1c3a0ca9df711d31f6964a6511a2b7e98abab3e8
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c3a0ca9df711d31f6964a6511a2b7e98abab3e8
>   Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>   Date:   2019-10-21 (Mon, 21 Oct 2019)
>
>   Changed paths:
>     M platforms/unix/vm-display-null/sqUnixDisplayNull.c
>
>   Log Message:
>   -----------
>   Same uncompatible pointer fix for display-null
>
>
> Compare:
> https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f1bc1cce999b%5E...1c3a0ca9df71
>


-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20191022/17d4cde3/attachment.html>