[Vm-dev] FloatMathPlugin: patch for squeak 4.19.2 fdlibm.h header
David T. Lewis
lewis at mail.msen.com
Sun Dec 13 16:53:37 UTC 2020
On Sun, Dec 13, 2020 at 04:50:46PM +0100, stes at PANDORA.BE wrote:
> If there is someone with access to http://squeakvm.org/svn/squeak (subversion),
> can they please have a look at the issue ?
> It seems simple to fix.
> David Stes
I tried applying the patch, and it compiles and runs on my Linux box.
However if I am reading this right, the patch forces __LITTLE_ENDIAN to
be defined for all platforms, so that would break big endian systems.
Granted, there are no big endian platforms in common use these days, but
it still doesn't seem like the right way to deal with it.
Am I right in understanding that the original code causes compiler warnings
on Solaris, but that it compiles and works correctly despite the warnings?
If so, I would honestly suggest just ignoring the warnings.
Otherwise if it is a functional problem, maybe there is a way that we can
make the build system ensure a correct setting for __LITTLE_ENDIAN. I
have not looked at this, but I suspect there will be a way that we could
make it work.
More information about the Vm-dev