[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Error message for the failure to create heartbeat thread is too specific. (#540)

[dcstes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Well I can understand that Eliot has good reasons to raise the priority
of the heartbeat thread.

Also I have noticed now that I'm running a nice package "AIDA"
(web framework on top of Swazoo) that the WebScheduler is sensitive to
scheduling of course.

My feeling about it is that still the error message is "too specific".

Perhaps the "configure" script could define something like

  HAVE_LINUX_PAM_LIMITS

because I believe the directory /etc/security/limits.d on Linux
is related to a pam_limits package.

The platforms/vm/unix/sqUnixHeartbeat.c could then print the message
only 

  #ifdef HAVE_LINUX_PAM_LIMITS

Some Linux distros may not even have that directory /etc/security/limits.d.

Regarding Solaris, or other Unix systems that are not Linux, they can have
their own system of privileges to allow/disallow a thread or a process to
set or raise priority.

See https://en.wikipedia.org/wiki/Pluggable_authentication_module

So although Solaris uses PAM, I could then not define HAVE_LINUX_PAM_LIMITS,
and then at the least the error message would be more suitable.

Although the action to remediate the issue would be different, the
heartbeat thread could still run at a different priority than the main thread.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJf4cFXAAoJEAwpOKXMq1MaH70H+wZMv7KCxiMNKlAINfMgKmfA
h/6+uxpqvyA6qncIaB9Ewmj1IIesO18kSomTBHDQFYFNdV0DnippzVpkQ1Q4mvrK
U1iSIj8a0qRjNYlkrOFdkDa0hSg2OhV4vHjqp48mGCCV0BovFKr3AoaNkUyiLhM+
qAIX6BsmNNgWeBoWf9hTWyot1uk6XXAhlT2UUyn4wImnHcrsKlJc+9EFK112ZlNQ
siZen1aPEZYZD7k2t8/raRVVYDekHbugIFeVcbj+lsAp5GqM1pqJeRnW0t9IipRm
Sxg2Rq4GvI+VknpVq3pY5fROHdSiu/0yj4EhEJrI42N11hwk4+Y0pdoD8K6TNF0=
=7kpF
-----END PGP SIGNATURE-----


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/540#issuecomment-749453726
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201222/2791483e/attachment.html>