[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Use NSWindow API for changing fullscreen mode (#478)
Eliot Miranda
notifications at github.com
Fri Feb 28 15:09:36 UTC 2020
eliotmiranda commented on this pull request.
Personally I loathe and despise (fullScreen == 0) Correct C is !fullScreen. ;-)
And getFullScreenFlag() == (fullScreen == 1) is better written as getFullScreenFlag() == (fullScreen != 0) (or occasionally one will see getFullScreenFlag() == !!fullScreen).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478#pullrequestreview-366465759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200228/f7f71310/attachment.html>
More information about the Vm-dev
mailing list