[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix image MC loading glitch in image build scripts when checking pack… (#466)

David T Lewis notifications at github.com
Sat Jan 4 23:44:11 UTC 2020


…age-cache.

MCRepository>>includesVersionNamed: does not check explicit version name,
so this may do the wrong thing when checking the cache:
    version := ((MCCacheRepository default includesVersionNamed: latestVersion)
        ifTrue: [MCCacheRepository default]
        ifFalse: [repository]) versionNamed: latestVersion.

Therefore do this instead:
    version := (MCCacheRepository default versionNamed: latestVersion)
        ifNil: [repository versionNamed: latestVersion].
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466

-- Commit Summary --

  * Fix image MC loading glitch in image build scripts when checking package-cache.

-- File Changes --

    M image/BuildPharo6VMMakerImage.st (2)
    M image/BuildSqueakSpurTrunkVMMakerImage.st (2)
    M image/LoadFFI.st (2)
    M image/LoadReader.st (5)
    M image/LoadSistaSupport.st (2)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200104/efbd6660/attachment.html>


More information about the Vm-dev mailing list