[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Squeak3D crash on 64bits VM (#468)

[Eliot Miranda]

On Fri, Jan 10, 2020 at 1:57 PM Nicolas Cellier <notifications at github.com>
wrote:

> I broke it in #448
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/448>
> The function signature was already BADLY inconsistent!
> But luckily, the erroneous 64 bits arguments did get copied into 32 bits
> dstY before my fix...
> I sort of broke the spell and the magic vanished ;)
> Brittle code = hazardous life
>
> What I'm very unsure of now, is if writing at negative offset is a good
> idea (buffer underflow?), or if this uncovers yet another bug at upper
> level...
> If I just correct function signature, the game seems to work though...
>

That's the right thing to do, no?  Just fix the signature.

_,,,^..^,,,_
best, Eliot


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/468#issuecomment-573225277
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200110/f0f852d6/attachment.html>