[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] f6169e: Make prototype of new sqMakeMemoryNotExecutableFro...

Eliot Miranda eliot.miranda at gmail.com
Fri Jan 31 18:19:05 UTC 2020


Hi Nicolas,

> On Jan 31, 2020, at 9:02 AM, Nicolas Cellier <noreply at github.com> wrote:
> 
> 
>  Branch: refs/heads/Cog
>  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>  Commit: f6169e033fba2597f7611a349d5f3520e92e095d
>      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6169e033fba2597f7611a349d5f3520e92e095d
>  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
>  Date:   2020-01-31 (Fri, 31 Jan 2020)
> 
>  Changed paths:
>    M platforms/Cross/vm/sq.h
> 
>  Log Message:
>  -----------
>  Make prototype of new sqMakeMemoryNotExecutableFromTo function LLP64 friendly
> 
> unsigned long is too short (32 bits) to hold a pointer (64 bits) on WIN64

Damn.  I meant to use #usqInt.  At least in OpenSmalltalk #sqInt & #usqInt are both pointer sized, right?

> 
> 
>  Commit: 08768500d9cfbbc8509030e0bbe81ce907358a50
>      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/08768500d9cfbbc8509030e0bbe81ce907358a50
>  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
>  Date:   2020-01-31 (Fri, 31 Jan 2020)
> 
>  Changed paths:
>    M platforms/win32/vm/sqPlatformSpecific.h
>    M platforms/win32/vm/sqWin32Window.c
> 
>  Log Message:
>  -----------
>  Make Win32 prototype of ioSetCursorARGB Cross-compatible
> 
> conflicting prototype make compilation fail
> 
> 
> Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/0f14516f9ad1...08768500d9cf


More information about the Vm-dev mailing list