[Vm-dev] latest sources removal platforms/unix/vm/sunos.h

Eliot Miranda eliot.miranda at gmail.com
Sun Nov 8 15:08:29 UTC 2020


Hi David,

> On Nov 8, 2020, at 4:53 AM, stes at telenet.be wrote:
> 
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> 
> I should add that I think normally the config.h header file already set
> the 64 bit offset (via "configure").
> 
> The configure log shows:
> 
> configure:15085: cc -c  -g -DAIO_DEBUG -DNDEBUG -DDEBUGVM=0 -D_POSIX_PTHREAD_SEMANTICS -mt  -m32 conftest.c >&5
> configure:15085: $? = 0
> configure:15093: result: 64
> 
> 
> So it sets correctly in config.h
> 
> #define _FILE_OFFSET_BITS 64
> 
> 
> 
> So depending on how to look at this, it may not be desired or needed to
> - -D_FILE_OFFSET_BITS=64 in the mvm script.
> 
> That's because it is already set in the config.h.
> 
> But then there is an issue (possibly) with the #include order, whether
> config.h is included before or after system headers.

We should arrange that config.h is included first before anything else.  In this sense config.h is a substitute for/convenience for command line defines.

sqPlatformSpecific.h should be included after all (alas in practice most, because done system headers are pulled in before a specific function etc) system headers.

> 
> David Stes
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iQEcBAEBCAAGBQJfp+mYAAoJEAwpOKXMq1MarYoIAImi+NL7Tk8gTNsfkqpjDYjk
> lK3XS5TK0vZDNXz2GalO8i5x+6mec9BMrS5IzZn+I6JtteYlVZGPmhdV/e2iK+tR
> c4CJuXlvcAaXOGysHQ3DjirnRUSsUeh17iMAeQW90eJrusFXOJ26lgzq3JgMbQOs
> O69dGwT9s8ypp7j3UG3qEh36TELDZpI+3kL7T3DzmjhzsDlzNhVay5CqeGgn1bF6
> cCKpyti7c/pnCFwAxzZOdXMriVUVbkCpbZF33pjUaPhfl4IUXGba3N37IQINgYuJ
> TfGQ+3IHgNAZiBDgPPtFOMTcA6i6BYEQqGlo1aXsdbf7l7LQWapEctvX6ZRP/JM=
> =/7eY
> -----END PGP SIGNATURE-----


More information about the Vm-dev mailing list