[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix image opening on unix (#529)
smalltalking
notifications at github.com
Mon Oct 19 21:51:22 UTC 2020
In imgInit() of sqUnixMain.c
- preserve fd instead of throwing it away
- use fileno() to get the file descriptor (fd) created by fopen() instead of
opening the file again with open() (which leaked a file descriptor due to
lack of close())
- pass the file descriptor fd instead of the FILE* f to the recently changed
methods expecting a file descriptor, e.g. readImageFromFileHeapSizeStartingAt()
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529
-- Commit Summary --
* Fix image opening on unix
-- File Changes --
M platforms/unix/vm/sqUnixMain.c (12)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201019/774d8178/attachment.html>
More information about the Vm-dev
mailing list