[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Simplify sqUnixMain.c's imgInit() (#530)

smalltalking notifications at github.com
Tue Oct 20 16:12:39 UTC 2020


- use sqImageFileOpen() to open the image file
- use file descriptors only to avoid leaking a FILE struct
- removed the ability to let winImageFind manipulate the file some way
  (only supported by the Quartz display anyway)
- removed the loop retrying opening the file again because that relied on
  winImageFind
- reformatted the code to follow the formatting guidelines (it was a
  bit messy)
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530

-- Commit Summary --

  * Simplify sqUnixMain.c's imgInit()

-- File Changes --

    M platforms/unix/vm/sqUnixMain.c (64)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201020/dc155c0b/attachment.html>


More information about the Vm-dev mailing list