[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] c94e77: Simplify sqUnixMain.c's imgInit()

Eliot Miranda noreply at github.com
Wed Oct 28 16:02:15 UTC 2020


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: c94e770242f3c7d59711b2243fbb8c7dc8363208
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c94e770242f3c7d59711b2243fbb8c7dc8363208
  Author: Levente Uzonyi <leves at caesar.elte.hu>
  Date:   2020-10-20 (Tue, 20 Oct 2020)

  Changed paths:
    M platforms/unix/vm/sqUnixMain.c

  Log Message:
  -----------
  Simplify sqUnixMain.c's imgInit()

- use sqImageFileOpen() to open the image file
- use file descriptors only to avoid leaking a FILE struct
- removed the ability to let winImageFind manipulate the file some way
  (only supported by the Quartz display anyway)
- removed the loop retrying opening the file again because that relied on
  winImageFind
- reformatted the code to follow the formatting guidelines (it was a
  bit messy)


  Commit: 75c8e99612cdf433171b9c207df76114f402c58f
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/75c8e99612cdf433171b9c207df76114f402c58f
  Author: Eliot Miranda <eliot.miranda at gmail.com>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M platforms/unix/vm/sqUnixMain.c

  Log Message:
  -----------
  Merge pull request #530 from smalltalking/Cog

Simplify sqUnixMain.c's imgInit()


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/c3f4c20a157b...75c8e99612cd


More information about the Vm-dev mailing list