[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

[Eliot Miranda]

On Wed, Sep 16, 2020 at 11:14 AM Tobias Pape <Das.Linux at gmx.de> wrote:

>
> Hi
>
> > On 16.09.2020, at 19:29, Tobias Pape <Das.Linux at gmx.de> wrote:
> >
> >
> > Hi
> >> On 16.09.2020, at 17:31, Eliot Miranda <eliot.miranda at gmail.com> wrote:
> >>
> >> Hi TObias,
> >>
> >>   cool stuff!!
> >
> > na.
> >
> >
> >> I'm hoping we can actually generate a single config.h file for each
> build.XXX directory and share it between all builds for that platform.
> >>
> >> Can you please test a newspeak build on MacOS?  That uses the
> FileCopyPlugin and currently your changes break the Mac build for that
> plugin.
> >
> > Humm. That the problem with that kind of reuse x.x
> > I'll see.
>
> 5ca742c20739ff5d55c9ab220707c6c6a85ff2dc should fix that. Not in a
> principled but a practical way…
>

thanks!!

>
> -t
>
> > -t
> >
> >>
> >> On Wed, Sep 16, 2020 at 2:37 AM Tobias Pape <noreply at github.com> wrote:
> >>
> >> Branch: refs/heads/Cog
> >> Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
> >> Commit: 1e107be155f27df34f6578615984ab154a51efa4
> >>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
> >> Author: Tobias Pape <tobias at netshed.de>
> >> Date:   2020-09-16 (Wed, 16 Sep 2020)
> >>
> >> Changed paths:
> >>   M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
> >>   M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
> >>   M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
> >>   M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
> >>   M platforms/unix/vm/sqConfig.h
> >>   M platforms/unix/vm/sqUnixMemory.c
> >>   M platforms/unix/vm/sqUnixSpurMemory.c
> >>
> >> Log Message:
> >> -----------
> >> [unix] Harmonize use of config.h
> >>
> >> - prefer sq.h/sqConfig.h wherever sensible
> >> - these should come early
> >> - use HAVE_ tests to see if includes are necessary/available
> >
> >
> >
>
>
>

-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200916/16c9441f/attachment.html>