[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] configure change: use pkg-config (PKG_CONFIG) (#520)

dcstes notifications at github.com
Thu Sep 17 16:42:41 UTC 2020


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Support PKG_CONFIG in configure for UnicodePlugin :

  PKG_CONFIG  path to pkg-config utility
  PKG_CONFIG_PATH
              directories to add to pkg-config's search path
  PKG_CONFIG_LIBDIR
              path overriding pkg-config's built-in search path
  UNICODE_PLUGIN_CFLAGS
              C compiler flags for UNICODE_PLUGIN, overriding pkg-config
  UNICODE_PLUGIN_LIBS
              linker flags for UNICODE_PLUGIN, overriding pkg-config

Note that I believe that Ian Piumarta's "cmake" system for squeak-4 also
uses pkg-config (when he changed from autoconf to 'cmake').

The reason why I made this change, is for compiling on Solaris 11.4.

You can see in the "mvm" script that I set PKG_CONFIG_PATH for the 64bit:

On Solaris 11.4 32bit there is:

 # pkg-config --cflags glib-2.0
 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  

and on Solaris 11.4 64bit there is:

 # PKG_CONFIG_PATH=/usr/lib/64/pkgconfig pkg-config --cflags glib-2.0
 -I/usr/include/glib-2.0 -I/usr/lib/amd64/glib-2.0/include  

Note the '64' or 'amd64' subdirectories.

Finally a remark: I modified

	platforms/unix/config/make.cfg.in

because I don't see how to define the UNICODE_PLUGIN_CFLAGS in the plugin,
locally, without setting the variable globally (in all Makefiles).

Because of the 'mkmf' script, this will thus modify all Unix Makefiles ...

If somebody has a better idea, let's hear it !

I understand from Eliot Miranda that abandoning 'configure' is an option.

But that still has the issue of multiple locations on various Unix flavors,
for the GTK include files and libraries ...

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfY5HNAAoJEAwpOKXMq1MaLpEIAL0qgm0zmtJs3kqV9GHli96I
+OQZHL9lLn9gNjyaohpPF7UXhXjr4VbXzjrPAjU8vDR7yImNwe11bcN39VH5nwtt
VrbXA3PpKFNyz5gWBWpyVs1k5ey4UZBSFF/76KwgdruDlXR/aQ7QLwR8WcC6UIfV
rYcvFyLaadwIDV2XoseoVpB91J+Vjy5x/hD+bT6MNybXuvWj5hYli8obdtiBi5aS
8zhBGmZnnKS8+cyfBlmbAjKknUQuy11mhos6FDQX2Wbr/VtBUYgXphcF8cYMnSIe
jV1ZOaA1IQgJ+0kXGKehjqMB/EPs5LA35sUJ8nI2YC3yww0z7n+rzC8n7UttFsg=
=Miad
-----END PGP SIGNATURE-----

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520

-- Commit Summary --

  * configure change: use pkg-config (PKG_CONFIG)

-- File Changes --

    M build.sunos64x64/squeak.cog.spur/build/mvm (4)
    M build.sunos64x64/squeak.stack.spur/build/mvm (3)
    M platforms/unix/config/make.cfg.in (2)
    M platforms/unix/plugins/UnicodePlugin/Makefile.inc (5)
    M platforms/unix/plugins/UnicodePlugin/README.UnicodePlugin (21)
    M platforms/unix/plugins/UnicodePlugin/acinclude.m4 (19)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200917/3adf4fed/attachment.html>


More information about the Vm-dev mailing list