[Vm-dev] VM Maker: VMMaker.oscog-eem.2828.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Sep 27 22:01:21 UTC 2020


Eliot Miranda uploaded a new version of VMMaker to project VM Maker:
http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2828.mcz

==================== Summary ====================

Name: VMMaker.oscog-eem.2828
Author: eem
Time: 27 September 2020, 3:01:12.505829 pm
UUID: 3c2c852d-7cbe-44db-94ec-85ada5056274
Ancestors: VMMaker.oscog-eem.2827

Oops! Back out of the comment change to getModuleName as it causes all plugins to change.  Some day the time will be right, but not today :-)

=============== Diff against VMMaker.oscog-eem.2827 ===============

Item was changed:
  ----- Method: InterpreterPlugin>>getModuleName (in category 'initialize') -----
  getModuleName
  	"Note: This is hardcoded so it can be run from Squeak.
+ 	The module name is used for validating a module *after*
+ 	it is loaded to check if it does really contain the module
+ 	we're thinking it contains. This is important!!"
+ 	<returnTypeC: #'const char*'>
- 	 The module name is used for validating a module *after*
- 	 it is loaded to check if it does really contain the module
- 	 we're thinking it contains. This is important!!  Note also
- 	 that if a plugin does not implement getModuleName then
- 	 loading is allowed but a warning may be printed. See
- 	 platforms/Cross/vm/sqNamedPrims.c"
- 	<returnTypeC: #'const char *'>
  	<export: true>
  	^self cCode: [moduleName]
  		inSmalltalk:
  			[| string index |
  			 string := ((self class codeGeneratorClass new pluginClass: self class) variableDeclarationStringsForVariable: 'moduleName') first.
  			 index := (string indexOfSubCollection: 'moduleName = "') + 14.
  			 (string copyFrom: index to: (string indexOf: $" startingAt: index + 1) - 1), '(i)']!



More information about the Vm-dev mailing list