[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Changes to sq.h and sqAssert.h to accompany commit (aafcb78)

Nicolas Cellier notifications at github.com
Fri Apr 23 16:17:00 UTC 2021

I've tried adding EXPORT/IMPORT declarations in sqVirtualMachine.h, but it's not such a good idea
- many function prototypes are duplicated in various win32/vm/*.c without the EXPORT, so it breaks in many places
- most external plugins won't need the IMPORT, because they call functions through the VirtualMachine structure rather than attempt to directly link them.

I've sketched a lightweight solution in branch https://github.com/OpenSmalltalk/opensmalltalk-vm/tree/fix_include_order.
The branch can build the VM for the 3 major OSes (linux, macos, windows).
It remains to know if the solution is compatible with TERF.
Before I emit a pull request, Eliot, your comments are welcome.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210423/b6915bd1/attachment.html>

More information about the Vm-dev mailing list