[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 80abb4: Disable compiler optimization for VectorEnginePlugin.

[David T. Lewis]

I cherry-picked the commits for the VectorEnginePlugin.c source from
the add-VectorEnginePlugin branch, and closed the pull request (because
it contained other changes related to loading plugin source into the
VMMaker image).

This makes the generated sources ready for anyone building from the
updated Cog branch on Linux. I cannot test other platforms so I limited
the plugins.ext updates to Linux at this point.

A follow-on issue is how best to manage loading the upstream plugin source from
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/blob/master/Packages/Features/VectorEnginePlugin.pck.st

I set up a mirror repository at http://www.squeaksource.com/VectorEnginePlugin
to make it easy to load into a VMMaker image, but the sources use
the Cuis underscore assignment character convention which conflicts
with a preference setting in the BuildSqueakSpurTrunkVMMakerImage.st
script, so that still needs sorting out.

Dave


On Sun, Aug 08, 2021 at 11:58:12AM -0700, David T Lewis wrote:
>  
>   Branch: refs/heads/Cog
>   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>   Commit: 80abb4043bd07b7f96f9c2599434d921c9a19cae
>       https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/80abb4043bd07b7f96f9c2599434d921c9a19cae
>   Author: David T. Lewis <lewis at mail.msen.com>
>   Date:   2021-08-08 (Sun, 08 Aug 2021)
> 
>   Changed paths:
>     A platforms/unix/plugins/VectorEnginePlugin/Makefile.inc
> 
>   Log Message:
>   -----------
>   Disable compiler optimization for VectorEnginePlugin.
> For gcc this is not an issue, but with llvm any compiler optimization
> results in a broken plugin (various symptoms). Add -O0 to XCFLAGS
> in makefile.inc to override any previous definition of -O in CFLAGS.
> 
> 
>   Commit: c4890ab882c37aa53e32d2eb8aaa0a13082fabf1
>       https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c4890ab882c37aa53e32d2eb8aaa0a13082fabf1
>   Author: David T. Lewis <lewis at mail.msen.com>
>   Date:   2021-08-08 (Sun, 08 Aug 2021)
> 
>   Changed paths:
>     A src/plugins/VectorEnginePlugin/VectorEnginePlugin.c
> 
>   Log Message:
>   -----------
>   Add generated source for VectorEnginePlugin
> 
> 
>   Commit: 504c482c621a8f0f79f46c83fb1552df1cca5479
>       https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/504c482c621a8f0f79f46c83fb1552df1cca5479
>   Author: David T. Lewis <lewis at mail.msen.com>
>   Date:   2021-08-08 (Sun, 08 Aug 2021)
> 
>   Changed paths:
>     M build.linux32ARMv6/pharo.cog.spur/plugins.ext
>     M build.linux32ARMv6/squeak.cog.spur/plugins.ext
>     M build.linux32ARMv6/squeak.cog.v3/plugins.ext
>     M build.linux32ARMv6/squeak.stack.spur/plugins.ext
>     M build.linux32ARMv6/squeak.stack.v3/plugins.ext
>     M build.linux32x86/pharo.cog.spur.lowcode/plugins.ext
>     M build.linux32x86/pharo.cog.spur/plugins.ext
>     M build.linux32x86/pharo.sista.spur/plugins.ext
>     M build.linux32x86/pharo.stack.spur.lowcode/plugins.ext
>     M build.linux32x86/squeak.cog.spur/plugins.ext
>     M build.linux32x86/squeak.cog.v3/plugins.ext
>     M build.linux32x86/squeak.sista.spur/plugins.ext
>     M build.linux32x86/squeak.stack.spur/plugins.ext
>     M build.linux32x86/squeak.stack.v3/plugins.ext
>     M build.linux64ARMv8/pharo.stack.spur/plugins.ext
>     M build.linux64ARMv8/squeak.cog.spur/plugins.ext
>     M build.linux64ARMv8/squeak.cogmt.spur/plugins.ext
>     M build.linux64ARMv8/squeak.stack.spur/plugins.ext
>     M build.linux64x64/pharo.cog.spur/plugins.ext
>     M build.linux64x64/squeak.cog.spur/plugins.ext
>     M build.linux64x64/squeak.stack.spur/plugins.ext
> 
>   Log Message:
>   -----------
>   Add VectorEnginePlugin as external plugin for Linux build configurations
> 
> 
> Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/67e8148ecf1a...504c482c621a