[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] windows: resync the VM time when the system clock gets changed (#588)

[Christoph Thiede]

As of today, if the Windows system time is changed, already running VM instances will not reflect this change. With this patch, this bug is fixed. The full bug report is on squeak-dev: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-June/215908.html

This bug only affects builds for Windows versions prior to Windows 8, never builds do not use the tick variables any longer. See:

https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/57260c215c025e17b57e0b7d8478edbcddb74407/platforms/win32/vm/sqWin32Heartbeat.c#L79-L85

(However, as #499 is still unmerged, currently, also builds for Windows 10 are affected by the bug. Looks like we were never benefitting from @eliotmiranda's improvements for the Win8 APIs (cf. fae0d31cd52341977d37d150d8d2c9272f9864bf) until today 😆)

Independently of this patch, we will want to fix cross-platform-occurring VM hangs when the system clock is pulled backward. See the bug report on squeak-dev for this, again.

Please review thoroughly!

/cc @marceltaeumel 
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588

-- Commit Summary --

  * windows: resync the VM time when the system clock gets changed

-- File Changes --

    M platforms/win32/vm/sqWin32Heartbeat.c (7)
    M platforms/win32/vm/sqWin32Window.c (4)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210830/93ee0a3f/attachment.html>