[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Windows: Save two redundant calls of `GetLastError()` (#589)

Christoph Thiede notifications at github.com
Mon Aug 30 22:44:22 UTC 2021

Assuming there was an error during printing (`wvsprintf`) inside of `vprintLastError()`, the second call could have returned a different error code than expected.

Apart from that, to me, it looks to be an idiom to call GetLastError() only once per error. In every case, printing errors now should be a tiny little bit faster. :-)
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Save two redundant calls of GetLastError()

-- File Changes --

    M platforms/win32/vm/sqWin32Utils.c (4)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210830/6681e1be/attachment.html>

More information about the Vm-dev mailing list