[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] windows: resync the VM time when the system clock gets changed (#588)

[Eliot Miranda]

Hi Christoph, hi all,

> On Aug 31, 2021, at 1:53 AM, Christoph Thiede ***@***.***> wrote:
> 
> 
> Why don't we create multiple builds for the different Windows versions?
> 

That would probably cause disruption to naming schemes etc.  an easier way would be to change the code so that
- if compiled on a system older than Windows 8 the old ticket variable code is used
- if compiled on Windows 8 or later then
   - at startup the Windows is version is cached in a variable and,
   - depending on the variable either the new or the old code is evaluated

So we keep a single build, and a single version of the code base. Normal builds remain backward compatible. One can still compile on an older system and get a functional, albeit more fragile vm.

Note that one could also use the get symbol from dll api (LoadSymbol? can’t remember) to so that a vm built on an older version can use the new api when run on later versions but IMO this is wasted effort and unnecessary complexity

Finally, one could consider implementing my adaptive approach that ensures a monotonic clock. But the Windows 8 api makes things so simple it’s (arguably) a lot of work for no gain.

> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
> Triage notifications on the go with GitHub Mobile for iOS or Android. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588#issuecomment-909280934
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210831/2b3b4a11/attachment.html>