[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Works w current vm + Alien-Core-KenD-124.mcz (PR #648)

Eliot Miranda notifications at github.com
Wed Aug 3 22:01:57 UTC 2022

@eliotmiranda commented on this pull request.

> @@ -12093,7 +12093,7 @@ $as_echo "$build_arch" >&6; }
 		riscv64) TARGET_ARCH="-march=rv64gcv -mabi=lp64d"
-			CFLAGS="-g -O2 -D__linux__ -D__riscv64__"
+			CFLAGS="-g -O2 -D__riscv64__"

Ken,  I feel uneasy with the unique solution to the offset of the thunk.  I'd rather have riscv64 be consistent with all the other platforms and adjust the offset to the thunk in thunkEntry, not in specific code in Smalltalk.  Can you live with that?

Reply to this email directly or view it on GitHub:
You are receiving this because you are subscribed to this thread.

Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/648/review/1061059444 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20220803/c07e6384/attachment.html>

More information about the Vm-dev mailing list