[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Works w current vm + Alien-Core-KenD-124.mcz (PR #648)

[Eliot Miranda]

On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:

> On 2022-08-03 15:01, Eliot Miranda wrote:
>
> > @ELIOTMIRANDA commented on this pull request.
> ..
> > Ken, I feel uneasy with the unique solution to the offset of the thunk.
> > I'd rather have riscv64 be consistent with all the other platforms and
> > adjust the offset to the thunk in thunkEntry, not in specific code in
> > Smalltalk. Can you live with that?
>
> Sure. Just remove the overwritten method. If you look at the latest,
> the offset is zero.
>

OK.  Fix thunkEntry to put back the offset and then I can merge the pull
request.

_,,,^..^,,,_
best, Eliot


-- 
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205666311
You are receiving this because you are subscribed to this thread.

Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/648/c1205666311 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20220804/372cb9d9/attachment.html>