[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 27b340: Fix a warning: bzero function prototype missing

Nicolas Cellier noreply at github.com
Tue Aug 23 10:42:25 UTC 2022


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 27b340935bb5cd472517688c2c41a0913599bc37
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/27b340935bb5cd472517688c2c41a0913599bc37
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Fix a warning: bzero function prototype missing

>../../../platforms/win32/vm/sqWin32Window.c:3221:4: warning: implicitly declaring library function 'bzero' with type 'void (void *, unsigned long long)' [-Wimplicit-function-declaration]
>          bzero(traceFlags,1024);
>          ^
>../../../platforms/win32/vm/sqWin32Window.c:3221:4: note: include the header <strings.h> or explicitly provide a declaration for 'bzero'


  Commit: 1f1edcb426b4a5a4136c98cf8ec97bdbef0759a6
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1f1edcb426b4a5a4136c98cf8ec97bdbef0759a6
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix the crashdump() function in win32 when not compiled with UNICODE

`wsprintf` is an hybrid function (a macro) for
- either `char*` version `wsprintfA`
- either `wchar_t*` version `wsprintfW`

depending on `#define UNICODE` or not define UNICODE...

If we use `wsprintf`, then we must use the `TEXT` macro for passing the format literal, and declare filename as `TCHAR*` which also is a macro.<br>
https://docs.microsoft.com/en-us/windows/win32/intl/windows-data-types-for-strings

Here we explicitily use a `wchar_t*`filename and a `wchar_t*`literal format specification, so we want to bypass UNICODE macro and explicitely use `wsprintfW`


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/085c500c9e2b...1f1edcb426b4


More information about the Vm-dev mailing list