[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

[Eliot Miranda]

@eliotmiranda requested changes on this pull request.

Hi Ken,  can you do a different version which doesn't include either of
    src/plugins/SqueakFFIPrims/RiscV64FFIPlugin.c
    src/plugins/ZipPlugin/ZipPlugin.c
?
I generate these carefully. Your generations are against changed VMMaker packages (see the static const char *moduleName = "ZipPlugin * VMMaker.oscog-eem.3218 " INT_EXT; lines).  So I don't want to accept these changes and have to regenerate the plugin files again.  Everything else looks fine.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646#pullrequestreview-1056471550
You are receiving this because you are subscribed to this thread.

Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/646/review/1056471550 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20220730/d1adeb6f/attachment.html>