[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Incorrect literal Character encoding/decoding in SistaV1 bytecode set (Issue #618)

Eliot Miranda notifications at github.com
Thu Mar 10 19:20:40 UTC 2022

I think it's safe to just make the change.  The extended form isn't in use in a VMMaker image (trunk + a lot of other stuff) so it won't affect most people.  Marcel will be affected but he can update to a new VM (right Marcel)?

Here's code that checks:
self sn browseAllSelect: [:m| m scanFor: [:a :b :c| a = 16rE1 and: [c = 16rE9]]]

Note that the change is unfortunate.  Because the existing VM doesn't clear extA afterwards setting extA can have disastrous effects in the old VM.  e.g. if followed by a block creation bytecode then that bytecode will consume the extension not cleared by the push character bytecode.  But as I said it is unlikely to bite anyone.  Fingers crossed.

Hacking the existing spec to use a sign extension is less harmful in the short term, but more harmful in the long term.

Reply to this email directly or view it on GitHub:
You are receiving this because you are subscribed to this thread.

Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/618/1064407806 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20220310/d1a1ad6c/attachment.html>

More information about the Vm-dev mailing list