David T. Lewis uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-dtl.98.mcz
==================== Summary ====================
Name: MonticelloConfigurations-dtl.98 Author: dtl Time: 21 August 2011, 1:23:49.864 pm UUID: 0a3ef28c-0cbb-4dd2-9a08-3923a305d67e Ancestors: MonticelloConfigurations-cmm.97
A configuration should not copy files into a target repository without knowledge or permission of the user. Revert prior changes until a safer implementation is proposed.
=============== Diff against MonticelloConfigurations-cmm.97 ===============
Item was changed: ----- Method: MCConfigurationBrowser>>checkDependencies (in category 'dependencies') ----- checkDependencies + ^self checkModified and: [self checkMissing]! - | missing | - missing := (self dependencies collect: - [ : ea | ea versionInfo name ]) asSet. - self repositories do: - [ : eachRepository | eachRepository cacheAllFileNamesDuring: - [ missing copy do: - [ : eachVersionName | (eachRepository includesVersionNamed: eachVersionName) ifTrue: [ missing remove: eachVersionName ] ] ] ]. - ^ missing isEmpty or: - [ self selectDependency: missing anyOne. - self confirm: - (String streamContents: - [ : strm | strm - nextPutAll: 'No repository found for' ; - cr. - missing do: - [ : r | strm - nextPutAll: r ; - cr ]. - strm nextPutAll: 'Do you still want to store?' ]) ]!
Item was added: + ----- Method: MCConfigurationBrowser>>checkMissing (in category 'dependencies') ----- + checkMissing + | missing | + missing := (self dependencies collect: + [ : ea | ea versionInfo name ]) asSet. + self repositories do: + [ : eachRepository | eachRepository cacheAllFileNamesDuring: + [ missing copy do: + [ : eachVersionName | (eachRepository includesVersionNamed: eachVersionName) ifTrue: [ missing remove: eachVersionName ] ] ] ]. + ^ missing isEmpty or: + [ self selectDependency: missing anyOne. + self confirm: + (String streamContents: + [ : strm | strm + nextPutAll: 'No repository found for' ; + cr. + missing do: + [ : r | strm + nextPutAll: r ; + cr ]. + strm nextPutAll: 'Do you still want to store?' ]) ]!
Item was changed: ----- Method: MCConfigurationBrowser>>store (in category 'actions') ----- store + (self checkRepositories and: [self checkDependencies]) ifFalse: [^self]. + self pickName ifNotNil: [:name | + self configuration name: name. + self pickRepository ifNotNil: [:repo | + repo storeVersion: self configuration]].! - (self checkRepositories and: [ self checkDependencies ]) ifFalse: [ ^ self ]. - self pickName ifNotNil: - [ : name | self configuration name: name. - self pickRepository ifNotNil: - [ : repo | repo cacheAllFileNamesDuring: - [ self configuration dependencies do: - [ : each | repo - versionWithInfo: each versionInfo - ifAbsent: [ repo storeVersion: (MCRepositoryGroup default versionWithInfo: each versionInfo) ] ] ]. - repo storeVersion: self configuration ] ]!