Squeak-dev October 2010

squeak-dev@lists.squeakfoundation.org

79 participants
264 discussions

Multiple finalizers per single object
by Igor Stasenko 01 Oct '10

01 Oct '10

Hello, i'd like to raise this subject once more, because i don't like it (or don't understand?). In all scenarios, where i met the need to use finalization, a single finalizer is sufficient. Moreover, there is always a single object who controls a weak reference, and it never leaks it out, to prevent the case, when some other object may obtain a strong reference on it, making it permanently held in object memory. Multiple different finalizers for single object, from design point of view, means that you having two different, not related frameworks, which using same object, and want to do something when it dies. A scenario, where its possible and userful, still don't comes into my mind. In contrary, whenever i see a use of finalizers, its in most cases about graceful control over external resource, such as: - file - socket - external memory and i really don't see how multiple finalizers per single resource could do any good. Suppose one finalizer closing a file handle, while another one flushing it buffer cache. Now, how you going to ensure, that one finalizer will execute first, before another one? And what if third framework comes into play and wants to add another finalizer on top of that, which should do something in the middle between flushing a cache and closing file handle? >From the above, the only conclusion can be made: use a single finalizer, and put all logic & operation ordering into it. And also, prevent leakage of object pointer (such as file handle) outside of your model, otherwise it may cause harm. That's why i think a current WeakRegistry model provoking bad design practices. I think a better behavior would be to raise an error, if something wants to register finalizer twice for a single object. -- Best regards, Igor Stasenko AKA sig.

7 20

The Inbox: SUnit-spd.82.mcz
by commits＠source.squeak.org 01 Oct '10

01 Oct '10

A new version of SUnit was added to project The Inbox: http://source.squeak.org/inbox/SUnit-spd.82.mcz ==================== Summary ==================== Name: SUnit-spd.82 Author: spd Time: 1 October 2010, 10:31:26.892 am UUID: 6332b14d-4ac9-4fdb-bffb-8e225050f415 Ancestors: SUnit-nice.81 * TestCase now uses class>>suiteClass instead of referencing the class name directly * TestSuite now uses #resultClass instead of referencing the class name directly * merged 'Accessing' protocol into 'accessing' =============== Diff against SUnit-nice.81 =============== Item was changed: ----- Method: TestCase class>>buildSuite (in category 'building suites') ----- buildSuite | suite | + suite := self suiteClass new. - suite := TestSuite new. ^ self isAbstract ifTrue: [ suite name: self name asString. self allSubclasses do: [:each | each isAbstract ifFalse: [each addToSuiteFromSelectors: suite]]. suite] ifFalse: [self addToSuiteFromSelectors: suite]! Item was changed: ----- Method: TestCase class>>buildSuiteFromMethods: (in category 'building suites') ----- buildSuiteFromMethods: testMethods | suite | + suite := (self suiteClass new) - suite := (TestSuite new) name: self name asString; yourself. ^self addToSuite: suite fromMethods: testMethods! Item was changed: + ----- Method: TestSuite>>resources (in category 'accessing') ----- - ----- Method: TestSuite>>resources (in category 'Accessing') ----- resources ^ resources ifNil: [resources := self defaultResources] ! Item was added: + ----- Method: TestSuite>>resultClass (in category 'private') ----- + resultClass + + ^ TestResult.! Item was changed: ----- Method: TestSuite>>run (in category 'running') ----- run | result | + result := self resultClass new. - result := TestResult new. self resources do: [ :res | res isAvailable ifFalse: [^res signalInitializationError]]. [self run: result] ensure: [self resources do: [:each | each reset]]. ^result ! Item was changed: + ----- Method: TestSuite>>tests (in category 'accessing') ----- - ----- Method: TestSuite>>tests (in category 'Accessing') ----- tests ^ tests ifNil: [tests := OrderedCollection new] !

1 0

shout converting := to left-arrow?
by Michal 01 Oct '10

01 Oct '10

It has been mentioned several times that we could have our cake and eat it too if := was visually converted to the left arrow by something like shout, but preserved in the source file. Has anybody done anything like this yet? (Or any other solution which gives a visual left arrow for those of us who are attached to it, but preserves := in source files) The reason for this question is that I need to use a non-patched font and I am attached to the left arrow :) Michal

1 0

The Trunk: System-eem.381.mcz
by commits＠source.squeak.org 01 Oct '10

01 Oct '10

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.381.mcz ==================== Summary ==================== Name: System-eem.381 Author: eem Time: 1 October 2010, 5:13:05.666 am UUID: fe56800a-cea9-49b7-b807-5e48494053c4 Ancestors: System-ul.380 Answer methodClassName for class comment chnages so that the change list includes class comments in "select changes for this class" et al. =============== Diff against System-ul.380 =============== Item was changed: ----- Method: ChangeRecord>>methodClassName (in category 'access') ----- methodClassName + | tokens | - | text tokens | (class isNil and: [type = #doIt + and: [(tokens := Scanner new scanTokens: self text) size >= 3 + and: [(tokens includes: #'.') not "exclude multi-statement doits" - and: [((text := self text) includes: $.) not "exclude multi-statement doits" - and: [(tokens := Scanner new scanTokens: text) size >= 4 and: [tokens first isSymbol and: [tokens first isKeyword not and: [tokens first first canBeGlobalVarInitial + and: [(tokens includes: #instanceVariableNames:) + or: [tokens second == #comment: + or: [tokens third == #comment:]]]]]]]]]) ifTrue: - and: [tokens includes: #instanceVariableNames:]]]]]]]) ifTrue: ["Could be a class definition. Class definitions start with Superclass blahSubclass: #ClassName Metaclass definitions start with ClassName class instanceVariableNames:" (tokens second isSymbol and: [tokens second isKeyword and: [tokens third isSymbol and: [tokens third isKeyword not and: [(2 to: tokens size by: 2) allSatisfy: [:i| (tokens at: i) isKeyword]]]]]) ifTrue: [^tokens third]. (tokens size = 4 and: [tokens second = #class + and: [(tokens third = #instanceVariableNames: or: [tokens third = #comment:]) - and: [tokens third = #instanceVariableNames: and: [tokens last isString]]]) ifTrue: + [^tokens first]. + (tokens size = 3 + and: [tokens second = #comment: + and: [tokens last isString]]) ifTrue: [^tokens first]]. ^class!

1 0

Jump to page: