Squeak-dev September 2010

squeak-dev@lists.squeakfoundation.org

110 participants
401 discussions

The Trunk: MultilingualTests-ar.12.mcz
by commits＠source.squeak.org 02 Sep '10

02 Sep '10

Andreas Raab uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-ar.12.mcz ==================== Summary ==================== Name: MultilingualTests-ar.12 Author: ar Time: 1 September 2010, 6:52:49.056 pm UUID: b1069f2e-2319-2148-bb4f-1f24ee1e8f46 Ancestors: MultilingualTests-HenrikSperreJohansen.10 Add tests for UTF-8 conversions. =============== Diff against MultilingualTests-HenrikSperreJohansen.10 =============== Item was added: + ----- Method: UTF8TextConverterTest>>testSqueakToUtf8 (in category 'tests') ----- + testSqueakToUtf8 + "Ensure proper encoding" + + self assert: '' squeakToUtf8 equals: ''. + self assert: 'Hello World' squeakToUtf8 equals: 'Hello World'. + self assert: 'Grüß Gott' squeakToUtf8 asByteArray + equals: #[71 114 195 188 195 159 32 71 111 116 116]! Item was added: + ----- Method: UTF8TextConverterTest>>testUtf8ToSqueak (in category 'tests') ----- + testUtf8ToSqueak + "Ensure proper encoding" + + self assert: '' utf8ToSqueak equals: ''. + self assert: 'Hello World' utf8ToSqueak equals: 'Hello World'. + self assert: #[71 114 195 188 195 159 32 71 111 116 116] asString utf8ToSqueak + equals: 'Grüß Gott' + + ! Item was added: + ----- Method: UTF8TextConverterTest>>testLazyConversion (in category 'tests') ----- + testLazyConversion + "Ensure the lazy conversions do what they should" + + | strict result | + strict := UTF8TextConverter strictUtf8Conversions. + [UTF8TextConverter strictUtf8Conversions: false. + self shouldnt:[result := 'Grüß Gott' utf8ToSqueak ] raise: Error. + ] ensure:[UTF8TextConverter strictUtf8Conversions: strict]. + + self assert: result = 'Grüß Gott'. + ! Item was added: + ----- Method: UTF8TextConverterTest>>testStrictConversion (in category 'tests') ----- + testStrictConversion + "Ensure the strict conversions do what they should" + + | strict | + strict := UTF8TextConverter strictUtf8Conversions. + [UTF8TextConverter strictUtf8Conversions: true. + self should:[ 'Grüß Gott' utf8ToSqueak ] raise: Error. + ] ensure:[UTF8TextConverter strictUtf8Conversions: strict].! Item was added: + ClassTestCase subclass: #UTF8TextConverterTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'MultilingualTests-TextConversion'!

1 0

The Trunk: Multilingual-ar.126.mcz
by commits＠source.squeak.org 02 Sep '10

02 Sep '10

Andreas Raab uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-ar.126.mcz ==================== Summary ==================== Name: Multilingual-ar.126 Author: ar Time: 1 September 2010, 6:47:21.978 pm UUID: f6128173-e8e1-374f-950f-cec8ec4c2194 Ancestors: Multilingual-nice.125 Add a preference controlling the strictness of UTF-8 conversions. While it is good to be strict in development, it can be very painful to be overly strict in production settings when the input is an external source with uncertain encoding. =============== Diff against Multilingual-nice.125 =============== Item was changed: ----- Method: UTF8TextConverter>>nextFromStream: (in category 'conversion') ----- nextFromStream: aStream + | char1 value1 char2 value2 unicode char3 value3 char4 value4 | + aStream isBinary ifTrue: [^ aStream basicNext]. + char1 := aStream basicNext. + char1 ifNil:[^ nil]. + value1 := char1 asciiValue. + value1 <= 127 ifTrue: [ + "1-byte char" + ^ char1 + ]. + + "at least 2-byte char" + char2 := aStream basicNext. + char2 ifNil:[^self errorMalformedInput: (String with: char1)]. + value2 := char2 asciiValue. + - | character value1 value2 unicode value3 value4 | - aStream isBinary ifTrue: [ ^aStream basicNext ]. - character := aStream basicNext ifNil: [ ^nil ]. - value1 := character asciiValue. - value1 <= 127 ifTrue: [ ^character ]. "1-byte character" - "at least 2-byte character" - character := aStream basicNext ifNil: [ ^self errorMalformedInput ]. - value2 := character asciiValue. (value1 bitAnd: 16rE0) = 192 ifTrue: [ + ^ Unicode value: ((value1 bitAnd: 31) bitShift: 6) + (value2 bitAnd: 63). + ]. + + "at least 3-byte char" + char3 := aStream basicNext. + char3 ifNil:[^self errorMalformedInput: (String with: char1 with: char2)]. + value3 := char3 asciiValue. - ^ Unicode value: ((value1 bitAnd: 31) bitShift: 6) + (value2 bitAnd: 63) ]. - "at least 3-byte character" - character := aStream basicNext ifNil: [ ^self errorMalformedInput ]. - value3 := character asciiValue. (value1 bitAnd: 16rF0) = 224 ifTrue: [ unicode := ((value1 bitAnd: 15) bitShift: 12) + ((value2 bitAnd: 63) bitShift: 6) + + (value3 bitAnd: 63). + ]. + - + (value3 bitAnd: 63) ]. (value1 bitAnd: 16rF8) = 240 ifTrue: [ + "4-byte char" + char4 := aStream basicNext. + char4 ifNil:[^self errorMalformedInput: (String with: char1 with: char2 with: char3)]. + value4 := char4 asciiValue. - "4-byte character" - character := aStream basicNext ifNil: [ ^self errorMalformedInput ]. - value4 := character asciiValue. unicode := ((value1 bitAnd: 16r7) bitShift: 18) + ((value2 bitAnd: 63) bitShift: 12) + ((value3 bitAnd: 63) bitShift: 6) + + (value4 bitAnd: 63). + ]. + + unicode ifNil:[^self errorMalformedInput: (String with: char1 with: char2 with: char3)]. + unicode > 16r10FFFD ifTrue: [ + ^self errorMalformedInput: (String with: char1 with: char2 with: char3). + ]. + + unicode = 16rFEFF ifTrue: [^ self nextFromStream: aStream]. - (value4 bitAnd: 63) ]. - unicode ifNil: [ ^self errorMalformedInput ]. - unicode > 16r10FFFD ifTrue: [ ^self errorMalformedInput ]. - unicode = 16rFEFF ifTrue: [ ^self nextFromStream: aStream ]. ^ Unicode value: unicode. ! Item was added: + ----- Method: UTF8TextConverter>>errorMalformedInput: (in category 'conversion') ----- + errorMalformedInput: aString + "Invalid UTF-8 input has been detected in the given string. + Raise an error if strict conversions are enabled, otherwise allow + the original string to be returned." + + ^self class errorMalformedInput: aString! Item was changed: TextConverter subclass: #UTF8TextConverter instanceVariableNames: '' + classVariableNames: 'StrictUtf8Conversions' - classVariableNames: '' poolDictionaries: '' category: 'Multilingual-TextConversion'! !UTF8TextConverter commentStamp: '<historical>' prior: 0! Text converter for UTF-8. Since the BOM is used to distinguish the MacRoman code and UTF-8 code, BOM is written for UTF-8 by #writeBOMOn: which is called by client.! Item was changed: ----- Method: UTF8TextConverter class>>decodeByteString: (in category 'conversion') ----- decodeByteString: aByteString "Convert the given string from UTF-8 using the fast path if converting to Latin-1" | outStream lastIndex nextIndex byte1 byte2 byte3 byte4 unicode | lastIndex := 1. (nextIndex := ByteString findFirstInString: aByteString inSet: latin1Map startingAt: lastIndex) = 0 ifTrue: [ ^aByteString ]. outStream := (String new: aByteString size) writeStream. [ outStream next: nextIndex - lastIndex putAll: aByteString startingAt: lastIndex. byte1 := aByteString byteAt: nextIndex. (byte1 bitAnd: 16rE0) = 192 ifTrue: [ "two bytes" byte2 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. unicode := ((byte1 bitAnd: 31) bitShift: 6) + (byte2 bitAnd: 63)]. (byte1 bitAnd: 16rF0) = 224 ifTrue: [ "three bytes" byte2 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. byte3 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte3 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte3 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. unicode := ((byte1 bitAnd: 15) bitShift: 12) + ((byte2 bitAnd: 63) bitShift: 6) + (byte3 bitAnd: 63)]. (byte1 bitAnd: 16rF8) = 240 ifTrue: [ "four bytes" byte2 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte2 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. byte3 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte3 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte3 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. byte4 := aByteString byteAt: (nextIndex := nextIndex + 1). + (byte4 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput: aByteString ]. - (byte4 bitAnd: 16rC0) = 16r80 ifFalse:[ ^self errorMalformedInput ]. unicode := ((byte1 bitAnd: 16r7) bitShift: 18) + ((byte2 bitAnd: 63) bitShift: 12) + ((byte3 bitAnd: 63) bitShift: 6) + (byte4 bitAnd: 63)]. + unicode ifNil: [ ^self errorMalformedInput: aByteString ]. - unicode ifNil: [ ^self errorMalformedInput ]. unicode = 16rFEFF ifFalse: [ "Skip byte order mark" outStream nextPut: (Unicode value: unicode) ]. lastIndex := nextIndex + 1. (nextIndex := ByteString findFirstInString: aByteString inSet: latin1Map startingAt: lastIndex) = 0 ] whileFalse. ^outStream next: aByteString size - lastIndex + 1 putAll: aByteString startingAt: lastIndex; contents ! Item was added: + ----- Method: UTF8TextConverter class>>strictUtf8Conversions (in category 'utilities') ----- + strictUtf8Conversions + "Preference setter for strict utf-8 conversions" + + <preference: 'Strict utf8 conversions' + category: 'general' "should this be localization?" + description: 'If true, invalid utf-8 input will raise errors. If false, invalid utf-8 input will be allowed to pass through the conversion unchanged' + type: #Boolean> + + ^StrictUtf8Conversions ifNil:[true] + ! Item was added: + ----- Method: UTF8TextConverter class>>errorMalformedInput: (in category 'utilities') ----- + errorMalformedInput: aString + "Invalid UTF-8 input has been detected in the given string. + Raise an error if strict conversions are enabled, otherwise allow + the original string to be returned." + + self strictUtf8Conversions ifTrue:[ + self error: 'Invalid utf8: ', aString + ]. + + ^aString! Item was added: + ----- Method: UTF8TextConverter class>>strictUtf8Conversions: (in category 'utilities') ----- + strictUtf8Conversions: aBool + "Preference setter for strict utf-8 conversions" + + StrictUtf8Conversions := aBool. + + ! Item was removed: - ----- Method: UTF8TextConverter>>errorMalformedInput (in category 'conversion') ----- - errorMalformedInput - - ^self class errorMalformedInput! Item was removed: - ----- Method: UTF8TextConverter class>>errorMalformedInput (in category 'utilities') ----- - errorMalformedInput - - ^self error: 'Invalid utf8 input detected'!

1 0

Daily Commit Log
by commits＠source.squeak.org 02 Sep '10

02 Sep '10

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2010-September/003671.… Name: Network-ar.82 Ancestors: Network-ul.81 Use HttpUrl when dealing with https, i.e., 'https://encrypted.google.com' asUrl class == HttpUrl ============================================= http://lists.squeakfoundation.org/pipermail/packages/2010-September/003672.… Name: NetworkTests-ar.19 Ancestors: NetworkTests-ar.18 Add test for https scheme -> HttpUrl handling. =============================================

1 0

The Inbox: Network-fbs.80.mcz
by commits＠source.squeak.org 01 Sep '10

01 Sep '10

A new version of Network was added to project The Inbox: http://source.squeak.org/inbox/Network-fbs.80.mcz ==================== Summary ==================== Name: Network-fbs.80 Author: fbs Time: 1 September 2010, 10:12:46.067 pm UUID: ed5bacf0-62f0-c84a-aa36-13d320b0bee9 Ancestors: Network-fbs.79 Devolve responsibility of deciding which Url subclass to instantiate by asking the subclasses directly (in reverse topological order, by inheritance). =============== Diff against Network-ar.78 =============== Item was added: + ----- Method: BrowserUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + ^ aString asLowercase = 'browser'.! Item was added: + ----- Method: MailtoUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + ^ aString asLowercase = 'mailto'.! Item was added: + ----- Method: Url class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + ^ false.! Item was added: + ----- Method: HttpUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + aString ifNil: [^true]. + ^ aString asLowercase = 'http'.! Item was added: + ----- Method: GenericUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aScheme + "Being generic, a GenericUrl understands the basic structure of all URLs." + ^ true.! Item was added: + ----- Method: FileUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + ^ aString asLowercase = 'file'.! Item was added: + ----- Method: FtpUrl class>>handlesScheme: (in category 'testing') ----- + handlesScheme: aString + ^ aString asLowercase = 'ftp'.! Item was changed: ----- Method: Url class>>urlClassForScheme: (in category 'parsing') ----- urlClassForScheme: scheme + scheme ifNil: [^HttpUrl]. + ^ self allSubclasses reverse detect: [:each | each handlesScheme: scheme] ifNone: [GenericUrl].! - (scheme isNil or: [scheme = 'http']) ifTrue: [^HttpUrl]. - scheme = 'ftp' ifTrue: [^FtpUrl]. - scheme = 'file' ifTrue: [^FileUrl]. - scheme = 'mailto' ifTrue: [^MailtoUrl]. - scheme = 'browser' ifTrue: [^BrowserUrl]. - ^GenericUrl!

1 0

The Inbox: NetworkTests-fbs.19.mcz
by commits＠source.squeak.org 01 Sep '10

01 Sep '10

A new version of NetworkTests was added to project The Inbox: http://source.squeak.org/inbox/NetworkTests-fbs.19.mcz ==================== Summary ==================== Name: NetworkTests-fbs.19 Author: fbs Time: 1 September 2010, 10:11:44.362 pm UUID: 98b12986-cf50-ad42-a158-fe315627b1eb Ancestors: NetworkTests-fbs.18 Devolve responsibility of deciding which Url subclass to instantiate by asking the subclasses directly (in reverse topological order, by inheritance). =============== Diff against NetworkTests-ar.17 =============== Item was added: + ----- Method: UrlTest>>testHandlesScheme (in category 'tests') ----- + testHandlesScheme + self assert: (BrowserUrl handlesScheme: 'browser') description: 'browser'. + self assert: (BrowserUrl handlesScheme: 'BROWSER') description: 'BROWSER'. + self assert: (FileUrl handlesScheme: 'file') description: 'file'. + self assert: (FileUrl handlesScheme: 'FILE') description: 'FILE'. + self assert: (FtpUrl handlesScheme: 'ftp') description: 'ftp'. + self assert: (FtpUrl handlesScheme: 'FTP') description: 'FTP'. + self assert: (HttpUrl handlesScheme: 'http') description: 'http'. + self assert: (HttpUrl handlesScheme: 'HTTP') description: 'HTTP'. + self assert: (MailtoUrl handlesScheme: 'mailto') description: 'mailto'. + self assert: (MailtoUrl handlesScheme: 'MAILTO') description: 'MAILTO'. + + self assert: (HttpUrl handlesScheme: nil) description: 'http'. + #('file' 'ftp' 'unknown' nil) + do: [:each | self assert: (GenericUrl handlesScheme: each) description: each].!

1 0

Monticello package names, class categories
by Frank Shearar 01 Sep '10

01 Sep '10

Andreas' latest commit had me looking at my SIP stack for the first time in a while. I had named it Network-SIP, because SIP's a network protocol, and I thought of the naming convention as indicating a nested approach. It seems that I'm mistaken here though - really, categories are a flat space, so classes in Network-SIP show up as part of the Network package. If I now understand correctly then, the mapping between class categories and packages uses the first token of the category name (so the characters before the first '-'). Is that right? If so then I think I should rename my categories from Network-SIP-Foo to, say, SipStack-Foo, yes? (Like WebClient isn't Network-WWW.) frank

2 1

Serial ports on Linux
by Schwab,Wilhelm K 01 Sep '10

01 Sep '10

I have been able to do serial I/O on Windows, but not Linux. Running in a terminal to capture output yields "Error while saving old state" while trying to open just about any number or name I can think of (including 0 and /dev/ttyS0), but the open method gives no indication that there is a problem; it returns a perfectly valid looking serial port with the #port set to whatever it was given. Subsequent reads fail, and are probably a bit more honest about what is happening: "Error while reading: serial port is not open." I am not sure whether that is always the case, but it certainly is on this machine when I try /dev/ttyUSB0, which does not exist here. Any ideas? Bill

2 1

[Informal Report] Building the next FunSqueak using Cog - 2
by Edgar J. De Cleene 01 Sep '10

01 Sep '10

Fixing Navigator In trunk, Flaps is out the first sight. For see Flaps do World menu , flaps, show shared Flaps Navigator is still disabled so you type "golden" in the Search box of Docking Bar. You find a method and Flaps makeNavigatorFlapResembleGoldenBar, select and do it. FIND button fails if you holds down the button for more places This time no Rompecabezas (Morphic-Puzzle), trunk do not have the logic for just loading the MorphicPuzzle-edc.2 But i wish Jerome continue doing his super job, so take the troubles for manually fillOut his code of older FunSqueak and reload in a new project. Then I export the morphs and load again in this build . All works except PluggableSystemWindow.morph (his tutorial of how work with MixedCXurves and new fills) So I remade , hope he like or replace/improves. Going to server and continue when time lets me. Edgar

1 0

The Trunk: NetworkTests-ar.19.mcz
by commits＠source.squeak.org 01 Sep '10

01 Sep '10

Andreas Raab uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-ar.19.mcz ==================== Summary ==================== Name: NetworkTests-ar.19 Author: ar Time: 1 September 2010, 12:33:28.449 am UUID: d77514b9-9d54-4543-a286-0a0883ae6bff Ancestors: NetworkTests-ar.18 Add test for https scheme -> HttpUrl handling. =============== Diff against NetworkTests-ar.18 =============== Item was added: + ClassTestCase subclass: #HttpUrlTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'NetworkTests-Url'! Item was added: + ----- Method: HttpUrlTest>>testHttps (in category 'as yet unclassified') ----- + testHttps + self assert: 'https://encrypted.google.com' asUrl class == HttpUrl!

1 0

The Trunk: Network-ar.82.mcz
by commits＠source.squeak.org 01 Sep '10

01 Sep '10

Andreas Raab uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-ar.82.mcz ==================== Summary ==================== Name: Network-ar.82 Author: ar Time: 1 September 2010, 12:32:08.542 am UUID: aa52635f-d746-5744-b432-582c5ba62b11 Ancestors: Network-ul.81 Use HttpUrl when dealing with https, i.e., 'https://encrypted.google.com' asUrl class == HttpUrl =============== Diff against Network-ul.81 =============== Item was changed: ----- Method: Url class>>urlClassForScheme: (in category 'parsing') ----- urlClassForScheme: scheme (scheme isNil or: [scheme = 'http']) ifTrue: [^HttpUrl]. + scheme = 'https' ifTrue: [^HttpUrl]. scheme = 'ftp' ifTrue: [^FtpUrl]. scheme = 'file' ifTrue: [^FileUrl]. scheme = 'mailto' ifTrue: [^MailtoUrl]. scheme = 'browser' ifTrue: [^BrowserUrl]. ^GenericUrl!

1 0

Jump to page: