Squeak-dev April 2011

squeak-dev@lists.squeakfoundation.org

80 participants
387 discussions

The Trunk: Kernel-ul.577.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.577.mcz ==================== Summary ==================== Name: Kernel-ul.577 Author: ul Time: 30 April 2011, 4:06:16.848 am UUID: f674fdde-21e4-f14c-a297-a29dfe42219c Ancestors: Kernel-ul.576, Kernel-ul.575 Merged. =============== Diff against Kernel-ul.576 =============== Item was removed: - ----- Method: BlockContext>>copyTo:blocks: (in category 'private') ----- - copyTo: aContext blocks: dict - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home." - - | copy | - self == aContext ifTrue: [^ nil]. - copy := self copy. - (dict at: self home ifAbsentPut: [OrderedCollection new]) add: copy. - self sender ifNotNil: [ - copy privSender: (self sender copyTo: aContext blocks: dict)]. - ^ copy! Item was changed: ----- Method: ContextPart>>copyTo: (in category 'query') ----- copyTo: aContext + "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender." - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home. It is best to use BlockClosures instead. They only hold a ContextTag, which will work for all copies of the original home context." + | copy | + self == aContext ifTrue: [ ^nil ]. + copy := self copy. + sender ifNotNil: [ copy privSender: (sender copyTo: aContext) ]. + ^copy! - ^ self copyTo: aContext blocks: IdentityDictionary new! Item was removed: - ----- Method: ContextPart>>copyTo:blocks: (in category 'private') ----- - copyTo: aContext blocks: dict - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home." - - | copy | - self == aContext ifTrue: [^ nil]. - copy := self copy. - dict at: self ifPresent: [:blocks | blocks do: [:b | b privHome: copy]]. - self sender ifNotNil: [ - copy privSender: (self sender copyTo: aContext blocks: dict)]. - ^ copy! Item was added: + ----- Method: ContextPart>>copyTo:bottomContextDo: (in category 'query') ----- + copyTo: aContext bottomContextDo: aBlock + "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. Evaluate aBlock with the copy of bottom context when it still points to the original sender." + + | copy | + self == aContext ifTrue: [ ^nil ]. + copy := self copy. + sender + ifNil: [ aBlock value: copy ] + ifNotNil: [ + sender == aContext ifTrue: [ aBlock value: copy ]. + copy privSender: (sender copyTo: aContext bottomContextDo: aBlock) ]. + ^copy!

1 0

The Trunk: Kernel-ul.575.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.575.mcz ==================== Summary ==================== Name: Kernel-ul.575 Author: ul Time: 28 April 2011, 12:03:58.259 am UUID: 33ed898b-6592-984b-b1e6-d9f2a778f216 Ancestors: Kernel-ul.574 - removed support for BlockContexts from ContextPart >> #copyTo: - added a new method #copyTo:bottomContextDo: which provides access to the bottom context during copying =============== Diff against Kernel-ul.574 =============== Item was removed: - ----- Method: BlockContext>>copyTo:blocks: (in category 'private') ----- - copyTo: aContext blocks: dict - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home." - - | copy | - self == aContext ifTrue: [^ nil]. - copy := self copy. - (dict at: self home ifAbsentPut: [OrderedCollection new]) add: copy. - self sender ifNotNil: [ - copy privSender: (self sender copyTo: aContext blocks: dict)]. - ^ copy! Item was changed: ----- Method: ContextPart>>copyTo: (in category 'query') ----- copyTo: aContext + "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender." - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home. It is best to use BlockClosures instead. They only hold a ContextTag, which will work for all copies of the original home context." + | copy | + self == aContext ifTrue: [ ^nil ]. + copy := self copy. + sender ifNotNil: [ copy privSender: (sender copyTo: aContext) ]. + ^copy! - ^ self copyTo: aContext blocks: IdentityDictionary new! Item was removed: - ----- Method: ContextPart>>copyTo:blocks: (in category 'private') ----- - copyTo: aContext blocks: dict - "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. BlockContexts whose home is also copied will point to the copy. However, blockContexts that are not on the stack but may be later will not have their home pointing in the new copied thread. So an error will be raised if one of these tries to return directly to its home." - - | copy | - self == aContext ifTrue: [^ nil]. - copy := self copy. - dict at: self ifPresent: [:blocks | blocks do: [:b | b privHome: copy]]. - self sender ifNotNil: [ - copy privSender: (self sender copyTo: aContext blocks: dict)]. - ^ copy! Item was added: + ----- Method: ContextPart>>copyTo:bottomContextDo: (in category 'query') ----- + copyTo: aContext bottomContextDo: aBlock + "Copy self and my sender chain down to, but not including, aContext. End of copied chain will have nil sender. Evaluate aBlock with the copy of bottom context when it still points to the original sender." + + | copy | + self == aContext ifTrue: [ ^nil ]. + copy := self copy. + sender + ifNil: [ aBlock value: copy ] + ifNotNil: [ + sender == aContext ifTrue: [ aBlock value: copy ]. + copy privSender: (sender copyTo: aContext bottomContextDo: aBlock) ]. + ^copy!

1 0

leadingChar question
by Levente Uzonyi 30 Apr '11

30 Apr '11

Hi, I think we found a bug, but I'm interested in your opinion before "fixing" it. Some TextConverters (e.g. ISO88592TextConverter) implement #leadingChar. The problem is that this #leadingChar is added to all decoded characters. Since character equality takes leadingChar into account, these decoded characters will never be equal to unicode characters. The following example returns false, because the carriage return (13) will be decoded as (Character value: 58720269): (String cr convertFromWithConverter: ISO88592TextConverter new) = String cr The current system (Collections, Compiler, etc) assumes that the first 256 characters are unique and doesn't care about the variants of these characters which have non-zero leadingChar. So, I think we should change Character class >> #leadingChar:code: to ignore it's first argument, when the second is less than 256. Also, I think only TextConverters of CJKV languages should implement #leadingChar, because AFAIK only the characters of those languages are unified. What do you think? Cheers, Levente

1 2

The Trunk: Multilingual-ul.141.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-ul.141.mcz ==================== Summary ==================== Name: Multilingual-ul.141 Author: ul Time: 26 April 2011, 2:26:32.742 am UUID: ecda4489-6940-b043-8aba-881d913f4985 Ancestors: Multilingual-nice.140 Removed #leadingChar and it's usage from ByteTextConverter and it's subclasses. Only CJKV characters should have leadingChar. =============== Diff against Multilingual-nice.140 =============== Item was changed: ----- Method: ByteTextConverter>>decode: (in category 'private') ----- decode: aByte "Answer a decoded squeak character corresponding to aByte code. Note that aByte does necessary span in the range 0...255, since this receiver is a ByteTextEncoder." | code | ((code := self class decodeTable at: 1 + aByte) = -1 or: [code = 16rFFFD]) ifTrue: [^nil]. + ^Character value: code! - ^ Character leadingChar: self leadingChar code: code! Item was removed: - ----- Method: ByteTextConverter>>leadingChar (in category 'friend') ----- - leadingChar - self subclassResponsibility! Item was removed: - ----- Method: CP1250TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^0! Item was removed: - ----- Method: CP1253TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^ GreekEnvironment leadingChar! Item was removed: - ----- Method: ISO88592TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^Latin2Environment leadingChar! Item was removed: - ----- Method: ISO88597TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^GreekEnvironment leadingChar! Item was removed: - ----- Method: Latin1TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^0! Item was removed: - ----- Method: MacRomanTextConverter>>leadingChar (in category 'friend') ----- - leadingChar - - ^ 0. - !

1 0

The Trunk: Collections-ul.440.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.440.mcz ==================== Summary ==================== Name: Collections-ul.440 Author: ul Time: 26 April 2011, 2:37:08.897 am UUID: 4c084629-af8b-3740-b919-ec87f228c915 Ancestors: Collections-kb.439 - ignore the leadingChar for unique characters in Character class >> #leadingChar:code: - fixed the copying of Characters =============== Diff against Collections-kb.439 =============== Item was changed: ----- Method: Character class>>leadingChar:code: (in category 'instance creation') ----- leadingChar: leadChar code: code code >= 16r400000 ifTrue: [ self error: 'code is out of range'. ]. leadChar >= 256 ifTrue: [ self error: 'lead is out of range'. ]. + code < 256 ifTrue: [ ^self value: code ]. - ^self value: (leadChar bitShift: 22) + code.! Item was changed: ----- Method: Character>>clone (in category 'copying') ----- clone + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super clone! - "Answer with the receiver, because Characters are unique."! Item was changed: ----- Method: Character>>copy (in category 'copying') ----- copy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super copy! - "Answer with the receiver because Characters are unique."! Item was changed: ----- Method: Character>>deepCopy (in category 'copying') ----- deepCopy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super deepCopy! - "Answer with the receiver because Characters are unique."! Item was added: + ----- Method: Character>>shallowCopy (in category 'copying') ----- + shallowCopy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super shallowCopy! Item was changed: ----- Method: Character>>veryDeepCopyWith: (in category 'copying') ----- veryDeepCopyWith: deepCopier + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super veryDeepCopyWith: deepCopier! - "Return self. I can't be copied."!

1 0

The Trunk: Kernel-ul.576.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.576.mcz ==================== Summary ==================== Name: Kernel-ul.576 Author: ul Time: 30 April 2011, 3:48:56.834 am UUID: 46b435fa-0bc5-954d-8b1b-37a9e581c85a Ancestors: Kernel-ul.574 - documented the issues with Behavior >> #commentsIn: - remove SortedCollection (mis)usage from #allSubclassesWithLevelDo:startingLevel: =============== Diff against Kernel-ul.574 =============== Item was changed: ----- Method: Behavior>>allSubclassesWithLevelDo:startingLevel: (in category 'accessing class hierarchy') ----- allSubclassesWithLevelDo: classAndLevelBlock startingLevel: level "Walk the tree of subclasses, giving the class and its level" + - | subclassNames | classAndLevelBlock value: self value: level. self == Class ifTrue: [^ self]. "Don't visit all the metaclasses" "Visit subclasses in alphabetical order" + self subclasses + sort: [ :a :b | a name <= b name ]; + do: [ :subclass | + subclass + allSubclassesWithLevelDo: classAndLevelBlock + startingLevel: level + 1 ]! - subclassNames := SortedCollection new. - self subclassesDo: [:subC | subclassNames add: subC name]. - subclassNames do: - [:name | (self environment at: name) - allSubclassesWithLevelDo: classAndLevelBlock - startingLevel: level+1]! Item was changed: ----- Method: Behavior>>commentsIn: (in category 'accessing method dictionary') ----- commentsIn: sourceString + "Return the comments as a collection of strings in sourceString. This method along with #nextQuotePosIn:startingFrom: is wrong, because it assumes that all double quote characters are comment delimiters, but even this method has a double quote which is not part of any method comment. Also this method has nothing to do with the Behavior itself. Probably CompiledMethod is the best place for this." - | commentStart nextQuotePos someComments aPos | + (sourceString includes: $") ifFalse: [^#()]. - ('*"*' match: sourceString) ifFalse: [^#()]. someComments:= OrderedCollection new. - sourceString size = 0 ifTrue: [^ someComments]. aPos:=1. nextQuotePos:= 0. [commentStart := sourceString findString: '"' startingAt: aPos. nextQuotePos:= self nextQuotePosIn: sourceString startingFrom: commentStart. (commentStart ~= 0 and: [nextQuotePos >commentStart])] whileTrue: [ commentStart ~= nextQuotePos ifTrue: [ someComments add: ((sourceString copyFrom: commentStart + 1 to: nextQuotePos - 1) copyReplaceAll: '""' with: '"').]. aPos := nextQuotePos+1]. ^someComments!

1 0

The Trunk: HelpSystem-Core-ul.55.mcz
by commits＠source.squeak.org 30 Apr '11

30 Apr '11

Levente Uzonyi uploaded a new version of HelpSystem-Core to project The Trunk: http://source.squeak.org/trunk/HelpSystem-Core-ul.55.mcz ==================== Summary ==================== Name: HelpSystem-Core-ul.55 Author: ul Time: 30 April 2011, 3:46:54.613 am UUID: c08fa36e-76fb-f54a-8747-356b8be3e315 Ancestors: HelpSystem-Core-tbn.54 - avoid possible speed degradation for large APIs - minor refactoring for cleaner and faster code =============== Diff against HelpSystem-Core-tbn.54 =============== Item was changed: ----- Method: ClassAPIHelpBuilder>>build (in category 'building') ----- build + CurrentReadOnlySourceFiles cacheDuring: [ + topicToBuild := (HelpTopic named: rootToBuildFrom name). + topicToBuild icon: (HelpIcons iconNamed: #pageIcon). + topicToBuild contents: rootToBuildFrom comment. - | instanceSide classSide | - topicToBuild := (HelpTopic named: rootToBuildFrom name). - topicToBuild icon: (HelpIcons iconNamed: #pageIcon). - topicToBuild contents: rootToBuildFrom comment. + addMethods ifTrue: [ self buildSubnodesForMethods ]. + addSubclasses ifTrue: [ self buildSubnodesForSubclasses ] ]. - addMethods ifTrue: [ self buildSubnodesForMethods ]. - addSubclasses ifTrue: [ self buildSubnodesForSubclasses ]. ! Item was changed: ----- Method: ClassAPIHelpBuilder>>buildMethodTopicsOn:for: (in category 'private building') ----- buildMethodTopicsOn: topic for: aClass - |stream comments methodComment| - stream := String new writeStream. - aClass selectors asSortedCollection do: - [:selector | - stream - nextPutAll: aClass name; - nextPutAll: '>>'; - nextPutAll: selector asString; - cr. - comments := aClass commentsAt: selector. - methodComment := (comments size = 0) - ifTrue: [ 'Method has no comment.' ] - ifFalse: [ comments first ]. - - stream nextPutAll: methodComment;cr;cr. - ]. - topic contents: stream contents. + topic contents: (String streamContents: [ :stream | + aClass selectors sort do: [ :selector | + stream + nextPutAll: aClass name; + nextPutAll: '>>'; + nextPutAll: selector asString; + cr; + nextPutAll: ( + (aClass commentsAt: selector) + at: 1 + ifAbsent: [ 'Method has no comment.' ]); + cr; cr ] ])! - !

1 0

ObjectTracer inheritance problem (was: Re: [squeak-dev] Tool problem: flattenHierarchy...)
by Chris Muller 29 Apr '11

29 Apr '11

After some digging, I finally discovered the cause of this "tool" problem is that there are two classes in the system which each have ObjectTracer class (and, therefore its subclass, ObjectViewer class) as a subclass. The two superclasses are, Class and ProtoObject class. I guess Class should have ObjectTracer class removed as its other subclass besides ProtoObject? This is true even in our latest Squeak4.3alpha-11314 image on the ftp server. :-( I see that Kernel-bf.565 made a change related in this area. Any advice or action is greatly appreciated. - Chris On Thu, Apr 28, 2011 at 1:21 PM, Frank Shearar <frank.shearar(a)angband.za.org> wrote: > On 2011/04/28 16:47, Frank Shearar wrote: >> >> On 2011/04/28 16:33, Chris Muller wrote: >>> >>> Sorry, I can't work on this - to reproduce, >>> >>> 1) browse implementors of chooseInstVarThenDo: >>> 2) try to spawn a hierarchy from the opened MessageSet. >>> >>> After a longish pause, a debugger opens; nil is getting into the >>> hierarchy. >> >> The long pause is understandable: ClassDescription generates a large >> hierarchy, which you can examine by evaluating: >> >> Browser new createHierarchyTreeOf: ClassDescription allSuperclasses, >> {ClassDescription}, ClassDescription allSubclasses >> >> I'll look at what I broke this afternoon/evening. > > Huh. It's not actually Browser's fault. I have an image based on trunk > #11196 where I did all my Browser hacking; loading the latest > Tools(-cmm.345) spawns a ClassDescription hierarchy just fine. > > That doesn't mean I know where the problem _is_, just one place where it is > _not_. > > (What might be really cool is if we could have something that, when > something's added to a repository (like Trunk), generates a browseable > history thing: lists of versions, diffs between versions, and so on. I don't > care if that's in-image or in a web browser; it'd just make things like > finding out the current problem a lot easier.) > > frank > >

3 2

COG refrence on squeak.org
by Nicolas Cellier 29 Apr '11

29 Apr '11

The site (http://www.squeak.org/) tells COG ...bla... It is available on our ftp site. But it appears that the ftp site (http://ftp.squeak.org/Cog/) provides outdated copies of VMMaker and I guess no one can go much further with this material. Please replace the link or remove. Nicolas

1 0

Off The Shelf 3D TV
by Ben Coman 29 Apr '11

29 Apr '11

Recently there was some discussion about ways Squeak might take over the world, of which I think Croquet/Cobalt 3D was one possibility. Distantly related to this, I was blown away by the videos linked below, which present two methods of cheap tracking interacting with an off-the-shelf 3DTV. I felt there might be some fantastic synergy between this and squeak. Maybe in a while I'll be capable looking into it further myself - but for now, just sharing a random inspiration. cheers, Ben

1 1

Jump to page: