Squeak-dev April 2011

squeak-dev@lists.squeakfoundation.org

80 participants
387 discussions

Re: [squeak-dev] The Trunk: Monticello-cmm.461.mcz
by Levente Uzonyi 26 Apr '11

26 Apr '11

On Mon, 25 Apr 2011, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of Monticello to project The Trunk: > http://source.squeak.org/trunk/Monticello-cmm.461.mcz > > ==================== Summary ==================== > > Name: Monticello-cmm.461 > Author: cmm > Time: 24 April 2011, 7:16:14.664 pm > UUID: 8bac38b5-8083-4b26-9b55-3c26fd8bc16f > Ancestors: Monticello-nice.460 > > - Extend support for MCConfigurations to regular MCDirectoryRepository's. > - Categorized some methods. > - Constructor method for MCDirectoryRepository. > - Fixed memory-leak; when a repository adds to its 'cache', it should always keep it resized. There are two new failing tests after these changes: - MCSnapshotTest >> #testCreation - MCChangeNotificationTest >> #testExtMethodModified Also, some tests sometimes fail, because they ran for more than five seconds (on my pc with Cog). The cause of the slowdown is MCFileBasedRepository >> #readableFileNames's #difference: calculation (O(n*m) runtime). In theory it would be faster (O(n+m)) to create a Set from the argument, but calculating the hash (and the equality) of MCVersionName is too slow to make this faster in practical cases. Levente

2 2

[ANN] SqueakSource3 Beta.1 "Easter Fire"
by Tobias Pape 26 Apr '11

26 Apr '11

Dear Smalltalkers, gladly I would like to announce the first Beta of SqueakSource3 “Easter Fire”. To try it, take your favorite Monticello-API and install the Metacello configuration. N.B.: The SqueakSource-Configuration has a dependency on Seaside3, however, if you happen to not have Seaside installed previously there will be no adaptor chosen for you. So, it is preferable to install Seaside3 with the settings you like before installing SqueakSource. "===" "GemStone. N.B.: You probably need an almostOutOfMemory-guard." Gofer project load: 'SqueakSource' version: #easterFire group: #( 'Full' ). "--" "Squeak" Installer squeaksource project: 'MetacelloRepository' install: 'ConfigurationOfSqueakSource'. ((Smalltalk globals at: #ConfigurationOfSqueakSource) project version: #easterFire) load. "--" "Pharo" Gofer new squeaksource: MetacelloRepository; package: 'ConfigurationOfSqueakSource'; load. ((Smalltalk at: #ConfigurationOfSqueakSource) project version: #easterFire) load. "===" SqueakSource3 is a port of SqueakSource to Seaside 3 and Magritte 2. It is based on the original SqueakSource by Lukas Renggli, Adrian Lienhard, and Avi Bryant; moreover recent changes to several SqueakSource-forks are incorporated, too. Some features like access to diffs in a browser as done by Bert Freudenberg for source.squeak.org have been integrated into SqueakSource3. SqueakSource3 incorporates a basic issue tracker done by Dale Henrichs. SqueakSource3 is expected to run on GemStone/GLASS as well as on squeakish Smalltalks, ie, Pharo and Squeak. “easter fire” has been tested on GemStone 2.4.4.x/GLASS 1.0-beta.8 and Squeak4.2 both with Seaside 3.0.4. Pharo-tests are pending. The agenda for SqueakSource3 in random order is: • Have it running on GemStone, esp. GemStone 3 beta • Provide a cleaner external API (may be REST or XMLRPC) • Provide a more clear modularization and extension api (example: the Issue component by Dale Henrichs) • Name it…suggestions are welcome. • Stability. Philippe Marschal, Dale Henrichs, and Gerhard Obermann have contributed much to SqueakSource3. All feedback is appreciated. So Long, -Tobias

1 0

Error when removing the last method from a MessageSet
by Levente Uzonyi 26 Apr '11

26 Apr '11

Hi, I was removing all methods from an implementors browser and when I removed the last one, I got an error (attemt to index non-existent element in an ordered collection), because Browser >> #reformulateList is not prepared for this case. A possible solution is to return nil from #lastMessageName when there are no messages, though I'm not 100% sure this is the right thing to do. Cheers, Levente

2 1

The Inbox: Tools-fbs.345.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-fbs.345.mcz ==================== Summary ==================== Name: Tools-fbs.345 Author: fbs Time: 26 April 2011, 8:44:19.26 am UUID: 52e2c842-2c27-0247-8b93-05056b5ab133 Ancestors: Tools-fbs.344 Levente Uzonyi found that deleting the last message in a MessageSet raised an error. This fixes the error by checking the list of messages: if there are no messages in the Browser (or subclass) instance, then explicitly select "no method selected". =============== Diff against Tools-fbs.344 =============== Item was changed: ----- Method: Browser>>reformulateList (in category 'message list') ----- reformulateList "If the receiver has a way of reformulating its message list, here is a chance for it to do so" super reformulateList. (self messageList includes: self selectedMessageName) + ifFalse: [ self messageList + ifEmpty: [ self selectMessageNamed: nil ] + ifNotEmpty: [ self selectMessageNamed: self lastMessageName ]].! - ifFalse: [ self selectMessageNamed: self lastMessageName ].!

1 0

Browser gets confused when you delete a class
by Balázs Kósi 26 Apr '11

26 Apr '11

Hi, Similar to the previous problem: you get debuggers when you delete a class, with a method of it selected. Balázs

3 2

The Trunk: Monticello-ul.462.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

Levente Uzonyi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ul.462.mcz ==================== Summary ==================== Name: Monticello-ul.462 Author: ul Time: 26 April 2011, 4:20:27.919 am UUID: aa640223-b26d-b643-8d1d-8a1ac25deeaa Ancestors: Monticello-cmm.461 - avoid unnecessary allocations in MCDirectoryRepository >> #allFileNames - speed up MCFileBasedRepository >> #readableFileNames by caching the hashes of cached MCVersionNames and using a Set for #difference: computation =============== Diff against Monticello-cmm.461 =============== Item was changed: ----- Method: MCDirectoryRepository>>allFileNames (in category 'accessing') ----- allFileNames + + ^directory entries + sort: [ :a :b | a modificationTime >= b modificationTime ]; + replace: [ :ea | ea name asMCVersionName ]! - ^ (directory entries sortBy: [:a :b | a modificationTime >= b modificationTime]) collect: [:ea | ea name asMCVersionName]! Item was changed: ----- Method: MCFileBasedRepository>>readableFileNames (in category 'private-files') ----- readableFileNames "Answer an Array of MCVersionNames representing every file in this repository; first the ones from the cache (whether or not they still exist in the repository) followed by every other file in this repository that Monticello can read." + + | all cached new hashes cachedSet | - | all cached new | all := self allFileNamesOrCache. "from repository" cached := self cachedFileNames. "in memory" + "The following is for caching the hashes of cached MCVersionNames." + hashes := IdentityDictionary new: cached size. + cached do: [ :each | hashes at: each put: each hash ]. + cachedSet := PluggableSet new: cached size. + cachedSet hashBlock: [ :element | hashes at: element ifAbsent: [ 1 ] ]. + cachedSet addAll: cached. + new := all difference: cachedSet. - new := all difference: cached. ^ (cached asArray, new) select: [:ea | self canReadFileNamed: ea]!

1 0

The Trunk: Tests-ul.125.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

Levente Uzonyi uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ul.125.mcz ==================== Summary ==================== Name: Tests-ul.125 Author: ul Time: 26 April 2011, 5:30:22.768 am UUID: 13f774fc-876e-2d44-b440-893682808fa5 Ancestors: Tests-nice.124 Ensure that snapshots created by Monticello's tests are removed from the package cache. =============== Diff against Tests-nice.124 =============== Item was changed: ----- Method: MCChangeNotificationTest>>tearDown (in category 'running') ----- tearDown + + super tearDown. workingCopy unregister! Item was changed: ----- Method: MCClassDefinitionTest>>tearDown (in category 'as yet unclassified') ----- tearDown + + super tearDown. Smalltalk at: 'MCMockClassC' ifPresent: [:c | c removeFromSystem]! Item was changed: ----- Method: MCDirectoryRepositoryTest>>tearDown (in category 'as yet unclassified') ----- tearDown + + super tearDown. self directory recursiveDelete! Item was changed: ----- Method: MCFileInTest>>tearDown (in category 'running') ----- tearDown + + super tearDown. (diff isNil or: [diff isEmpty not]) ifTrue: [expected updatePackage: self mockPackage]! Item was changed: ----- Method: MCInitializationTest>>tearDown (in category 'as yet unclassified') ----- tearDown + + super tearDown. (MCWorkingCopy forPackage: self mockPackage) unregister! Item was changed: ----- Method: MCMczInstallerTest>>tearDown (in category 'as yet unclassified') ----- tearDown + + super tearDown. expected snapshot updatePackage: self mockPackage. self deleteFile.! Item was changed: ----- Method: MCMethodDefinitionTest>>tearDown (in category 'running') ----- tearDown + + super tearDown. self restoreMocks. (MCWorkingCopy forPackage: (MCPackage named: 'FooBarBaz')) unregister. self class compile: 'override ^ 1' classified: 'mocks'. self ownPackage modified: isModified. ! Item was changed: ----- Method: MCPackageTest>>tearDown (in category 'running') ----- tearDown + + super tearDown. self mockSnapshot install! Item was changed: ----- Method: MCPatchTest>>tearDown (in category 'as yet unclassified') ----- tearDown + + super tearDown. self restoreMocks! Item was added: + ----- Method: MCTestCase>>clearPackageCache (in category 'running') ----- + clearPackageCache + "Remove all mock packages created during the tests from the package cache." + + | directory | + directory := MCCacheRepository default directory. + (directory fileNamesMatching: self mockVersionName, '*') do: [ :each | + directory deleteFileNamed: each ]! Item was added: + ----- Method: MCTestCase>>tearDown (in category 'running') ----- + tearDown + + self clearPackageCache! Item was changed: ----- Method: MCWorkingCopyTest>>clearPackageCache (in category 'running') ----- clearPackageCache + "Remove all mock packages created during the tests from the package cache." + + | directory | + super clearPackageCache. + directory := MCCacheRepository default directory. + (directory fileNamesMatching: self packageName, '*') do: [ :each | + directory deleteFileNamed: each ]! - | dir | - dir := MCCacheRepository default directory. - (dir fileNamesMatching: 'MonticelloMocks*') do: [:ea | dir deleteFileNamed: ea]. - (dir fileNamesMatching: 'MonticelloTest*') do: [:ea | dir deleteFileNamed: ea]. - (dir fileNamesMatching: 'rev*') do: [:ea | dir deleteFileNamed: ea]. - (dir fileNamesMatching: 'foo-*') do: [:ea | dir deleteFileNamed: ea]. - (dir fileNamesMatching: 'foo2-*') do: [:ea | dir deleteFileNamed: ea].! Item was changed: ----- Method: MCWorkingCopyTest>>tearDown (in category 'running') ----- tearDown + + super tearDown. workingCopy unregister. self restoreMocks. - self clearPackageCache. Utilities setAuthorInitials: savedInitials.!

1 0

The Trunk: Files-ul.108.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

Levente Uzonyi uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-ul.108.mcz ==================== Summary ==================== Name: Files-ul.108 Author: ul Time: 26 April 2011, 4:17:22.631 am UUID: 6db817ff-7efb-0846-b0f8-27cdf91b3e65 Ancestors: Files-dtl.107 - use #== for Symbol-Symbol comparison =============== Diff against Files-dtl.107 =============== Item was changed: ----- Method: FileDirectory>>directoryContentsFor:do: (in category 'private') ----- directoryContentsFor: fullPath do: aBlock "Do aBlock for the files and directories in the directory with the given path. See primLookupEntryIn:index: for further details." | f entryArray index | f := fullPath asVmPathName. index := 1. [(entryArray := self primLookupEntryIn: f index: index) == nil] whileFalse: [ + #badDirectoryPath == entryArray ifTrue: [ - #badDirectoryPath = entryArray ifTrue: [ ^(InvalidDirectoryError pathName: pathName) signal]. index := index + 1. aBlock value: (DirectoryEntry fromArray: entryArray directory: self) convertFromSystemName]!

1 0

The Inbox: Multilingual-ul.141.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

A new version of Multilingual was added to project The Inbox: http://source.squeak.org/inbox/Multilingual-ul.141.mcz ==================== Summary ==================== Name: Multilingual-ul.141 Author: ul Time: 26 April 2011, 2:26:32.742 am UUID: ecda4489-6940-b043-8aba-881d913f4985 Ancestors: Multilingual-nice.140 Removed #leadingChar and it's usage from ByteTextConverter and it's subclasses. Only CJKV characters should have leadingChar. =============== Diff against Multilingual-nice.140 =============== Item was changed: ----- Method: ByteTextConverter>>decode: (in category 'private') ----- decode: aByte "Answer a decoded squeak character corresponding to aByte code. Note that aByte does necessary span in the range 0...255, since this receiver is a ByteTextEncoder." | code | ((code := self class decodeTable at: 1 + aByte) = -1 or: [code = 16rFFFD]) ifTrue: [^nil]. + ^Character value: code! - ^ Character leadingChar: self leadingChar code: code! Item was removed: - ----- Method: ByteTextConverter>>leadingChar (in category 'friend') ----- - leadingChar - self subclassResponsibility! Item was removed: - ----- Method: CP1250TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^0! Item was removed: - ----- Method: CP1253TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^ GreekEnvironment leadingChar! Item was removed: - ----- Method: ISO88592TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^Latin2Environment leadingChar! Item was removed: - ----- Method: ISO88597TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^GreekEnvironment leadingChar! Item was removed: - ----- Method: Latin1TextConverter>>leadingChar (in category 'friend') ----- - leadingChar - ^0! Item was removed: - ----- Method: MacRomanTextConverter>>leadingChar (in category 'friend') ----- - leadingChar - - ^ 0. - !

1 0

The Inbox: Collections-ul.440.mcz
by commits＠source.squeak.org 26 Apr '11

26 Apr '11

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ul.440.mcz ==================== Summary ==================== Name: Collections-ul.440 Author: ul Time: 26 April 2011, 2:37:08.897 am UUID: 4c084629-af8b-3740-b919-ec87f228c915 Ancestors: Collections-kb.439 - ignore the leadingChar for unique characters in Character class >> #leadingChar:code: - fixed the copying of Characters =============== Diff against Collections-kb.439 =============== Item was changed: ----- Method: Character class>>leadingChar:code: (in category 'instance creation') ----- leadingChar: leadChar code: code code >= 16r400000 ifTrue: [ self error: 'code is out of range'. ]. leadChar >= 256 ifTrue: [ self error: 'lead is out of range'. ]. + code < 256 ifTrue: [ ^self value: code ]. - ^self value: (leadChar bitShift: 22) + code.! Item was changed: ----- Method: Character>>clone (in category 'copying') ----- clone + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super clone! - "Answer with the receiver, because Characters are unique."! Item was changed: ----- Method: Character>>copy (in category 'copying') ----- copy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super copy! - "Answer with the receiver because Characters are unique."! Item was changed: ----- Method: Character>>deepCopy (in category 'copying') ----- deepCopy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super deepCopy! - "Answer with the receiver because Characters are unique."! Item was added: + ----- Method: Character>>shallowCopy (in category 'copying') ----- + shallowCopy + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super shallowCopy! Item was changed: ----- Method: Character>>veryDeepCopyWith: (in category 'copying') ----- veryDeepCopyWith: deepCopier + "Characters from 0 to 255 are unique, copy only the rest." + + value < 256 ifTrue: [ ^self ]. + ^super veryDeepCopyWith: deepCopier! - "Return self. I can't be copied."!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
39
Older →

Jump to page: