Squeak-dev November 2012

squeak-dev@lists.squeakfoundation.org

56 participants
115 discussions

Daily Commit Log
by commits＠source.squeak.org 05 Nov '12

05 Nov '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-November/005548.h… Name: KernelTests-dtl.235 Ancestors: KernelTests-ul.234 As of Kernel-cmm.671 Timespans created in the context of an offset will start in that offset, and when no context is available the defaultOffset for a Timespan will be zero. This affects a TimeStamp created from a string representation of itself, which will now have zero offset (UTC). Update TimeStampTest to reflect to this behavior. =============================================

1 0

The Trunk: KernelTests-dtl.235.mcz
by commits＠source.squeak.org 04 Nov '12

04 Nov '12

David T. Lewis uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-dtl.235.mcz ==================== Summary ==================== Name: KernelTests-dtl.235 Author: dtl Time: 4 November 2012, 1:08:04.014 pm UUID: de45cee9-3416-4fd8-a216-b5cafe70ee57 Ancestors: KernelTests-ul.234 As of Kernel-cmm.671 Timespans created in the context of an offset will start in that offset, and when no context is available the defaultOffset for a Timespan will be zero. This affects a TimeStamp created from a string representation of itself, which will now have zero offset (UTC). Update TimeStampTest to reflect to this behavior. =============== Diff against KernelTests-ul.234 =============== Item was changed: ----- Method: TimeStampTest>>testFromSeconds (in category 'Tests') ----- testFromSeconds + "A time stamp from seconds is created in the local time zone, so offset may + be non-zero. The test timestamp has offset zero (implying UTC). Comparison + to the test timestamp should succeed if and only if both time stamps are + created relative to the same time zone (UTC)." + | local utc | + local := self timestampClass fromSeconds: 3124958100. + local offset = Duration zero + ifTrue: [self assert: local = timestamp.] + ifFalse: [self deny: local = timestamp.]. + utc := local offset: Duration zero. + self assert: utc = timestamp.! - self - assert: (self timestampClass fromSeconds: 3124958100) = timestamp.! Item was changed: ----- Method: TimeStampTest>>testReadFromA1 (in category 'testing') ----- testReadFromA1 + "Conversion to and from a string (with implied UTC offset) is equal if + and only if the time stamp has zero offset." |ts| + ts := TimeStamp current offset: Duration zero. "current as UTC" + self assert: (ts = (TimeStamp fromString: ts asString)). + ts := TimeStamp current offset: (Duration hours: 1). + self deny: (ts = (TimeStamp fromString: ts asString)). + ! - ts := TimeStamp current. - self assert: (ts = (TimeStamp fromString: ts asString)).!

1 0

OSX Test Results
by glenpaling 04 Nov '12

04 Nov '12

On my mac, I get few difference in my collection of 6 remaining errors. Here's the Cog results: Image ----- /Applications/Smalltalk/archive/target/UpdatedFromLastReleaseImage.image Squeak4.3 latest update: #12269 Current Change Set: Unnamed1 Virtual Machine --------------- /Applications/Smalltalk/Build/VMs/Cog.app/Contents/MacOS/Croquet Croquet Closure Cog VM [CoInterpreter VMMaker.oscog-eem.201] Croquet Cog 4.0.2585 Mac OS X built on Aug 14 2012 09:17:19 Compiler: 4.2.1 (Apple Inc. build 5666) (dot 3) platform sources revision VM: r2585 http://www.squeakvm.org/svn/squeak/branches/Cog Plugins: r2545 http://squeakvm.org/svn/squeak/trunk/platforms/Cross/plugins CoInterpreter VMMaker.oscog-eem.201 uuid: 56cdd078-6771-401a-8bed-68402a0e283d Aug 14 2012 StackToRegisterMappingCogit VMMaker.oscog-eem.201 uuid: 56cdd078-6771-401a-8bed-68402a0e283d Aug 14 2012 Test Runner 3264 run, 3240 passes, 18 expected failures, 6 failures, 0 errors, 0 unexpected passes LargeNegativeIntegerTest>>#testMinimumNegativeIntegerArithmetic LocaleTest>>#testLocaleChanged SocketTest>>#testSocketReuse SocketTest>>#testUDP TimeStampTest>>#testFromSeconds TimeStampTest>>#testReadFromA1 and the older VM from the Squeak 4.3 All In One distribution: Image ----- /Applications/Smalltalk/Squeak-4.3-All-in-One trunk.app/Contents/Resources/Squeak4.3.image Squeak4.3 latest update: #12269 Current Change Set: Unnamed Virtual Machine --------------- /Applications/Smalltalk/Squeak-4.3-All-in-One trunk.app/Contents/MacOS/Squeak VM Opt Squeak3.8.1 of '28 Aug 2006' [latest update: #6747] 4.3 Mac Carbon 4.2.4b1 28-Mar-10 >45CAAEAC-5A1E-4327-9702-7973E3473FDE< Test Runner 3264 run, 3235 passes, 23 expected failures, 6 failures, 0 errors, 0 unexpected passes LocaleTest>>#testLocaleChanged ProcessTest>>#testAtomicSuspend SocketTest>>#testSocketReuse SocketTest>>#testUDP TimeStampTest>>#testFromSeconds TimeStampTest>>#testReadFromA1 -- View this message in context: http://forum.world.st/OSX-Test-Results-tp4653929.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

Daily Commit Log
by commits＠source.squeak.org 04 Nov '12

04 Nov '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-November/005547.h… Name: NetworkTests-dtl.33 Ancestors: NetworkTests-ul.32 Fix SocketTest>>testSendTimeout to accommodate platform differences. Explanation: #sendDone means that the platform is reporting a send operation complete. The platform may or may not be able to accept addition write requests while sending is in process, depending on the buffering capability of the underlying platform. On Windows, the next write request fails immediately if a prior send is not complete, while unix platforms may be able to accept and buffer additional writes. Therefore change the test to expect a timeout exception to eventually occur, but not necessary on the next write operation. =============================================

1 0

Re: [squeak-dev] The Trunk: NetworkTests-dtl.33.mcz
by David T. Lewis 03 Nov '12

03 Nov '12

This should get us to either 4 or 5 remaining test failures on the squeakci.org tests, depending on VM. I'll note for the record that SocketTest>>testSocketReuse fails on my computer at home (SuSE Linux), but passes on squeakci.org. I presume this is due to another platform difference, but it's not showing up on the radar for our Squeak 4.4 release preparation so I'm not going to worry about it right now. Dave On Sat, Nov 03, 2012 at 06:17:47PM +0000, commits(a)source.squeak.org wrote: > David T. Lewis uploaded a new version of NetworkTests to project The Trunk: > http://source.squeak.org/trunk/NetworkTests-dtl.33.mcz > > ==================== Summary ==================== > > Name: NetworkTests-dtl.33 > Author: dtl > Time: 3 November 2012, 2:17:02.043 pm > UUID: 3071c11f-8cef-43a2-b1b8-88c573ef9daf > Ancestors: NetworkTests-ul.32 > > Fix SocketTest>>testSendTimeout to accommodate platform differences. > > Explanation: #sendDone means that the platform is reporting a send operation complete. The platform may or may not be able to accept addition write requests while sending is in process, depending on the buffering capability of the underlying platform. On Windows, the next write request fails immediately if a prior send is not complete, while unix platforms may be able to accept and buffer additional writes. Therefore change the test to expect a timeout exception to eventually occur, but not necessary on the next write operation. > > =============== Diff against NetworkTests-ul.32 =============== > > Item was changed: > ----- Method: SocketTest>>testSendTimeout (in category 'tests') ----- > testSendTimeout > "Test data transfer and related methods" > > + | buffer ex | > - | buffer | > self testServerAccept. > buffer := ByteArray new: 1000. > + > + "Write to the socket until the platform reports that sending is not complete." > [serverSocket sendDone] whileTrue:[ > serverSocket sendSomeData: buffer. > ]. > + > + "The network layer is now either blocked or in the process of sending data in its buffers. > + It may or may not be able buffer additional write requests, depending on the platform > + implemention. Keep sending data until the network reports that it is unable to process > + the request, at which time a exception will be raised. On Windows, the exception will > + be raised on the next write request, while unix platforms may provide additional buffering > + that permit write requests to continue being accepted." > + ex := nil. > + [[serverSocket sendSomeData: buffer startIndex: 1 count: buffer size for: 1] > + on: ConnectionTimedOut > + do: [ :e | ex := e ]. > + ex isNil] whileTrue: []. > + self assert: ex notNil. > - self should:[serverSocket sendSomeData: buffer startIndex: 1 count: buffer size for: 1] > - raise: ConnectionTimedOut. > ! >

4 4

MCWorkingCopyTest>>testSimpleMerge (was Re: [squeak-dev] The Trunk: NetworkTests-dtl.33.mcz)
by Frank Shearar 03 Nov '12

03 Nov '12

On 3 November 2012 21:11, Herbert König <herbertkoenig(a)gmx.net> wrote: > Hi, > > This should get us to either 4 or 5 remaining test failures on the > squeakci.org tests, depending on VM. I'll note for the record that > SocketTest>>testSocketReuse fails on my computer at home (SuSE Linux), but > passes on squeakci.org. I presume this is due to another platform > difference, but it's not showing up on the radar for our Squeak 4.4 release > preparation so I'm not going to worry about it right now. > > as I managed to bring my Windows 7 Laptop but not the power supply I ran the > tests under XP, current update. > I updated to Trunk #12269, disabled the IPV6 preference and got: > > 3264 run, 3239 passes, 18 expected failures, 6 failures, 1 errors, 0 > unexpected passes, > http://i.minus.com/iMxj47re2dyfN.PNG > The error console roughly translates to: getnameinfo: the requested name is > valid and was found in the database. It does not have the correct associated > data ehich should be evaluated. Thanks, Herbert! MCWorkingCopyTest>>testSimpleMerge looks interesting - that's a test that passed on CI. Would you mind poking it, maybe getting a stack trace or similar? What's making it fail? frank > Cheers > > Herbert > > >

2 1

The Trunk: NetworkTests-dtl.33.mcz
by commits＠source.squeak.org 03 Nov '12

03 Nov '12

David T. Lewis uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-dtl.33.mcz ==================== Summary ==================== Name: NetworkTests-dtl.33 Author: dtl Time: 3 November 2012, 2:17:02.043 pm UUID: 3071c11f-8cef-43a2-b1b8-88c573ef9daf Ancestors: NetworkTests-ul.32 Fix SocketTest>>testSendTimeout to accommodate platform differences. Explanation: #sendDone means that the platform is reporting a send operation complete. The platform may or may not be able to accept addition write requests while sending is in process, depending on the buffering capability of the underlying platform. On Windows, the next write request fails immediately if a prior send is not complete, while unix platforms may be able to accept and buffer additional writes. Therefore change the test to expect a timeout exception to eventually occur, but not necessary on the next write operation. =============== Diff against NetworkTests-ul.32 =============== Item was changed: ----- Method: SocketTest>>testSendTimeout (in category 'tests') ----- testSendTimeout "Test data transfer and related methods" + | buffer ex | - | buffer | self testServerAccept. buffer := ByteArray new: 1000. + + "Write to the socket until the platform reports that sending is not complete." [serverSocket sendDone] whileTrue:[ serverSocket sendSomeData: buffer. ]. + + "The network layer is now either blocked or in the process of sending data in its buffers. + It may or may not be able buffer additional write requests, depending on the platform + implemention. Keep sending data until the network reports that it is unable to process + the request, at which time a exception will be raised. On Windows, the exception will + be raised on the next write request, while unix platforms may provide additional buffering + that permit write requests to continue being accepted." + ex := nil. + [[serverSocket sendSomeData: buffer startIndex: 1 count: buffer size for: 1] + on: ConnectionTimedOut + do: [ :e | ex := e ]. + ex isNil] whileTrue: []. + self assert: ex notNil. - self should:[serverSocket sendSomeData: buffer startIndex: 1 count: buffer size for: 1] - raise: ConnectionTimedOut. !

1 0

The Inbox: Tools-jmg.426.mcz
by commits＠source.squeak.org 03 Nov '12

03 Nov '12

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jmg.426.mcz ==================== Summary ==================== Name: Tools-jmg.426 Author: jmg Time: 2 November 2012, 8:29:30.822 pm UUID: daaf005c-5185-49b4-ba46-b6b9e68ecbc3 Ancestors: Tools-ul.425 When changing or adding categories I was frustrated by the fact that the categories shown in the list weren't sorted alphabetically, which made it hard for me to quickly scan the list to see if there was a category similar to the one I was thinking of (ie: I am drawing in a morph, so I want a category related to drawing). I could use the search bar but sometimes I just wanted to scan the list. I changed the methods presenting the list so that the categories were shown alphabetically, while preserving the special convenience categories at the start of the list (ie: new..., and the categories in the current morph). =============== Diff against Tools-ul.425 =============== Item was changed: ----- Method: Browser>>addCategory (in category 'message category functions') ----- addCategory + "Present a choice of categories or prompt for a new category name + and add it before the current selection, or at the end if no current + selection" - "Present a choice of categories or prompt for a new category name and add it before the current selection, or at the end if no current selection" | labels reject lines menuIndex newName oldCategory | + self okToChange + ifFalse: [^ self]. + self hasClassSelected + ifFalse: [^ self]. + labels := OrderedCollection new. - self okToChange ifFalse: [^ self]. - self hasClassSelected ifFalse: [^ self]. - labels := OrderedCollection with: 'new...'. reject := Set new. + reject addAll: self selectedClassOrMetaClass organization categories; + add: ClassOrganizer nullCategory; + add: ClassOrganizer default. - reject - addAll: self selectedClassOrMetaClass organization categories; - add: ClassOrganizer nullCategory; - add: ClassOrganizer default. lines := OrderedCollection new. + self selectedClassOrMetaClass allSuperclasses + do: [:cls | | cats | cls = Object + ifFalse: [cats := cls organization categories + reject: [:cat | reject includes: cat]. + cats isEmpty + ifFalse: [lines add: labels size. + labels addAll: cats. + reject addAll: cats]]]. + labels sort. + labels addFirst: 'new...'. + newName := (labels size = 1 + or: [menuIndex := UIManager default + chooseFrom: labels + lines: lines + title: 'Add Category'. + menuIndex = 0 + ifTrue: [^ self]. + menuIndex = 1]) + ifTrue: [self request: 'Please type new category name' initialAnswer: 'category name'] + ifFalse: [labels at: menuIndex]. - self selectedClassOrMetaClass allSuperclasses do: [:cls | | cats | - cls = Object ifFalse: [ - cats := cls organization categories reject: - [:cat | reject includes: cat]. - cats isEmpty ifFalse: [ - lines add: labels size. - labels addAll: cats asSortedCollection. - reject addAll: cats]]]. - newName := (labels size = 1 or: [ - menuIndex := (UIManager default chooseFrom: labels lines: lines title: 'Add Category'). - menuIndex = 0 ifTrue: [^ self]. - menuIndex = 1]) - ifTrue: [ - self request: 'Please type new category name' - initialAnswer: 'category name'] - ifFalse: [ - labels at: menuIndex]. oldCategory := self selectedMessageCategoryName. newName isEmpty ifTrue: [^ self] ifFalse: [newName := newName asSymbol]. self classOrMetaClassOrganizer addCategory: newName before: (self hasMessageCategorySelected - ifFalse: [nil] ifTrue: [self selectedMessageCategoryName]). self changed: #messageCategoryList. + self + selectMessageCategoryNamed: (oldCategory isNil + ifTrue: [self classOrMetaClassOrganizer categories last] + ifFalse: [oldCategory]). + self changed: #messageCategoryList! - self selectMessageCategoryNamed: - (oldCategory isNil - ifTrue: [self classOrMetaClassOrganizer categories last] - ifFalse: [oldCategory]). - self changed: #messageCategoryList. - ! Item was changed: ----- Method: CodeHolder>>categoryFromUserWithPrompt:for: (in category 'categories') ----- categoryFromUserWithPrompt: aPrompt for: aClass "self new categoryFromUserWithPrompt: 'testing' for: SystemDictionary" | labels myCategories reject lines newName menuIndex | + labels := OrderedCollection new. + myCategories := aClass organization categories asSortedCollection: + [:a :b | a asLowercase < b asLowercase]. - labels := OrderedCollection with: 'new...'. - labels addAll: (myCategories := aClass organization categories asSortedCollection: - [:a :b | a asLowercase < b asLowercase]). reject := myCategories asSet. reject add: ClassOrganizer nullCategory; add: ClassOrganizer default. lines := OrderedCollection with: 1 with: (myCategories size + 1). aClass allSuperclasses do: [:cls | | cats | cats := cls organization categories reject: [:cat | reject includes: cat]. cats isEmpty ifFalse: [lines add: labels size. labels addAll: (cats asSortedCollection: [:a :b | a asLowercase < b asLowercase]). reject addAll: cats]]. + labels sort. + labels addAllFirst: (myCategories). + labels addFirst: 'new...'. - newName := (labels size = 1 or: [menuIndex := (UIManager default chooseFrom: labels lines: lines title: aPrompt). menuIndex = 0 ifTrue: [^ nil]. menuIndex = 1]) ifTrue: [UIManager default request: 'Please type new category name' initialAnswer: 'category name'] ifFalse: [labels at: menuIndex]. ^ newName ifNotNil: [newName asSymbol]!

1 0

Daily Commit Log
by commits＠source.squeak.org 03 Nov '12

03 Nov '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-November/005546.h… Name: Compiler-eem.238 Ancestors: Compiler-cwp.237 Fix slip with return special literal encoding. =============================================

1 0

The Trunk: Compiler-eem.238.mcz
by commits＠source.squeak.org 02 Nov '12

02 Nov '12

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.238.mcz ==================== Summary ==================== Name: Compiler-eem.238 Author: eem Time: 2 November 2012, 10:21:57.286 am UUID: fe35e20e-713b-4bb0-88e3-e3f8badf4921 Ancestors: Compiler-cwp.237 Fix slip with return special literal encoding. =============== Diff against Compiler-cwp.237 =============== Item was changed: ----- Method: VariableNode>>sizeCodeForReturn: (in category 'code generation') ----- sizeCodeForReturn: encoder encoder if: code + isSpecialLiteralForReturn: - isSpecialLiteralForPush: [:specialLiteral| ^encoder sizeReturnSpecialLiteral: specialLiteral]. (self code = LdSelf or: [self code = LdSuper]) ifTrue: [^encoder sizeReturnReceiver]. ^super sizeCodeForReturn: encoder!

1 0