Squeak-dev June 2012

squeak-dev@lists.squeakfoundation.org

41 participants
155 discussions

The Inbox: Network-dtl.127.mcz
by commits＠source.squeak.org 14 Jun '12

14 Jun '12

A new version of Network was added to project The Inbox: http://source.squeak.org/inbox/Network-dtl.127.mcz ==================== Summary ==================== Name: Network-dtl.127 Author: dtl Time: 13 June 2012, 10:24:48.022 pm UUID: ba365401-387d-4dff-acb1-1b81b3bc8383 Ancestors: Network-dtl.126 Protect SocketAddressInformation creation with a mutex semaphore because it calls primitives that maintain state within the SocketPlugin. Raise ConnectionTimedOut if a connection request has actually timed out, otherwise raise ConnectionRefused. Fix exception message in connectTo:port:waitForConnectionFor: to use hostAddress printString because hostAddress is now a SocketAddress. =============== Diff against Network-dtl.126 =============== Item was changed: ----- Method: Socket>>connectTo:port:waitForConnectionFor: (in category 'connection open/close') ----- connectTo: hostAddress port: port waitForConnectionFor: timeout "Initiate a connection to the given port at the given host address. Waits until the connection is established or time outs." self connectNonBlockingTo: hostAddress port: port. self waitForConnectionFor: timeout + ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ', hostAddress printString] + ifRefused: [ConnectionRefused signal: 'Cannot connect to ', hostAddress printString]! - ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ' - , self remoteSocketAddress hostNumber , ':' , port asString]! Item was changed: ----- Method: Socket>>connectTo:waitForConnectionFor: (in category 'ipv6') ----- connectTo: aSocketAddress waitForConnectionFor: timeout self connectNonBlockingTo: aSocketAddress. self waitForConnectionFor: timeout + ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ', aSocketAddress printString] + ifRefused: [ConnectionRefused signal: 'Cannot connect to ', aSocketAddress printString]! - ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ', aSocketAddress printString]! Item was changed: ----- Method: Socket>>waitForConnectionFor: (in category 'waiting') ----- waitForConnectionFor: timeout "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." ^self waitForConnectionFor: timeout ifTimedOut: [ConnectionTimedOut signal: 'Failed to connect in ', timeout asString, ' seconds'] + ifRefused: [ConnectionRefused signal: 'Failed to connect in ', timeout asString, ' seconds'] ! Item was changed: ----- Method: Socket>>waitForConnectionFor:ifTimedOut: (in category 'waiting') ----- waitForConnectionFor: timeout ifTimedOut: timeoutBlock "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." + ^ self waitForConnectionFor: timeout ifTimedOut: timeoutBlock ifRefused: timeoutBlock + ! - | startTime msecsDelta msecsEllapsed status | - startTime := Time millisecondClockValue. - msecsDelta := (timeout * 1000) truncated. - status := self primSocketConnectionStatus: socketHandle. - [(status = WaitingForConnection) and: [(msecsEllapsed := Time millisecondsSince: startTime) < msecsDelta]] - whileTrue: [ - semaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed. - status := self primSocketConnectionStatus: socketHandle]. - - status = Connected ifFalse: [^timeoutBlock value]. - ^ true! Item was added: + ----- Method: Socket>>waitForConnectionFor:ifTimedOut:ifRefused: (in category 'waiting') ----- + waitForConnectionFor: timeout ifTimedOut: timeoutBlock ifRefused: refusedBlock + "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." + + | startTime msecsDelta msecsEllapsed status | + startTime := Time millisecondClockValue. + msecsDelta := (timeout * 1000) truncated. + status := self primSocketConnectionStatus: socketHandle. + status = Connected ifTrue: [^true]. + [(status = WaitingForConnection) and: [(msecsEllapsed := Time millisecondsSince: startTime) < msecsDelta]] + whileTrue: [ + semaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed. + status := self primSocketConnectionStatus: socketHandle]. + status = Connected + ifFalse: [ + status = WaitingForConnection + ifTrue: [timeoutBlock value] + ifFalse: [refusedBlock value]. + ^false]. + ^ true! Item was changed: ----- Method: Socket>>waitForConnectionUntil: (in category 'waiting') ----- waitForConnectionUntil: deadline "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." | status | status := self primSocketConnectionStatus: socketHandle. + self isConnected ifTrue: [^status]. [(status = WaitingForConnection) and: [Time millisecondClockValue < deadline]] whileTrue: [ semaphore waitTimeoutMSecs: (deadline - Time millisecondClockValue). status := self primSocketConnectionStatus: socketHandle]. ^ status = Connected ! Item was changed: Object subclass: #SocketAddressInformation instanceVariableNames: 'socketAddress addressFamily socketType protocol' + classVariableNames: 'AddressFamilyINET4 AddressFamilyINET6 AddressFamilyLocal AddressFamilyUnspecified NumericFlag PassiveFlag PrimitiveAccessProtect ProtocolTCP ProtocolUDP ProtocolUnspecified SocketTypeDGram SocketTypeStream SocketTypeUnspecified' - classVariableNames: 'AddressFamilyINET4 AddressFamilyINET6 AddressFamilyLocal AddressFamilyUnspecified NumericFlag PassiveFlag ProtocolTCP ProtocolUDP ProtocolUnspecified SocketTypeDGram SocketTypeStream SocketTypeUnspecified' poolDictionaries: '' category: 'Network-Kernel'! !SocketAddressInformation commentStamp: '<historical>' prior: 0! I represent a local or remote network service. Instance Variables addressFamily: <SmallInteger> the address family (unix, inet4, inet6, ...) in which the service address is available. protocol: <SmallInteger> the protocol (tcp, udp, ...) that the service uses. socketAddress: <SocketAddress> the socket address at which the service can be contacted or created. socketType: <SmallInteger> the type (stream, dgram) of the socket that should be created for communication with the service. ! Item was changed: ----- Method: SocketAddressInformation class>>forHost:service:flags:addressFamily:socketType:protocol: (in category 'instance creation') ----- forHost: hostName service: servName flags: flags addressFamily: family socketType: type protocol: protocol | result addr | + PrimitiveAccessProtect critical: [ + NetNameResolver initializeNetwork. + NetNameResolver + primGetAddressInfoHost: hostName + service: servName + flags: flags + family: family + type: type + protocol: protocol. + result := OrderedCollection new. + [(addr := NetNameResolver nextSocketAddressInformation) notNil] + whileTrue: [result add: addr]]. + ^ result! - NetNameResolver initializeNetwork. - NetNameResolver primGetAddressInfoHost: hostName service: servName flags: flags family: family type: type protocol: protocol. - result := OrderedCollection new. - [(addr := NetNameResolver nextSocketAddressInformation) notNil] whileTrue: [result add: addr]. - ^result! Item was changed: ----- Method: SocketAddressInformation class>>initialize (in category 'class initialization') ----- + initialize + "SocketAddressInformation initialize" - initialize "SocketAddressInformation initialize" NumericFlag := 1. PassiveFlag := 2. AddressFamilyUnspecified := 0. AddressFamilyLocal := 1. AddressFamilyINET4 := 2. AddressFamilyINET6 := 3. SocketTypeUnspecified := 0. SocketTypeStream := 1. SocketTypeDGram := 2. ProtocolUnspecified := 0. ProtocolTCP := 1. + ProtocolUDP := 2. + + "SocketPlugin maintains internal state across primitive calls, so methods that rely + on the result of sequential primitive calls require concurrency control." + PrimitiveAccessProtect := Semaphore forMutualExclusion. + ! - ProtocolUDP := 2.! Item was changed: ----- Method: SocketAddressInformation>>connect (in category 'circuit setup') ----- connect | sock | socketType == SocketTypeStream ifFalse: [^nil]. sock := Socket newTCP: addressFamily. sock connectTo: socketAddress. sock waitForConnectionFor: Socket standardTimeout + ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ', self printString] + ifRefused: [ConnectionRefused signal: 'Cannot connect to ', self printString]. - ifTimedOut: [ConnectionTimedOut signal: 'Cannot connect to ', self printString]. ^sock!

1 0

Tests for Futures?
by Frank Shearar 13 Jun '12

13 Jun '12

Has anyone ever written tests for Futures? We have tests for Promise, but there are no in-image tests for FutureMaker and the Project/MorphicProject parts (at least, from what I can see). If there are tests floating around in some random repo, where can I find them? frank

1 0

FFI question: array of structures as parameter
by Douglas McPherson 12 Jun '12

12 Jun '12

All, I'm trying to call a function in an external library which takes an array of structures as one of its parameters. I can see how to define a subclass of ExternalStructure, and how that creates convenient field accessors which read/write an underlying ByteArray. I can see how to use such an ExternalStructure to pass the struct, or a pointer to it, to a function in the library. Is there a similar object I can create which allows me to read/write an array of these structs (i.e. does the proper marshaling to/from a ByteArray)? I got the i/f working by rolling my own -- directly filling up a ByteArray with the right number of instances of the serialized-by-hand structure, creating an ExternalData instance with said ByteArray as the handle, and passing this as the parameter. But this doesn't allow me to use the field accessor methods created by ExternalStructure, so it feels like I'm missing something. For concreteness, the API looks something like this: typedef struct { uint32_t someId; int32_t someInt; } fooStruct; int32_t apiFunction ( const fooStruct *foo_list, uint32_t foo_list_size ); Any suggestions? Thanks, Doug

3 5

Daily Commit Log
by commits＠source.squeak.org 12 Jun '12

12 Jun '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-June/005383.html Name: ToolBuilder-Morphic-bf.86 Ancestors: ToolBuilder-Morphic-cmm.85 Protect dropping in lists. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-June/005384.html Name: Tools-fbs.413 Ancestors: Tools-eem.412 #showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-June/005385.html Name: ShoutCore-fbs.35 Ancestors: ShoutCore-ul.34 An SHTextStyler shouldn't double initialise itself. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-June/005386.html Name: Kernel-fbs.698 Ancestors: Kernel-fbs.697, Kernel-nice.694 Remerge Kernel-nice.694: Protect floorLog: 2 for case of exceptional float values (because exponent does not) Change exponent primitive fallback code to avoid a recursion with floorLog2: Note that I created a separate selector #exponentFromBitPattern for handling fallback, because it's easier to test. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-June/005387.html Name: Kernel-fbs.699 Ancestors: Kernel-fbs.698, Kernel-nice.695 Remerge Kernel-nice.695: Provides a new version of significandAsInteger that relies on regular Float arithmetic and regular asInteger conversion. In case of exceptional values, use the old behaviour, that is directly extract the bit pattern, but without implied one at position 53. Marginally faster than old version - sorry, not significantly. =============================================

1 0

Re: [squeak-dev] The Trunk: Kernel-fbs.697.mcz
by Bert Freudenberg 11 Jun '12

11 Jun '12

On 2012-06-09, at 21:41, commits(a)source.squeak.org wrote: > Frank Shearar uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-fbs.697.mcz > > ==================== Summary ==================== > > Name: Kernel-fbs.697 > Author: fbs > Time: 8 June 2012, 2:58:00.068 pm > UUID: bcec51c0-7e42-4f78-897b-73b99f088354 > Ancestors: Kernel-nice.693 > > * The resolver instvar is initialised to an Array so #ifNotNil: is a no-op. > * #evaluateResolver: reimplemented #cull:; rather use BlockClosure's version - less duplication. This, too, is based on an old version. Kernel-nice.694 and Kernel-nice.695 are not merged. When you commit to trunk using Monticello, it should warn you about newer versions. Apparently you use a different method? - Bert -

4 6

Re: [squeak-dev] The Trunk: Kernel-fbs.699.mcz
by Frank Shearar 11 Jun '12

11 Jun '12

On 11 June 2012 21:15, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-fbs.699.mcz > > ==================== Summary ==================== > > Name: Kernel-fbs.699 > Author: fbs > Time: 11 June 2012, 9:15:23.072 pm > UUID: 82d9060f-aaf6-4a84-934f-c7bcdd053e56 > Ancestors: Kernel-fbs.698, Kernel-nice.695 > > Remerge Kernel-nice.695: > > Provides a new version of significandAsInteger that relies on regular Float arithmetic and regular asInteger conversion. > In case of exceptional values, use the old behaviour, that is directly extract the bit pattern, but without implied one at position 53. > Marginally faster than old version - sorry, not significantly. > > =============== Diff against Kernel-fbs.698 =============== > > Item was changed: > ----- Method: Float>>significandAsInteger (in category 'truncation and round off') ----- > significandAsInteger > + "Answer the mantissa of a Float shifted so as to have the ulp equal to 1. > + For exceptional values, infinity and nan, just answer the bit pattern." > > + self isFinite ifTrue: > + [^(self timesTwoPower: self class precision - 1 - (self exponent max: self class emin)) truncated abs]. > + ^(((self basicAt: 1) bitAnd: 16r000FFFFF) bitShift: 32) bitOr: (self basicAt: 2)! > - | exp sig | > - exp := self exponent. > - sig := (((self at: 1) bitAnd: 16r000FFFFF) bitShift: 32) bitOr: (self at: 2). > - (exp > -1023 and: [self ~= 0.0]) > - ifTrue: [sig := sig bitOr: (1 bitShift: 52)]. > - ^ sig.! Right, that ought to repair my little SNAFU there. frank

1 0

The Trunk: Kernel-fbs.699.mcz
by commits＠source.squeak.org 11 Jun '12

11 Jun '12

Frank Shearar uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fbs.699.mcz ==================== Summary ==================== Name: Kernel-fbs.699 Author: fbs Time: 11 June 2012, 9:15:23.072 pm UUID: 82d9060f-aaf6-4a84-934f-c7bcdd053e56 Ancestors: Kernel-fbs.698, Kernel-nice.695 Remerge Kernel-nice.695: Provides a new version of significandAsInteger that relies on regular Float arithmetic and regular asInteger conversion. In case of exceptional values, use the old behaviour, that is directly extract the bit pattern, but without implied one at position 53. Marginally faster than old version - sorry, not significantly. =============== Diff against Kernel-fbs.698 =============== Item was changed: ----- Method: Float>>significandAsInteger (in category 'truncation and round off') ----- significandAsInteger + "Answer the mantissa of a Float shifted so as to have the ulp equal to 1. + For exceptional values, infinity and nan, just answer the bit pattern." + self isFinite ifTrue: + [^(self timesTwoPower: self class precision - 1 - (self exponent max: self class emin)) truncated abs]. + ^(((self basicAt: 1) bitAnd: 16r000FFFFF) bitShift: 32) bitOr: (self basicAt: 2)! - | exp sig | - exp := self exponent. - sig := (((self at: 1) bitAnd: 16r000FFFFF) bitShift: 32) bitOr: (self at: 2). - (exp > -1023 and: [self ~= 0.0]) - ifTrue: [sig := sig bitOr: (1 bitShift: 52)]. - ^ sig.!

1 0

The Trunk: Kernel-fbs.698.mcz
by commits＠source.squeak.org 11 Jun '12

11 Jun '12

Frank Shearar uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fbs.698.mcz ==================== Summary ==================== Name: Kernel-fbs.698 Author: fbs Time: 11 June 2012, 9:12:51.486 pm UUID: ceb4e4d0-4031-429d-9001-dd4dc44258ac Ancestors: Kernel-fbs.697, Kernel-nice.694 Remerge Kernel-nice.694: Protect floorLog: 2 for case of exceptional float values (because exponent does not) Change exponent primitive fallback code to avoid a recursion with floorLog2: Note that I created a separate selector #exponentFromBitPattern for handling fallback, because it's easier to test. =============== Diff against Kernel-fbs.697 =============== Item was changed: ----- Method: Float>>exponent (in category 'truncation and round off') ----- exponent "Primitive. Consider the receiver to be represented as a power of two multiplied by a mantissa (between one and two). Answer with the SmallInteger to whose power two is raised. Optional. See Object documentation whatIsAPrimitive." - | positive | <primitive: 53> + ^self exponentFromBitPattern! - self >= 1.0 ifTrue: [^self floorLog: 2]. - self > 0.0 - ifTrue: - [positive := (1.0 / self) exponent. - self = (1.0 / (1.0 timesTwoPower: positive)) - ifTrue: [^positive negated] - ifFalse: [^positive negated - 1]]. - self = 0.0 ifTrue: [^-1]. - ^self negated exponent! Item was added: + ----- Method: Float>>exponentFromBitPattern (in category 'truncation and round off') ----- + exponentFromBitPattern + "Extract the exponent from the bit pattern. + This is used only when primitive fails" + + | exponent word1 | + self isFinite ifFalse: [^self error: 'cannot take the exponent of non finite Float']. + self = 0.0 ifTrue: [^-1]. + word1 := self basicAt: 1. + exponent := (word1 bitShift: -20) bitAnd: 16r7FF. + ^exponent = 0 + ifTrue: + [| high | + high := (word1 bitAnd: 16rFFFFF) highBit. + high := high = 0 + ifTrue: [(self basicAt: 2) highBit] + ifFalse: [high + 32]. + self class emin - self class precision + high] + ifFalse: + [exponent + self class emin - 1]! Item was changed: ----- Method: Float>>floorLog: (in category 'mathematical functions') ----- floorLog: radix "Answer the floor of the log base radix of the receiver. The result may be off by one due to rounding errors, except in base 2." + (radix = 2 and: [self > 0.0 and: [self isFinite]]) ifTrue: [^self exponent]. - (radix = 2 and: [self > 0.0]) ifTrue: [^self exponent]. ^ (self log: radix) floor !

1 0

The Trunk: ShoutCore-fbs.35.mcz
by commits＠source.squeak.org 11 Jun '12

11 Jun '12

Frank Shearar uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-fbs.35.mcz ==================== Summary ==================== Name: ShoutCore-fbs.35 Author: fbs Time: 11 June 2012, 9:28:28.141 am UUID: b78331bb-dbe7-48bc-ab35-b2aacf11d0c4 Ancestors: ShoutCore-ul.34 An SHTextStyler shouldn't double initialise itself. =============== Diff against ShoutCore-ul.34 =============== Item was removed: - ----- Method: SHTextStyler class>>new (in category 'as yet unclassified') ----- - new - ^super new - initialize; - yourself!

1 0

The Trunk: Tools-fbs.413.mcz
by commits＠source.squeak.org 11 Jun '12

11 Jun '12

Frank Shearar uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.413.mcz ==================== Summary ==================== Name: Tools-fbs.413 Author: fbs Time: 11 June 2012, 8:45:35.501 pm UUID: 04131505-191d-4f46-ba9e-64195d2ed007 Ancestors: Tools-eem.412 #showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods). =============== Diff against Tools-eem.412 =============== Item was changed: ----- Method: CodeHolder>>selectedMessage (in category 'message list') ----- selectedMessage "Answer a copy of the source code for the selected message. This generic version is probably actually never reached, since every subclass probably reimplements and does not send to super. In time, ideally, most, or all, reimplementors would vanish and all would defer instead to a universal version right here. Everything in good time." | class selector method | contents ifNotNil: [^ contents copy]. self showingDecompile ifTrue:[^ self decompiledSourceIntoContents]. class := self selectedClassOrMetaClass. (class isNil or: [(selector := self selectedMessageName) isNil]) ifTrue: [^ '']. method := class compiledMethodAt: selector ifAbsent: [^ '']. "method deleted while in another project" currentCompiledMethod := method. + ^ contents := (self showingDocumentation - ^ contents := (self showComment ifFalse: [self sourceStringPrettifiedAndDiffed] ifTrue: [ self commentContents]) copy asText makeSelectorBoldIn: class! Item was removed: - ----- Method: CodeHolder>>showComment (in category 'what to show') ----- - showComment - "Answer whether the receiver should show documentation rather than, say, source code" - - ^ self contentsSymbol == #documentation - !

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
16
Older →

Jump to page: