Squeak-dev October 2013

squeak-dev@lists.squeakfoundation.org

35 participants
262 discussions

How to reserve a small spacing for displaying the text cursor ?
by Nicolas Cellier 03 Oct '13

03 Oct '13

Though leftMargin is nil and indentation are apparently set to zero, the TextMorph is always displayed with a small spacing from the left border and right border. This was quite long to find, but I now know: PluggableTextMorph>>resizeScroller "Also needs to resize the text morph" super resizeScroller. textMorph ifNotNil: [textMorph extent: (self innerBounds width-6)@self height]. Unfortunately, this space is not available for displaying the cursor, because it does not belong to the TextMorph... The cursor is always displayed to the right of CharacterBlock. So when at the left of the line it is inside TextMorph bounds and visible because away from the borders thanks to above 3 pixels guard. At the right of the line, it is generally visible, unless your last character unluckily fits exactly to the right bound. But if you rightFlush/justify, the characters are then perfectly aligned, and the cursor to the right of a line becomes invisible. It would not be unreasonnable to add some small indents to the style rather than letting the 0, but I feel like the 6 pixels could be given back to the TextMorph with a settable property, so that the Cursor could be displayed.... What do you think?

4 3

possible Environments bug
by Chris Muller 03 Oct '13

03 Oct '13

Given class hierarchy: Object Fred I wanted a new class-hierarchy with Wilma between Object and Fred. Object Wilma Fred But I knew most of Fred's methods would remain up in Wilma, only 2 or 3 would go to Fred. So the way I changed the class hierarchy was: 1) Rename Fred to Wilma. 2) Make new subclass of Wilma, named Fred. 3) Move 2 or 3 methods to Fred. After adding Fred back I now find that all references to Fred class in existing methods now actually point to the Wilma class. What actually happened is the variable binding in Smalltalk for #Fred had value -> of the Wilma class. So I guess the rename updated all references in existing methods to Wilma (but shouldn't they have been Undeclared?). Tricky to fix, too, since its a read-only binding plus you can't simply reference Fred anymore at all. I had to: [ (Smalltalk association at: #Fred) value: (Smalltalk allClassesAndTraits detect: [ : e | e name = #Fred) ] on: AttemptToWriteReadOnlyGlobal do: [ : noti | noti resume: true ]

2 2

Logging, Notifications and DynamicVariables (was: Re: [squeak-dev] The Trunk: Collections-cmm.538.mcz)
by Chris Muller 03 Oct '13

03 Oct '13

On Tue, Oct 1, 2013 at 10:22 PM, Levente Uzonyi <leves(a)elte.hu> wrote: > On Tue, 1 Oct 2013, Chris Muller wrote: > >> In the context of Smalltalk-80, I can understand logging straight to >> Transcript and using Transcript-specific functions (e.g., endEntry). >> Today, I consider referencing Transcript directly to be bad-form, >> simply because it tightly binds code to a particular UI. >> >> I prefer to signal Notifications to let the what-is-logged remain >> independent of the where-its-logged. > > > Notifications kill performance. Here's a small comparison of using no > logging at all, using Notifications for logging, and using a > ProcessLocalVariable for logging: This is very interesting, thanks a lot for the code examples. I did not know about ProcessSpecificVariable; it reminds me of the DynamicBindings external package. Although these code examples appear to not be using DynamicVariable quite correctly (i.e., DynamicVariable class>>#value:during: does not accept an argument to its block); I understand the concept you're presenting -- that a Dictionary lookup is faster than a stack-walking Notification. It's always good to remember the costs of using Notifications. I do think to generically say, "they kill performance" is a little misleading, though, since no one is going to log inside of a tight-loop. If they did, they're gonna have bloated logs and performance issues anyway. I think logging should be used sparingly, focusing on high-value messages; such as once at the start of long-running process, or the details of an exceptional circumstance. Used that way, performance is not affected. Performance being equal leaves us to consider the aesthetic quality of each approach. I want logging code to have as little (visual) impact on reading a method as possible. Here I think Notifications are better because they avoid the ifNotNil: conditional construct. Additionally, with the built-in hierarchical structure of Notifications, package-local logging is easily accomplished. Attempting this with ProcessLocalVariable approach might require more "lattice" in the signaling code, such as: MagmaLinkChange signal: 'Link changed' vs. ProcessLocalVariable ifNotNil: [ : logger | logger log: 'Link changed' atLevel: MagmaLinkChange ] And, actually, this example (MagmaLinkChange) not only logs but carries additional state on which the system must act. Having a single global handle all logging would not be able to handle some of these one-off cases. Like everywhere in engineering, I guess the optimal balance of trade-offs must be assessed for every situation. --- snipped the code examples --- >>> always "Transcript" or "self". Replacing #endEntry with #flush won't hurt >>> in >>> most cases. >> >> >> "Most" cases, or all? I was intending to change all of MY sends of >> endEntry to flush (if any), is there a caveat? >> > > Yes. Replacing #endEntry with #flush in Transcript >> #flush would lead to > infinite recursion. In some methods the receiver of #endEntry is a > Transcripter, which doesn't have its own implementation of #flush. Without > that it would break. Ha, ok! Funny man! :)

2 1

Daily Commit Log
by commits＠source.squeak.org 03 Oct '13

03 Oct '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-October/006473.ht… Name: Morphic-nice.694 Ancestors: Morphic-nice.693 multiComposeLinesFrom:to:delta:into:priorLines:atY: is no more used, farewell... ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006474.ht… Name: Graphics-nice.243 Ancestors: Graphics-nice.242 Fix a composition glitch when the last character of a text is a space that crosses the right margin boundary. In such case, a virtual empty line must be added to the composition in order to correctly materialize text selection and cursor position, and so as to continue typing on next line. The case when last character is a carriage return is in all point similar. Indeed, a space that crossedX is visually turned into a new line. TextComposer previously tried to reverse engineer scanner's work to recognize the CR case, which is a smell. This change unifies handling for the two cases by rather asking to the scanner doesTheLineBreaksAfterLastChar? Remove fixupLastLineIfCR which is tainted with half case only. Remove the workaround in CharacterBlockScanner that did not work around anything. Fix the breaking at non space for eastern asia: 1) registerBreakableIndex records that the line can wrap before the current character, and spaceIndex was pointing at this character that will potentially wrap on next line. 2) It is still possible to apply Justified alignment based on space adjustment if some spaces are used in the text, so correctly set the line spaceCount and paddingWidth. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006475.ht… Name: ST80-nice.152 Ancestors: ST80-nice.151 Restore the CharacterBlockScanner hack required for MVC in a specialized CharacterBlockScannerForMVC class. Methods used exclusively by Paragraph are moved there too. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006476.ht… Name: Graphics-nice.244 Ancestors: Graphics-nice.243 Move some CharacterBlockScanner methods used exclusively by MVC in ST80-Support. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006477.ht… Name: ST80-nice.153 Ancestors: ST80-nice.152 Move more MVC specific protocol of CharacterScanner from Graphics to ST80. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006478.ht… Name: Graphics-nice.245 Ancestors: Graphics-nice.244 Move more MVC specific protocol of CharacterScanner from Graphics to ST80. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006479.ht… Name: Graphics-nice.246 Ancestors: Graphics-nice.245 Fix a small glitch in rightFlush aligment: when you add so many spaces that a single word fits on the line, then it happens that one space sticks before the right margin preventing correct alignment of this word. =============================================

1 0

Re: [squeak-dev] The Trunk: Collections-cmm.538.mcz
by Levente Uzonyi 03 Oct '13

03 Oct '13

On Tue, 1 Oct 2013, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-cmm.538.mcz > > ==================== Summary ==================== > > Name: Collections-cmm.538 > Author: cmm > Time: 30 September 2013, 7:50:52.954 pm > UUID: f041f162-9c02-499f-866e-27d2e1a31b6b > Ancestors: Collections-tpr.537 > > - Logging output to a #endEntry is sometimes necessary. So let's still allow switching to another kind of WriteStream. I don't see the point of this change. #flush is part of the Stream protocol, so it's definitely not a compatibility method in WriteStream. It's better to use #flush instead of #endEntry, because all streams understand #flush, but only Transcript (and now WriteStream) understands #endEntry. Levente > > =============== Diff against Collections-tpr.537 =============== > > Item was added: > + ----- Method: WriteStream>>endEntry (in category 'compatibility') ----- > + endEntry > + "No-op for compatibility with TranscriptStream."! > > Item was changed: > + ----- Method: WriteStream>>flush (in category 'compatibility') ----- > - ----- Method: WriteStream>>flush (in category 'file open/close') ----- > flush! > > >

4 6

FOSDEM devroom
by Stephan Eggermont 03 Oct '13

03 Oct '13

The FOSDEM organisation has accepted a devroom proposal for all smalltalk and related projects. Please let me know what you'd like to see there, and what you'd like to show. It will be one day in the weekend of 1-2 february in Brussels https://fosdem.org/2014/ Cheers, Stephan

1 0

The Trunk: Graphics-nice.246.mcz
by commits＠source.squeak.org 02 Oct '13

02 Oct '13

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.246.mcz ==================== Summary ==================== Name: Graphics-nice.246 Author: nice Time: 2 October 2013, 11:33:50.036 pm UUID: 077a14d5-c038-44ed-b18f-567531f97a2e Ancestors: Graphics-nice.245 Fix a small glitch in rightFlush aligment: when you add so many spaces that a single word fits on the line, then it happens that one space sticks before the right margin preventing correct alignment of this word. =============== Diff against Graphics-nice.245 =============== Item was changed: ----- Method: CompositionScanner>>crossedX (in category 'stop conditions') ----- crossedX "There is a word that has fallen across the right edge of the composition rectangle. This signals the need for wrapping which is done to the last space that was encountered, as recorded by the space stop condition, or any other breakable character if the language permits so." pendingKernX := 0. lastBreakIsNotASpace ifTrue: ["In some languages break is possible before a non space." nextIndexAfterLineBreak := spaceIndex. line stop: spaceIndex - 1. lineHeight := lineHeightAtSpace. baseline := baselineAtSpace. line paddingWidth: rightMargin - spaceX. line internalSpaces: spaceCount. ^true]. spaceCount >= 1 ifTrue: ["The common case. First back off to the space at which we wrap." line stop: spaceIndex. nextIndexAfterLineBreak := spaceIndex + 1. lineHeight := lineHeightAtSpace. baseline := baselineAtSpace. spaceCount := spaceCount - 1. spaceIndex := spaceIndex - 1. "Check to see if any spaces preceding the one at which we wrap. Double space after punctuation, most likely." + [(spaceCount >= 1 and: [(text at: spaceIndex) = Space])] - [(spaceCount > 1 and: [(text at: spaceIndex) = Space])] whileTrue: [spaceCount := spaceCount - 1. "Account for backing over a run which might change width of space." font := text fontAt: spaceIndex withStyle: textStyle. spaceIndex := spaceIndex - 1. spaceX := spaceX - (font widthOf: Space)]. line paddingWidth: rightMargin - spaceX. line internalSpaces: spaceCount] ifFalse: ["Neither internal nor trailing spaces -- almost never happens." lastIndex := lastIndex - 1. [destX <= rightMargin or: [ lastIndex = 0 ]] whileFalse: [destX := destX - (font widthOf: (text at: lastIndex)). lastIndex := lastIndex - 1]. nextIndexAfterLineBreak := lastIndex + 1. spaceX := destX. line paddingWidth: rightMargin - destX. line stop: (lastIndex max: line first)]. ^true!

1 0

Lots of redundant #perform:orSendTo: 's
by Chris Muller 02 Oct '13

02 Oct '13

It appears that many subclasses of Model's implementation want to override with their own, exactly equivalent of the Object implementation. Open Inheritance browser on Model>>#perform:orSendTo: and see. Seems like we could get rid of Models and the dups. Does anyone know why Model's is like that?

2 1

The Trunk: Graphics-nice.245.mcz
by commits＠source.squeak.org 02 Oct '13

02 Oct '13

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.245.mcz ==================== Summary ==================== Name: Graphics-nice.245 Author: nice Time: 2 October 2013, 10:34:50.346 pm UUID: 6074e17f-0000-4aea-9005-5ee23179da88 Ancestors: Graphics-nice.244 Move more MVC specific protocol of CharacterScanner from Graphics to ST80. =============== Diff against Graphics-nice.244 =============== Item was removed: - ----- Method: CharacterBlockScanner>>characterPointSetX: (in category 'private') ----- - characterPointSetX: xVal - characterPoint := xVal @ characterPoint y! Item was removed: - ----- Method: CharacterScanner>>initializeFromParagraph:clippedBy: (in category 'private') ----- - initializeFromParagraph: aParagraph clippedBy: clippingRectangle - - text := aParagraph text. - textStyle := aParagraph textStyle. - ! Item was removed: - ----- Method: CompositionScanner>>composeLine:fromCharacterIndex:inParagraph: (in category 'scanning') ----- - composeLine: lineIndex fromCharacterIndex: startIndex inParagraph: aParagraph - "Answer an instance of TextLineInterval that represents the next line in the paragraph." - | runLength stopCondition | - destX := spaceX := leftMargin := aParagraph leftMarginForCompositionForLine: lineIndex. - destY := 0. - rightMargin := aParagraph rightMarginForComposition. - leftMargin >= rightMargin ifTrue: [self error: 'No room between margins to compose']. - lastIndex := startIndex. "scanning sets last index" - lineHeight := textStyle lineGrid. "may be increased by setFont:..." - baseline := textStyle baseline. - self setStopConditions. "also sets font" - self handleIndentation. - runLength := text runLengthFor: startIndex. - runStopIndex := (lastIndex := startIndex) + (runLength - 1). - line := TextLineInterval - start: lastIndex - stop: 0 - internalSpaces: 0 - paddingWidth: 0. - nextIndexAfterLineBreak := spaceCount := 0. - lastBreakIsNotASpace := false. - - [stopCondition := self scanCharactersFrom: lastIndex to: runStopIndex - in: text string rightX: rightMargin stopConditions: stopConditions - kern: kern. - "See setStopConditions for stopping conditions for composing." - self perform: stopCondition] whileFalse. - - ^line - lineHeight: lineHeight + textStyle leading - baseline: baseline + textStyle leading! Item was removed: - ----- Method: CompositionScanner>>forParagraph: (in category 'intialize-release') ----- - forParagraph: aParagraph - "Initialize the receiver for scanning the given paragraph." - - self - initializeFromParagraph: aParagraph - clippedBy: aParagraph clippingRectangle. - ! Item was removed: - ----- Method: DisplayScanner>>displayLines:in:clippedBy: (in category 'MVC-compatibility') ----- - displayLines: linesInterval in: aParagraph clippedBy: visibleRectangle - "The central display routine. The call on the primitive - (scanCharactersFrom:to:in:rightX:) will be interrupted according to an - array of stop conditions passed to the scanner at which time the code to - handle the stop condition is run and the call on the primitive continued - until a stop condition returns true (which means the line has - terminated)." - | leftInRun | - "leftInRun is the # of characters left to scan in the current run; - when 0, it is time to call 'self setStopConditions'" - morphicOffset := 0@0. - leftInRun := 0. - self initializeFromParagraph: aParagraph clippedBy: visibleRectangle. - ignoreColorChanges := false. - foregroundColor := paragraphColor := aParagraph foregroundColor. - backgroundColor := aParagraph backgroundColor. - aParagraph backgroundColor isTransparent - ifTrue: [fillBlt := nil] - ifFalse: [fillBlt := bitBlt copy. "Blt to fill spaces, tabs, margins" - fillBlt sourceForm: nil; sourceOrigin: 0@0. - fillBlt fillColor: aParagraph backgroundColor]. - rightMargin := aParagraph rightMarginForDisplay. - lineY := aParagraph topAtLineIndex: linesInterval first. - bitBlt destForm deferUpdatesIn: visibleRectangle while: [ - linesInterval do: - [:lineIndex | - | string startIndex lastPos runLength stopCondition baselineY | - line := aParagraph lines at: lineIndex. - lastIndex := line first. - leftInRun <= 0 - ifTrue: [self setStopConditions. "also sets the font, alignment and emphasisCode" - leftInRun := text runLengthFor: line first]. - leftMargin := aParagraph leftMarginForDisplayForLine: lineIndex alignment: alignment. - destX := runX := leftMargin. - lineHeight := line lineHeight. - fillBlt == nil ifFalse: - [fillBlt destX: visibleRectangle left destY: lineY - width: visibleRectangle width height: lineHeight; copyBits]. - baselineY := lineY + line baseline. - destY := baselineY - font ascent. "Should have happened in setFont" - runLength := leftInRun. - runStopIndex := lastIndex + (runLength - 1) min: line last. - leftInRun := leftInRun - (runStopIndex - lastIndex + 1). - spaceCount := 0. - string := text string. - self handleIndentation. - [ - startIndex := lastIndex. - lastPos := destX@destY. - stopCondition := self scanCharactersFrom: lastIndex to: runStopIndex - in: string rightX: rightMargin stopConditions: stopConditions - kern: kern. - lastIndex >= startIndex ifTrue:[ - font displayString: string on: bitBlt - from: startIndex to: lastIndex at: lastPos kern: kern]. - "see setStopConditions for stopping conditions for displaying." - self perform: stopCondition - ] whileFalse. - fillBlt == nil ifFalse: - [fillBlt destX: destX destY: lineY width: visibleRectangle right-destX height: lineHeight; copyBits]. - lineY := lineY + lineHeight]]! Item was removed: - ----- Method: DisplayScanner>>initializeFromParagraph:clippedBy: (in category 'MVC-compatibility') ----- - initializeFromParagraph: aParagraph clippedBy: clippingRectangle - - super initializeFromParagraph: aParagraph clippedBy: clippingRectangle. - bitBlt := BitBlt asGrafPort toForm: aParagraph destinationForm. - bitBlt sourceX: 0; width: 0. "Init BitBlt so that the first call to a primitive will not fail" - bitBlt combinationRule: - ((Display depth = 1) - ifTrue: - [aParagraph rule] - ifFalse: - [Form paint]). - bitBlt colorMap: - (Bitmap with: 0 "Assumes 1-bit deep fonts" - with: (bitBlt destForm pixelValueFor: aParagraph foregroundColor)). - bitBlt clipRect: clippingRectangle!

1 0

The Trunk: ST80-nice.153.mcz
by commits＠source.squeak.org 02 Oct '13

02 Oct '13

Nicolas Cellier uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-nice.153.mcz ==================== Summary ==================== Name: ST80-nice.153 Author: nice Time: 2 October 2013, 10:33:05.329 pm UUID: 209184da-cf25-40e7-9a80-cb27e22aa125 Ancestors: ST80-nice.152 Move more MVC specific protocol of CharacterScanner from Graphics to ST80. =============== Diff against ST80-nice.152 =============== Item was added: + ----- Method: CharacterBlockScannerForMVC>>characterPointSetX: (in category 'private') ----- + characterPointSetX: xVal + characterPoint := xVal @ characterPoint y! Item was added: + ----- Method: CharacterScanner>>initializeFromParagraph:clippedBy: (in category '*ST80-Support') ----- + initializeFromParagraph: aParagraph clippedBy: clippingRectangle + + text := aParagraph text. + textStyle := aParagraph textStyle. + ! Item was added: + ----- Method: CompositionScanner>>composeLine:fromCharacterIndex:inParagraph: (in category '*ST80-Support') ----- + composeLine: lineIndex fromCharacterIndex: startIndex inParagraph: aParagraph + "Answer an instance of TextLineInterval that represents the next line in the paragraph." + | runLength stopCondition | + destX := spaceX := leftMargin := aParagraph leftMarginForCompositionForLine: lineIndex. + destY := 0. + rightMargin := aParagraph rightMarginForComposition. + leftMargin >= rightMargin ifTrue: [self error: 'No room between margins to compose']. + lastIndex := startIndex. "scanning sets last index" + lineHeight := textStyle lineGrid. "may be increased by setFont:..." + baseline := textStyle baseline. + self setStopConditions. "also sets font" + self handleIndentation. + runLength := text runLengthFor: startIndex. + runStopIndex := (lastIndex := startIndex) + (runLength - 1). + line := TextLineInterval + start: lastIndex + stop: 0 + internalSpaces: 0 + paddingWidth: 0. + nextIndexAfterLineBreak := spaceCount := 0. + lastBreakIsNotASpace := false. + + [stopCondition := self scanCharactersFrom: lastIndex to: runStopIndex + in: text string rightX: rightMargin stopConditions: stopConditions + kern: kern. + "See setStopConditions for stopping conditions for composing." + self perform: stopCondition] whileFalse. + + ^line + lineHeight: lineHeight + textStyle leading + baseline: baseline + textStyle leading! Item was added: + ----- Method: CompositionScanner>>forParagraph: (in category '*ST80-Support') ----- + forParagraph: aParagraph + "Initialize the receiver for scanning the given paragraph." + + self + initializeFromParagraph: aParagraph + clippedBy: aParagraph clippingRectangle. + ! Item was added: + ----- Method: DisplayScanner>>displayLines:in:clippedBy: (in category '*ST80-Support') ----- + displayLines: linesInterval in: aParagraph clippedBy: visibleRectangle + "The central display routine. The call on the primitive + (scanCharactersFrom:to:in:rightX:) will be interrupted according to an + array of stop conditions passed to the scanner at which time the code to + handle the stop condition is run and the call on the primitive continued + until a stop condition returns true (which means the line has + terminated)." + | leftInRun | + "leftInRun is the # of characters left to scan in the current run; + when 0, it is time to call 'self setStopConditions'" + morphicOffset := 0@0. + leftInRun := 0. + self initializeFromParagraph: aParagraph clippedBy: visibleRectangle. + ignoreColorChanges := false. + foregroundColor := paragraphColor := aParagraph foregroundColor. + backgroundColor := aParagraph backgroundColor. + aParagraph backgroundColor isTransparent + ifTrue: [fillBlt := nil] + ifFalse: [fillBlt := bitBlt copy. "Blt to fill spaces, tabs, margins" + fillBlt sourceForm: nil; sourceOrigin: 0@0. + fillBlt fillColor: aParagraph backgroundColor]. + rightMargin := aParagraph rightMarginForDisplay. + lineY := aParagraph topAtLineIndex: linesInterval first. + bitBlt destForm deferUpdatesIn: visibleRectangle while: [ + linesInterval do: + [:lineIndex | + | string startIndex lastPos runLength stopCondition baselineY | + line := aParagraph lines at: lineIndex. + lastIndex := line first. + leftInRun <= 0 + ifTrue: [self setStopConditions. "also sets the font, alignment and emphasisCode" + leftInRun := text runLengthFor: line first]. + leftMargin := aParagraph leftMarginForDisplayForLine: lineIndex alignment: alignment. + destX := runX := leftMargin. + lineHeight := line lineHeight. + fillBlt == nil ifFalse: + [fillBlt destX: visibleRectangle left destY: lineY + width: visibleRectangle width height: lineHeight; copyBits]. + baselineY := lineY + line baseline. + destY := baselineY - font ascent. "Should have happened in setFont" + runLength := leftInRun. + runStopIndex := lastIndex + (runLength - 1) min: line last. + leftInRun := leftInRun - (runStopIndex - lastIndex + 1). + spaceCount := 0. + string := text string. + self handleIndentation. + [ + startIndex := lastIndex. + lastPos := destX@destY. + stopCondition := self scanCharactersFrom: lastIndex to: runStopIndex + in: string rightX: rightMargin stopConditions: stopConditions + kern: kern. + lastIndex >= startIndex ifTrue:[ + font displayString: string on: bitBlt + from: startIndex to: lastIndex at: lastPos kern: kern]. + "see setStopConditions for stopping conditions for displaying." + self perform: stopCondition + ] whileFalse. + fillBlt == nil ifFalse: + [fillBlt destX: destX destY: lineY width: visibleRectangle right-destX height: lineHeight; copyBits]. + lineY := lineY + lineHeight]]! Item was added: + ----- Method: DisplayScanner>>initializeFromParagraph:clippedBy: (in category '*ST80-Support') ----- + initializeFromParagraph: aParagraph clippedBy: clippingRectangle + + super initializeFromParagraph: aParagraph clippedBy: clippingRectangle. + bitBlt := BitBlt asGrafPort toForm: aParagraph destinationForm. + bitBlt sourceX: 0; width: 0. "Init BitBlt so that the first call to a primitive will not fail" + bitBlt combinationRule: + ((Display depth = 1) + ifTrue: + [aParagraph rule] + ifFalse: + [Form paint]). + bitBlt colorMap: + (Bitmap with: 0 "Assumes 1-bit deep fonts" + with: (bitBlt destForm pixelValueFor: aParagraph foregroundColor)). + bitBlt clipRect: clippingRectangle!

1 0

Jump to page: