Squeak-dev October 2014

squeak-dev@lists.squeakfoundation.org

46 participants
184 discussions

Daily Commit Log
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-October/007306.ht… Name: ToolBuilder-Kernel-eem.63 Ancestors: ToolBuilder-Kernel-mt.62 The method that opens a debugger does need to answer the window created, as its comment says. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007307.ht… Name: Tools-eem.529 Ancestors: Tools-cmm.528 Have Debugger>>openFullNoSuspendLabel: et al answer the windows they create. Hence also change Debugger class>>openInterrupt:onProcess: to answer the debugger, not the window. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007308.ht… Name: Compiler-eem.289 Ancestors: Compiler-eem.288 Fix doits in the codePane of a debugger opened from another debugger. e.g. before this fix 1. debug 3+4. 2. in code pane of debugger #1 debug 4+5 3. in code pane of debugger #2 debug 5+6, boom. The bug was that when the encoder creates temp names for temp vars in the debugged context, which it does by creating messages to DoItIn:'s argument 'ThisContext', if this is a level 3 debug, then the original expression would have a temp var called 'ThisContext' already and that would overwrite the 'ThisContext' argument for this level with a message send, and boom. The fix is merely to filter-out these temps and hence never overwrite DoItIn:'s 'ThisContext' argument in the scope table. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007309.ht… Name: Morphic-eem.746 Ancestors: Morphic-ul.745 Fix debugging of optimized expressions. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007310.ht… Name: ST80Tools-eem.2 Ancestors: ST80Tools-fbs.1 Fix debugging of optimized expressions. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007311.ht… Name: Morphic-eem.747 Ancestors: Morphic-eem.746 Fix the broken fix in Morphic-eem.746 for debugging optimized methods. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007312.ht… Name: Kernel-eem.877 Ancestors: Kernel-eem.876 Fix doPrimitive:method:receiver:args: for primitive 188 and quick methods (Object>>withArgs:executeMethod:) and support primitive 189 (Object>>with:*executeMethod:) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007313.ht… Name: Kernel-eem.878 Ancestors: Kernel-eem.876 Less haste, more speed. Fix doPrimitive:method:receiver:args: for primitive 188 and quick methods (Object>>withArgs:executeMethod:) and support primitive 189 (Object>>with:*executeMethod:) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007314.ht… Name: Morphic-eem.748 Ancestors: Morphic-ul.745 Fix debugging of optimized expressions. Depends also on Kernel-eem.878. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-October/007315.ht… Name: ST80Tools-eem.3 Ancestors: ST80Tools-fbs.1 Fix debugging of optimized expressions. Depends also on Kernel-eem.878. =============================================

1 0

The Trunk: ST80Tools-eem.3.mcz
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Eliot Miranda uploaded a new version of ST80Tools to project The Trunk: http://source.squeak.org/trunk/ST80Tools-eem.3.mcz ==================== Summary ==================== Name: ST80Tools-eem.3 Author: eem Time: 6 October 2014, 4:45:25.26 pm UUID: 025a1ce4-d05a-4afb-b5c8-fc0df26ef4e0 Ancestors: ST80Tools-fbs.1 Fix debugging of optimized expressions. Depends also on Kernel-eem.878. =============== Diff against ST80Tools-fbs.1 =============== Item was changed: ----- Method: ParagraphEditor>>debug:receiver:in: (in category '*ST80Tools') ----- debug: aCompiledMethod receiver: anObject in: evalContext + | guineaPig debugger debuggerWindow context | + guineaPig := + [aCompiledMethod - | guineaPig debugger context | - guineaPig := [ - aCompiledMethod valueWithReceiver: anObject + arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]). + guineaPig := nil "spot the return from aCompiledMethod"] newProcess. - arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]) ] newProcess. context := guineaPig suspendedContext. debugger := Debugger new process: guineaPig + controller: ((Smalltalk isMorphic not and: [ScheduledControllers inActiveControllerProcess]) ifTrue: + [ScheduledControllers activeController]) - controller: ((Smalltalk isMorphic not and: [ScheduledControllers inActiveControllerProcess]) - ifTrue: [ScheduledControllers activeController] - ifFalse: [nil]) context: context. + debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. + "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') + it will return immediately back to the block that is sent newProcess above. Guard + against that with the check for home being thisContext." - debugger openFullNoSuspendLabel: 'Debug it'. [debugger interruptedContext method == aCompiledMethod] + whileFalse: + [(guineaPig isNil + and: [debugger interruptedContext home == thisContext]) ifTrue: + [debuggerWindow controller closeAndUnschedule. + UIManager default inform: 'Nothing to debug; expression is optimized'. + ^self]. + debugger send]! - whileFalse: [debugger send]!

1 0

The Trunk: Morphic-eem.748.mcz
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.748.mcz ==================== Summary ==================== Name: Morphic-eem.748 Author: eem Time: 6 October 2014, 4:37:20.596 pm UUID: d98f5dd3-77d5-4f51-94ed-92378abe641c Ancestors: Morphic-ul.745 Fix debugging of optimized expressions. Depends also on Kernel-eem.878. =============== Diff against Morphic-ul.745 =============== Item was changed: ----- Method: TextEditor>>debug:receiver:in: (in category 'do-its') ----- debug: aCompiledMethod receiver: anObject in: evalContext + | guineaPig debugger debuggerWindow context | + guineaPig := + [aCompiledMethod - | guineaPig debugger context | - guineaPig := [ - aCompiledMethod valueWithReceiver: anObject + arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]). + guineaPig := nil "spot the return from aCompiledMethod"] newProcess. - arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]) ] newProcess. context := guineaPig suspendedContext. debugger := Debugger new process: guineaPig controller: nil context: context. + debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. + "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') + it will return immediately back to the block that is sent newProcess above. Guard + against that with the check for home being thisContext." + [debugger interruptedContext method == aCompiledMethod] + whileFalse: + [(guineaPig isNil + and: [debugger interruptedContext home == thisContext]) ifTrue: + [debuggerWindow delete. + UIManager default inform: 'Nothing to debug; expression is optimized'. + ^self]. + debugger send]! - debugger openFullNoSuspendLabel: 'Debug it'. - [ debugger interruptedContext method == aCompiledMethod ] - whileFalse: [ debugger send ]!

1 0

The Trunk: Kernel-eem.878.mcz
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.878.mcz ==================== Summary ==================== Name: Kernel-eem.878 Author: eem Time: 6 October 2014, 4:23:20.811 pm UUID: e4b864d7-c2bc-4a8c-b0fa-e867a1508410 Ancestors: Kernel-eem.876 Less haste, more speed. Fix doPrimitive:method:receiver:args: for primitive 188 and quick methods (Object>>withArgs:executeMethod:) and support primitive 189 (Object>>with:*executeMethod:) =============== Diff against Kernel-eem.876 =============== Item was changed: ----- Method: ContextPart>>doPrimitive:method:receiver:args: (in category 'private') ----- doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and arguments are given as arguments to this message. If successful, push result and return resuming context, else ^ PrimitiveFailToken. Any primitive which provokes execution needs to be intercepted and simulated to avoid execution running away." | value | "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. hence use primtiive 19 with care :-)" "SystemNavigation new browseAllSelect: [:m| m primitive = 19]" primitiveIndex = 19 ifTrue: [ToolSet debugContext: self label:'Code simulation error' contents: nil]. "ContextPart>>blockCopy:; simulated to get startpc right" (primitiveIndex = 80 and: [(self objectClass: receiver) includesBehavior: ContextPart]) ifTrue: [^self push: ((BlockContext newForMethod: receiver method) home: receiver home startpc: pc + 2 nargs: (arguments at: 1))]. (primitiveIndex = 81 and: [(self objectClass: receiver) == BlockContext]) "BlockContext>>value[:value:...]" ifTrue: [^receiver pushArgs: arguments from: self]. (primitiveIndex = 82 and: [(self objectClass: receiver) == BlockContext]) "BlockContext>>valueWithArguments:" ifTrue: [^receiver pushArgs: arguments first from: self]. primitiveIndex = 83 "afr 9/11/1998 19:50" "Object>>perform:[with:...]" ifTrue: [^self send: arguments first to: receiver with: arguments allButFirst super: false]. primitiveIndex = 84 "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:" ifTrue: [^self send: arguments first to: receiver with: (arguments at: 2) startClass: nil]. primitiveIndex = 100 "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:" ifTrue: [^self send: arguments first to: receiver with: (arguments at: 2) startClass: (arguments at: 3)]. "Mutex>>primitiveEnterCriticalSection Mutex>>primitiveTestAndSetOwnershipOfCriticalSection" (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue: [| active effective | active := Processor activeProcess. effective := active effectiveProcess. "active == effective" value := primitiveIndex = 186 ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective] ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective]. ^((self objectClass: value) == Array and: [value size = 2 and: [value first == PrimitiveFailToken]]) ifTrue: [value] ifFalse: [self push: value]]. + ((primitiveIndex = 188 or: [primitiveIndex = 189]) "eem 10/6/2014 16:14 Object>>with:*executeMethod:" + and: [arguments last isQuick not]) ifTrue: "eem 5/27/2008 11:10 Object>>withArgs:executeMethod:" - primitiveIndex = 188 ifTrue: "eem 5/27/2008 11:10 Object>>withArgs:executeMethod:" [^MethodContext sender: self receiver: receiver + method: arguments last + arguments: (primitiveIndex = 188 + ifTrue: [arguments at: 1] + ifFalse: [arguments allButLast])]. - method: (arguments at: 2) - arguments: (arguments at: 1)]. "Closure primitives" (primitiveIndex = 200 and: [self == receiver]) ifTrue: "ContextPart>>closureCopy:copiedValues:; simulated to get startpc right" [^self push: (BlockClosure outerContext: receiver startpc: pc + 2 numArgs: arguments first copiedValues: arguments last)]. ((primitiveIndex between: 201 and: 205) "BlockClosure>>value[:value:...]" or: [primitiveIndex between: 221 and: 222]) ifTrue: "BlockClosure>>valueNoContextSwitch[:]" [^receiver simulateValueWithArguments: arguments caller: self]. primitiveIndex = 206 ifTrue: "BlockClosure>>valueWithArguments:" [^receiver simulateValueWithArguments: arguments first caller: self]. primitiveIndex = 118 ifTrue: "tryPrimitive:withArgs:; avoid recursing in the VM" [(arguments size = 2 and: [arguments first isInteger and: [(self objectClass: arguments last) == Array]]) ifFalse: [^ContextPart primitiveFailTokenFor: nil]. ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last]. value := primitiveIndex = 120 "FFI method" ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments] ifFalse: [primitiveIndex = 117 "named primitives" ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments] ifFalse: [receiver tryPrimitive: primitiveIndex withArgs: arguments]]. ^((self objectClass: value) == Array and: [value size = 2 and: [value first == PrimitiveFailToken]]) ifTrue: [value] ifFalse: [self push: value]!

1 0

The Trunk: Kernel-eem.877.mcz
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.877.mcz ==================== Summary ==================== Name: Kernel-eem.877 Author: eem Time: 6 October 2014, 4:19:05.019 pm UUID: 0261bf17-d453-4738-924c-ed2bab916f63 Ancestors: Kernel-eem.876 Fix doPrimitive:method:receiver:args: for primitive 188 and quick methods (Object>>withArgs:executeMethod:) and support primitive 189 (Object>>with:*executeMethod:) =============== Diff against Kernel-eem.876 =============== Item was changed: ----- Method: ContextPart>>doPrimitive:method:receiver:args: (in category 'private') ----- doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and arguments are given as arguments to this message. If successful, push result and return resuming context, else ^ PrimitiveFailToken. Any primitive which provokes execution needs to be intercepted and simulated to avoid execution running away." | value | "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. hence use primtiive 19 with care :-)" "SystemNavigation new browseAllSelect: [:m| m primitive = 19]" primitiveIndex = 19 ifTrue: [ToolSet debugContext: self label:'Code simulation error' contents: nil]. "ContextPart>>blockCopy:; simulated to get startpc right" (primitiveIndex = 80 and: [(self objectClass: receiver) includesBehavior: ContextPart]) ifTrue: [^self push: ((BlockContext newForMethod: receiver method) home: receiver home startpc: pc + 2 nargs: (arguments at: 1))]. (primitiveIndex = 81 and: [(self objectClass: receiver) == BlockContext]) "BlockContext>>value[:value:...]" ifTrue: [^receiver pushArgs: arguments from: self]. (primitiveIndex = 82 and: [(self objectClass: receiver) == BlockContext]) "BlockContext>>valueWithArguments:" ifTrue: [^receiver pushArgs: arguments first from: self]. primitiveIndex = 83 "afr 9/11/1998 19:50" "Object>>perform:[with:...]" ifTrue: [^self send: arguments first to: receiver with: arguments allButFirst super: false]. primitiveIndex = 84 "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:" ifTrue: [^self send: arguments first to: receiver with: (arguments at: 2) startClass: nil]. primitiveIndex = 100 "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:" ifTrue: [^self send: arguments first to: receiver with: (arguments at: 2) startClass: (arguments at: 3)]. "Mutex>>primitiveEnterCriticalSection Mutex>>primitiveTestAndSetOwnershipOfCriticalSection" (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue: [| active effective | active := Processor activeProcess. effective := active effectiveProcess. "active == effective" value := primitiveIndex = 186 ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective] ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective]. ^((self objectClass: value) == Array and: [value size = 2 and: [value first == PrimitiveFailToken]]) ifTrue: [value] ifFalse: [self push: value]]. + ((primitiveIndex = 188 or: [primitiveIndex = 189]) "eem 10/6/2014 16:14 Object>>with:*executeMethod:" + and: [arguments last isQuick not]) ifTrue: "eem 5/27/2008 11:10 Object>>withArgs:executeMethod:" - primitiveIndex = 188 ifTrue: "eem 5/27/2008 11:10 Object>>withArgs:executeMethod:" [^MethodContext sender: self receiver: receiver + method: arguments last + arguments: (primitiveIndex = 189 + ifTrue: [arguments at: 1] + ifFalse: [arguments allButLast])]. - method: (arguments at: 2) - arguments: (arguments at: 1)]. "Closure primitives" (primitiveIndex = 200 and: [self == receiver]) ifTrue: "ContextPart>>closureCopy:copiedValues:; simulated to get startpc right" [^self push: (BlockClosure outerContext: receiver startpc: pc + 2 numArgs: arguments first copiedValues: arguments last)]. ((primitiveIndex between: 201 and: 205) "BlockClosure>>value[:value:...]" or: [primitiveIndex between: 221 and: 222]) ifTrue: "BlockClosure>>valueNoContextSwitch[:]" [^receiver simulateValueWithArguments: arguments caller: self]. primitiveIndex = 206 ifTrue: "BlockClosure>>valueWithArguments:" [^receiver simulateValueWithArguments: arguments first caller: self]. primitiveIndex = 118 ifTrue: "tryPrimitive:withArgs:; avoid recursing in the VM" [(arguments size = 2 and: [arguments first isInteger and: [(self objectClass: arguments last) == Array]]) ifFalse: [^ContextPart primitiveFailTokenFor: nil]. ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last]. value := primitiveIndex = 120 "FFI method" ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments] ifFalse: [primitiveIndex = 117 "named primitives" ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments] ifFalse: [receiver tryPrimitive: primitiveIndex withArgs: arguments]]. ^((self objectClass: value) == Array and: [value size = 2 and: [value first == PrimitiveFailToken]]) ifTrue: [value] ifFalse: [self push: value]!

1 0

The Trunk: Morphic-eem.747.mcz
by commits＠source.squeak.org 07 Oct '14

07 Oct '14

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.747.mcz ==================== Summary ==================== Name: Morphic-eem.747 Author: eem Time: 6 October 2014, 3:39:08.651 pm UUID: 6d5fda0b-2826-43c4-af1e-9f5c0cf7258e Ancestors: Morphic-eem.746 Fix the broken fix in Morphic-eem.746 for debugging optimized methods. =============== Diff against Morphic-eem.746 =============== Item was changed: ----- Method: TextEditor>>debug:receiver:in: (in category 'do-its') ----- debug: aCompiledMethod receiver: anObject in: evalContext | guineaPig debugger debuggerWindow context | + guineaPig := + [aCompiledMethod - guineaPig := [ - aCompiledMethod valueWithReceiver: anObject + arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]). + guineaPig := nil "spot the return from aCompiledMethod"] newProcess. - arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]) ] newProcess. context := guineaPig suspendedContext. debugger := Debugger new process: guineaPig controller: nil context: context. debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') it will return immediately back to the block that is sent newProcess above. Guard against that with the check for home being thisContext." [debugger interruptedContext method == aCompiledMethod] whileFalse: + [(guineaPig isNil + and: [debugger interruptedContext home == thisContext]) ifTrue: - [debugger interruptedContext home == thisContext ifTrue: [debuggerWindow delete. UIManager default inform: 'Nothing to debug; expression is optimized'. ^self]. debugger send]!

1 0

The Trunk: ST80Tools-eem.2.mcz
by commits＠source.squeak.org 06 Oct '14

06 Oct '14

Eliot Miranda uploaded a new version of ST80Tools to project The Trunk: http://source.squeak.org/trunk/ST80Tools-eem.2.mcz ==================== Summary ==================== Name: ST80Tools-eem.2 Author: eem Time: 6 October 2014, 1:11:46.54 pm UUID: 513b7a04-1c98-41a7-99a6-0852b3bb9a94 Ancestors: ST80Tools-fbs.1 Fix debugging of optimized expressions. =============== Diff against ST80Tools-fbs.1 =============== Item was changed: ----- Method: ParagraphEditor>>debug:receiver:in: (in category '*ST80Tools') ----- debug: aCompiledMethod receiver: anObject in: evalContext + | guineaPig debugger debuggerWindow context | - | guineaPig debugger context | guineaPig := [ aCompiledMethod valueWithReceiver: anObject arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]) ] newProcess. context := guineaPig suspendedContext. debugger := Debugger new process: guineaPig + controller: ((Smalltalk isMorphic not and: [ScheduledControllers inActiveControllerProcess]) ifTrue: + [ScheduledControllers activeController]) - controller: ((Smalltalk isMorphic not and: [ScheduledControllers inActiveControllerProcess]) - ifTrue: [ScheduledControllers activeController] - ifFalse: [nil]) context: context. + debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. + "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') + it will return immediately back to the block that is sent newProcess above. Guard + against that with the check for home being thisContext." - debugger openFullNoSuspendLabel: 'Debug it'. [debugger interruptedContext method == aCompiledMethod] + whileFalse: + [debugger interruptedContext home == thisContext ifTrue: + [debuggerWindow controller closeAndUnschedule. + UIManager default inform: 'Nothing to debug; expression is optimized'. + ^self]. + debugger send]! - whileFalse: [debugger send]!

1 0

The Trunk: Morphic-eem.746.mcz
by commits＠source.squeak.org 06 Oct '14

06 Oct '14

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.746.mcz ==================== Summary ==================== Name: Morphic-eem.746 Author: eem Time: 6 October 2014, 1:09:34.182 pm UUID: c9ae704e-6a58-40b8-a998-72392d0cff6e Ancestors: Morphic-ul.745 Fix debugging of optimized expressions. =============== Diff against Morphic-ul.745 =============== Item was changed: ----- Method: TextEditor>>debug:receiver:in: (in category 'do-its') ----- debug: aCompiledMethod receiver: anObject in: evalContext + | guineaPig debugger debuggerWindow context | - | guineaPig debugger context | guineaPig := [ aCompiledMethod valueWithReceiver: anObject arguments: (evalContext ifNil: [ #() ] ifNotNil: [ { evalContext } ]) ] newProcess. context := guineaPig suspendedContext. debugger := Debugger new process: guineaPig controller: nil context: context. + debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. + "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') + it will return immediately back to the block that is sent newProcess above. Guard + against that with the check for home being thisContext." + [debugger interruptedContext method == aCompiledMethod] + whileFalse: + [debugger interruptedContext home == thisContext ifTrue: + [debuggerWindow delete. + UIManager default inform: 'Nothing to debug; expression is optimized'. + ^self]. + debugger send]! - debugger openFullNoSuspendLabel: 'Debug it'. - [ debugger interruptedContext method == aCompiledMethod ] - whileFalse: [ debugger send ]!

1 0

The Trunk: Compiler-eem.289.mcz
by commits＠source.squeak.org 06 Oct '14

06 Oct '14

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.289.mcz ==================== Summary ==================== Name: Compiler-eem.289 Author: eem Time: 6 October 2014, 11:58:50.62 am UUID: 7d67c48c-4a2f-4445-83e8-1f8f931801e3 Ancestors: Compiler-eem.288 Fix doits in the codePane of a debugger opened from another debugger. e.g. before this fix 1. debug 3+4. 2. in code pane of debugger #1 debug 4+5 3. in code pane of debugger #2 debug 5+6, boom. The bug was that when the encoder creates temp names for temp vars in the debugged context, which it does by creating messages to DoItIn:'s argument 'ThisContext', if this is a level 3 debug, then the original expression would have a temp var called 'ThisContext' already and that would overwrite the 'ThisContext' argument for this level with a message send, and boom. The fix is merely to filter-out these temps and hence never overwrite DoItIn:'s 'ThisContext' argument in the scope table. =============== Diff against Compiler-eem.288 =============== Item was changed: ----- Method: Encoder>>init:notifying: (in category 'initialize-release') ----- init: aCue notifying: anObject "The use of the variable requestor is a bit confusing here. This is *not* the original requestor, which is available through the cue. It's the Parser instance that is using the encoder." self setCue: aCue. requestor := anObject. nTemps := 0. supered := false. self initScopeAndLiteralTables. cue getClass variablesAndOffsetsDo: [:variable "<String|CFieldDefinition>" :offset "<Integer|nil>" | offset isNil ifTrue: [scopeTable at: variable name put: (FieldNode new fieldDefinition: variable)] ifFalse: [scopeTable at: variable put: (offset >= 0 ifTrue: [InstanceVariableNode new name: variable index: offset] ifFalse: [MaybeContextInstanceVariableNode new name: variable index: offset negated])]]. cue context ~~ nil ifTrue: [| homeNode | homeNode := self bindTemp: self doItInContextName. "0th temp = aContext passed as arg" cue context tempNames withIndexDo: [:variable :index| + variable ~= self doItInContextName ifTrue: + [scopeTable + at: variable + put: (MessageAsTempNode new + receiver: homeNode + selector: #namedTempAt: + arguments: (Array with: (self encodeLiteral: index)) + precedence: 3 + from: self)]]]. - scopeTable - at: variable - put: (MessageAsTempNode new - receiver: homeNode - selector: #namedTempAt: - arguments: (Array with: (self encodeLiteral: index)) - precedence: 3 - from: self)]]. sourceRanges := Dictionary new: 32. globalSourceRanges := OrderedCollection new: 32 !

1 0

The Trunk: Tools-eem.529.mcz
by commits＠source.squeak.org 06 Oct '14

06 Oct '14

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.529.mcz ==================== Summary ==================== Name: Tools-eem.529 Author: eem Time: 6 October 2014, 12:57:06.915 pm UUID: 3c226418-51a9-4b8a-9edc-9015b15b27cb Ancestors: Tools-cmm.528 Have Debugger>>openFullNoSuspendLabel: et al answer the windows they create. Hence also change Debugger class>>openInterrupt:onProcess: to answer the debugger, not the window. =============== Diff against Tools-cmm.528 =============== Item was changed: ----- Method: Debugger class>>openInterrupt:onProcess: (in category 'opening') ----- openInterrupt: aString onProcess: interruptedProcess "Open a notifier in response to an interrupt. An interrupt occurs when the user types the interrupt key (cmd-. on Macs, ctrl-c or alt-. on other systems) or when the low-space watcher detects that memory is low." | debugger | <primitive: 19> "Simulation guard" debugger := self new. debugger process: interruptedProcess controller: ((Smalltalk isMorphic not and: [ScheduledControllers activeControllerProcess == interruptedProcess]) ifTrue: [ScheduledControllers activeController]) context: interruptedProcess suspendedContext. debugger externalInterrupt: true. Preferences logDebuggerStackToFile ifTrue: [(aString includesSubString: 'Space') & (aString includesSubString: 'low') ifTrue: [Smalltalk logError: aString inContext: debugger interruptedContext to: 'LowSpaceDebug.log'] "logging disabled for 4.3 release, see http://lists.squeak.org/pipermail/squeak-dev/2011-December/162503.html" "ifFalse: [Smalltalk logSqueakError: aString inContext: debugger interruptedContext]"]. Preferences eToyFriendly ifTrue: [World stopRunningAll]. + ^debugger + openNotifierContents: nil label: aString; + yourself - ^ debugger - openNotifierContents: nil - label: aString ! Item was changed: ----- Method: Debugger>>openFullNoSuspendFrom: (in category 'initialize') ----- openFullNoSuspendFrom: topView + "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." - "Create and schedule a full debugger with the given label. Do not terminate the current active process." | oldContextStackIndex | oldContextStackIndex := contextStackIndex. self expandStack. "Sets contextStackIndex to zero." + ^[ToolBuilder default openDebugger: self label: topView label closing: topView] ensure: + [self toggleContextStackIndex: oldContextStackIndex]! - ToolBuilder default openDebugger: self label: topView label closing: topView. - self toggleContextStackIndex: oldContextStackIndex.! Item was changed: ----- Method: Debugger>>openFullNoSuspendLabel: (in category 'initialize') ----- openFullNoSuspendLabel: aString + "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." - "Create and schedule a full debugger with the given label. Do not terminate the current active process." | oldContextStackIndex | oldContextStackIndex := contextStackIndex. self expandStack. "Sets contextStackIndex to zero." + ^[ToolBuilder default openDebugger: self label: aString] ensure: + [self toggleContextStackIndex: oldContextStackIndex]! - ToolBuilder default openDebugger: self label: aString. - self toggleContextStackIndex: oldContextStackIndex.! Item was changed: ----- Method: Debugger>>openNotifierContents:label: (in category 'initialize') ----- openNotifierContents: msgString label: label + "Create, schedule and answer a notifier view with the given label and message. A notifier view shows just the message or the first several lines of the stack, with a menu that allows the user to open a full debugger if so desired." - "Create and schedule a notifier view with the given label and message. A notifier view shows just the message or the first several lines of the stack, with a menu that allows the user to open a full debugger if so desired." "NOTE: When this method returns, a new process has been scheduled to run the windows, and thus this notifier, but the previous active process has not been suspended. The sender will do this." | msg builder spec | Sensor flushKeyboard. savedCursor := Cursor currentCursor. Cursor currentCursor: Cursor normal. (label beginsWith: 'Space is low') ifTrue: [msg := self lowSpaceChoices, (msgString ifNil: [''])] ifFalse: [msg := msgString]. builder := ToolBuilder default. spec := self buildNotifierWith: builder label: label message: msg. self expandStack. + ^[builder openDebugger: spec] ensure: + [errorWasInUIProcess := Project current spawnNewProcessIfThisIsUI: interruptedProcess] - builder openDebugger: spec. - errorWasInUIProcess := Project current spawnNewProcessIfThisIsUI: interruptedProcess. !

1 0

Jump to page: