Squeak-dev May 2014

squeak-dev@lists.squeakfoundation.org

43 participants
219 discussions

The Trunk: Collections-eem.567.mcz
by commits＠source.squeak.org 02 May '14

02 May '14

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.567.mcz ==================== Summary ==================== Name: Collections-eem.567 Author: eem Time: 2 May 2014, 9:54:58.139 am UUID: 78f9c7bb-cb9d-487c-91ba-edd8b89502c1 Ancestors: Collections-nice.566 Fix ([Read|Write]Stream on:...from:...to:...) contents. The old code would always copy from 1 to the end, not from whatever the from: argument was. =============== Diff against Collections-nice.566 =============== Item was changed: PositionableStream subclass: #ReadStream + instanceVariableNames: 'initialPositionOrNil' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Collections-Streams'! !ReadStream commentStamp: '<historical>' prior: 0! I represent an accessor for a sequence of objects that can only read objects from the sequence.! Item was added: + ----- Method: ReadStream>>contents (in category 'accessing') ----- + contents + "Answer with a copy of my collection from the start to readLimit." + + ^collection copyFrom: (initialPositionOrNil ifNil: [1]) to: readLimit! Item was changed: ----- Method: ReadStream>>on:from:to: (in category 'private') ----- on: aCollection from: firstIndex to: lastIndex | len | collection := aCollection. readLimit := lastIndex > (len := collection size) ifTrue: [len] ifFalse: [lastIndex]. position := firstIndex <= 1 ifTrue: [0] + ifFalse: [firstIndex - 1]. + initialPositionOrNil := position + 1! - ifFalse: [firstIndex - 1]! Item was changed: ----- Method: ReadWriteStream>>contents (in category 'accessing') ----- contents + "Answer with a copy of my collection from the start to readLimit." - "Answer with a copy of my collection from 1 to readLimit." readLimit := readLimit max: position. + ^collection copyFrom: (initialPositionOrNil ifNil: [1]) to: readLimit! - ^collection copyFrom: 1 to: readLimit! Item was changed: PositionableStream subclass: #WriteStream + instanceVariableNames: 'writeLimit initialPositionOrNil' - instanceVariableNames: 'writeLimit' classVariableNames: '' poolDictionaries: '' category: 'Collections-Streams'! !WriteStream commentStamp: '<historical>' prior: 0! I represent an accessor for a sequence of objects that can only store objects in the sequence.! Item was changed: ----- Method: WriteStream>>contents (in category 'accessing') ----- contents + "Answer with a copy of my collection from the start to the current position." - readLimit := readLimit max: position. + ^collection copyFrom: (initialPositionOrNil ifNil: [1]) to: position! - ^collection copyFrom: 1 to: position! Item was changed: ----- Method: WriteStream>>on:from:to: (in category 'private') ----- on: aCollection from: firstIndex to: lastIndex | len | collection := aCollection. readLimit := writeLimit := lastIndex > (len := collection size) ifTrue: [len] ifFalse: [lastIndex]. position := firstIndex <= 1 ifTrue: [0] + ifFalse: [firstIndex - 1]. + initialPositionOrNil := position + 1! - ifFalse: [firstIndex - 1]!

1 0

The Trunk: CollectionsTests-eem.216.mcz
by commits＠source.squeak.org 02 May '14

02 May '14

Eliot Miranda uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-eem.216.mcz ==================== Summary ==================== Name: CollectionsTests-eem.216 Author: eem Time: 2 May 2014, 9:51:57.073 am UUID: 51439739-6902-45d6-86d1-461fa61b652a Ancestors: CollectionsTests-topa.215 Add tests that expect unsurprising behaviour from ([Read|Write]Stream on:...from:...to:...) contents =============== Diff against CollectionsTests-topa.215 =============== Item was added: + ----- Method: ReadStreamTest>>testOnFromTo (in category 'tests - accessing') ----- + testOnFromTo + self assert: (ReadWriteStream + on: (String withAll: ((0 to: 255) collect: [:n| n asCharacter])) + from: $A asInteger + 1 + to: $Z asInteger + 1) + contents + equals: (String withAll: (($A asInteger to: $Z asInteger) collect: [:n| n asCharacter]))! Item was added: + ----- Method: ReadWriteStreamTest>>testOnFromTo (in category 'tests') ----- + testOnFromTo + self assert: (ReadWriteStream + on: (String withAll: ((0 to: 255) collect: [:n| n asCharacter])) + from: $A asInteger + 1 + to: $Z asInteger + 1) + contents + equals: (String withAll: (($A asInteger to: $Z asInteger) collect: [:n| n asCharacter]))! Item was added: + ----- Method: WriteStreamTest>>testOnFromTo (in category 'tests - accessing') ----- + testOnFromTo + | aToZ | + aToZ := String withAll: (($A asInteger to: $Z asInteger) collect: [:n| n asCharacter]). + self assert: ((ReadWriteStream + on: (String withAll: ((0 to: 255) collect: [:n| n asCharacter])) + from: $A asInteger + 1 + to: $Z asInteger + 1) + nextPutAll: aToZ; + contents) + equals: aToZ!

1 0

too much logging
by Eliot Miranda 02 May '14

02 May '14

Hi Colin, Hi All, if in 4.5 one tries to evaluate a doit somewhere in a verdant transcript, one containing much content, then too much logging will occur to the changes file. Instead of the selected doit being logged, the entire contents of the transcript up to the end of the doit will be logged, and that can cause parse errors when recovering changes. So how best to solve this? Here are some ideas and I wanted to ask people's opinion - have CompilationCue remember the position of the source stream and instead of using "source contents" in streamToLog use "source position; upToEnd" - have Parser/Scanner remember the characters parsed in a buffer and take them from there - change ReadWriteStream to remember its initial position so that when one says (ReadWriteStream on: (String withAll: ((0 to: 255) collect: [:n| n asCharacter])) from: $A asInteger + 1 to: $Z asInteger + 1) contents one gets 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' instead of ' !"#$%&''()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ' IMO the last option is the right thing to do but it feels like a big change. -- best, Eliot

2 3

The Trunk: KernelTests-nice.266.mcz
by commits＠source.squeak.org 02 May '14

02 May '14

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.266.mcz ==================== Summary ==================== Name: KernelTests-nice.266 Author: nice Time: 2 May 2014, 4:12:26.353 pm UUID: 48655368-d9cd-4a73-ae47-fa616834ea06 Ancestors: KernelTests-dtl.265 Get rid of a useless shouldnt:raise: =============== Diff against KernelTests-dtl.265 =============== Item was changed: ----- Method: IntegerTest>>testNthRoot (in category 'tests - mathematical functions') ----- testNthRoot - - self shouldnt: [ (1 << 2000 nthRoot: 100) ] raise: ArithmeticError. self assert: (1 << 2000 nthRoot: 100) equals: 1 << 20!

1 0

The Trunk: Collections-nice.566.mcz
by commits＠source.squeak.org 02 May '14

02 May '14

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.566.mcz ==================== Summary ==================== Name: Collections-nice.566 Author: nice Time: 2 May 2014, 3:48:25.893 pm UUID: dc820d7f-79ef-49ee-b1b2-b4f8d7161b4e Ancestors: Collections-topa.565 Let NullStream understand protocol for Character writing. =============== Diff against Collections-topa.565 =============== Item was added: + ----- Method: NullStream>>cr (in category 'writing') ----- + cr! Item was added: + ----- Method: NullStream>>crtab: (in category 'writing') ----- + crtab: n! Item was added: + ----- Method: NullStream>>nl (in category 'writing') ----- + nl! Item was added: + ----- Method: NullStream>>space (in category 'writing') ----- + space! Item was added: + ----- Method: NullStream>>tab (in category 'writing') ----- + tab! Item was added: + ----- Method: NullStream>>tab: (in category 'writing') ----- + tab: n!

1 0

compiler bug with 4.5?
by Eliot Miranda 02 May '14

02 May '14

Hi All, just found a worrying bug in 4.5. that may be a bytecode compiler bug or a Monticello bug. It's completely repeatable. The bug is that after building the VMMaker image that compiles the VMMaker package, Spur32BitCoMemoryManager>>#getScavengeThreshold (the 42st inst var) is compiled with a header that says return the 7th inst var. To repeat, check-out http://www.squeakvm.org/svn/squeak/branches/Cog/image, run buildsqueak45image.sh, then start-up CogVMMaker.image. Navigate to Spur32BitCoMemoryManager>>#getScavengeThreshold -- and explore the method (there's a menu pick in the browser). best, Eliot

3 2

Re: compiler bug with 4.5?
by Eliot Miranda 02 May '14

02 May '14

On reflection this is unlikely to be anything to do with the bytecode compiler. It is most likely an issue with the binary package and the bogus methods (for, dear reader, there are at least a few more) could have lain there-in undetected for some time. I'll look more temperately soon. Eliot (phone)

1 0

Daily Commit Log
by commits＠source.squeak.org 02 May '14

02 May '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-May/007005.html Name: Files-eem.133 Ancestors: Files-eem.132 Make sure nextPutAll: still loads buffer1 at: 1, so that e.g. peekLast works as expected. The test is (((MultiByteFileStream forceNewFileNamed: aFilename) lineEndConvention: #lf; yourself) nextPut: Character tab; nextPut: Character cr; peekLast) == Character cr This fails before the change, answering Chartacter tab. =============================================

1 0

The Trunk: Files-eem.133.mcz
by commits＠source.squeak.org 01 May '14

01 May '14

Eliot Miranda uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-eem.133.mcz ==================== Summary ==================== Name: Files-eem.133 Author: eem Time: 30 April 2014, 6:41:39.825 pm UUID: 19b3579e-84ed-47a1-bebc-b6510682da41 Ancestors: Files-eem.132 Make sure nextPutAll: still loads buffer1 at: 1, so that e.g. peekLast works as expected. The test is (((MultiByteFileStream forceNewFileNamed: aFilename) lineEndConvention: #lf; yourself) nextPut: Character tab; nextPut: Character cr; peekLast) == Character cr This fails before the change, answering Chartacter tab. =============== Diff against Files-eem.132 =============== Item was changed: ----- Method: StandardFileStream>>nextPutAll: (in category 'read, write, position') ----- nextPutAll: aString "Write all the characters of the given string to this file." + | size | - rwmode ifFalse: [^ self error: 'Cannot write a read-only file']. collection ifNotNil: [ position < readLimit ifTrue: [ self flushReadBuffer ] ]. + (size := aString size) > 0 ifTrue: + [buffer1 at: 1 put: (aString at: size). + self primWrite: fileID from: aString startingAt: 1 count: aString basicSize]. - self primWrite: fileID from: aString startingAt: 1 count: aString basicSize. ^ aString !

1 0

Jump to page: