Squeak-dev July 2014

squeak-dev@lists.squeakfoundation.org

31 participants
223 discussions

Daily Commit Log
by commits＠source.squeak.org 16 Jul '14

16 Jul '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-July/007146.html Name: MorphicExtras-kfr.150 Ancestors: MorphicExtras-kfr.149 Set brush size and color to "usefull" values, eg. mid size and black. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007147.html Name: KernelTests-dtl.273 Ancestors: KernelTests-fbs.272 Remove invalid assertions in DateAndTimeTest>>testReadFrom. These had been added to the test in KernelTests-dtl.265 in attempt to restore some missing test assertions from an earlier version of the method. The test assertions pass if and only if time zone has zero offset, so they appear to pass in an image with default UTC time zone. However, they contradict the documented behavior for parsing DateAndTime from a string with time zone offset unspecified. See DateAndTimeTest>>testFromString for coverage of the expected behavior. =============================================

1 0

The Trunk: KernelTests-dtl.273.mcz
by commits＠source.squeak.org 16 Jul '14

16 Jul '14

David T. Lewis uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-dtl.273.mcz ==================== Summary ==================== Name: KernelTests-dtl.273 Author: dtl Time: 15 July 2014, 7:52:19.461 pm UUID: 31288564-1f42-4fd3-ac23-e15bf1480000 Ancestors: KernelTests-fbs.272 Remove invalid assertions in DateAndTimeTest>>testReadFrom. These had been added to the test in KernelTests-dtl.265 in attempt to restore some missing test assertions from an earlier version of the method. The test assertions pass if and only if time zone has zero offset, so they appear to pass in an image with default UTC time zone. However, they contradict the documented behavior for parsing DateAndTime from a string with time zone offset unspecified. See DateAndTimeTest>>testFromString for coverage of the expected behavior. =============== Diff against KernelTests-fbs.272 =============== Item was changed: ----- Method: DateAndTimeTest>>testReadFrom (in category 'Tests') ----- testReadFrom self assert: '-1199-01-05T20:33:14.321-05:00' equals: (DateAndTime readFrom: '-1199-01-05T20:33:14.321-05:00' readStream) printString. self assert: '-1199-01-05T20:33:14.321-05:00' equals: '-1199-01-05T20:33:14.321-05:00' asDateAndTime printString. self assert: '2002-05-16T17:20:45.1+01:01' equals: '2002-05-16T17:20:45.1+01:01' asDateAndTime printString. self assert: '2002-05-16T17:20:45.02+01:01' equals: ' 2002-05-16T17:20:45.02+01:01' asDateAndTime printString. self assert: '2002-05-16T17:20:45.000000009+01:01' equals: '2002-05-16T17:20:45.000000009+01:01' asDateAndTime printString. - self assert: '2002-05-16T17:20:00+00:00' equals: ' 2002-05-16T17:20' asDateAndTime printString. - self assert: '2002-05-16T17:20:45+00:00' equals: '2002-05-16T17:20:45' asDateAndTime printString. self assert: '2002-05-16T17:20:45+01:57' equals: ' 2002-05-16T17:20:45+01:57' asDateAndTime printString. self assert: '2002-05-16T17:20:45-02:34' equals: ' 2002-05-16T17:20:45-02:34' asDateAndTime printString. self assert: '2002-05-16T17:20:45+00:00' equals: '2002-05-16T17:20:45+00:00' asDateAndTime printString. self assert: '1997-04-26T01:02:03+01:02:3' equals: '1997-04-26T01:02:03+01:02:3' asDateAndTime printString!

1 0

The Trunk: MorphicExtras-kfr.150.mcz
by commits＠source.squeak.org 15 Jul '14

15 Jul '14

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.150.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.150 Author: kfr Time: 15 July 2014, 10:47:55.947 pm UUID: c620d424-01dd-e24f-b692-73ac079ee6ef Ancestors: MorphicExtras-kfr.149 Set brush size and color to "usefull" values, eg. mid size and black. =============== Diff against MorphicExtras-kfr.149 =============== Item was changed: ----- Method: PaintBoxMorph>>addBrushesOffImage: (in category 'initialization') ----- addBrushesOffImage: offImage | posSpec | posSpec := #( (13 37 64 13 37 64) "offset X" (107 107 107 124 124 124) "offset Y" (21 24 27 21 24 27) "width" (18 18 18 25 25 25) "height"). #(brush1: brush2: brush3: brush4: brush5: brush6: ) keysAndValuesDo: [:index :name | | button nib rect on off | (self submorphNamed: name) ifNil: [nib := Form dotOfSize: (#(1 2 3 6 11 26) at: index). rect := ((posSpec at: 1) at: index) @ ((posSpec at: 2) at: index) extent: ((posSpec at: 3) at: index) @ ((posSpec at: 4) at: index). off := (offImage copy: rect) as8BitColorForm. "highlight a frame" on := off deepCopy. (on getCanvas copyOrigin: 0@0 clipRect: (0@0 extent: rect extent)) frameAndFillRectangle: (0@0 extent: rect extent) fillColor: Color transparent borderWidth: 2 borderColor: (Color r: 0.6 g: 0.8 b: 1.0). (button := ThreePhaseButtonMorph new) onImage: on; offImage: off; pressedImage: on; bounds: (rect translateBy: self position); setNamePropertyTo: name; actionSelector: #brush:action:nib:evt:; arguments: (Array with: button with: name with: nib); actWhen: #buttonUp; target: self. self addMorph: button.]]. brushes := #(brush1: brush2: brush3: brush4: brush5: brush6: ) collect: [:name | self submorphNamed: name]. + currentBrush := brushes at: 3. - currentBrush := brushes last. currentBrush state: #on. ! Item was changed: ----- Method: PaintBoxMorph>>buildAPrototype (in category 'initialization') ----- buildAPrototype | onImage | self initialize. self image: self class paletteImage. rotationTabForm := self class rotationTabImage. scaleTabForm := self class scaleTabImage. (colorMemoryThin := self class colorMemoryThinImage asMorph) setNamePropertyTo: 'ColorPickerClosed'; position: self position + (11@150); on: #mouseEnter send: #showColorPalette: to: self. self addMorph: colorMemoryThin. (colorMemory := PaintBoxColorPicker new image: self class colorMemoryImage) setNamePropertyTo: 'ColorPickerOpened'; on: #mouseDown send: #takeColorEvt:from: to: self. + currentColor := Color black. - currentColor := Color transparent. onImage := self class paletteOnImage. self addToolsOffImage: image onImage: onImage; addBrushesOffImage: image; addActionsOffImage: image onImage: onImage; addStampsAndShapes; addShapeButtonsOffImage: self class shapesImage onImage: self class shapesOnImage; addStampButtonsOffImage: self class stampsImage onImage: self class stampsOnImage. stampHolder := ScrollingToolHolder newPrototypeFor: self.!

1 0

New Cog VMs available
by Eliot Miranda 15 Jul '14

15 Jul '14

...at http://www.mirandabanda.org/files/Cog/VM/VM.r3041/. The principal changes are fixing a performance regression in the 3040 VMs, fixing some Spur bugs in primitiveClone/shallowCopy, and radically simplifying the Spur become implementation, trading the elimination of lots of post-become class table scanning for adding read barriers to class hierarchy method lookup. CogVM source as per VMMaker.oscog-eem.820/r3041 Put the handling of the cloning of cogged methods in the clone: implementations, removing it from the primitive. Add it to the pinning clone too. Specialize the store check trampoline generation. Move it down to the relevant object representations. Move setting of isRemembered flag to true into SpurGenerationScavenger>> remember:. Inline possibleRootStoreInto: (given that remember: is /not/ inlined. Call remember directly from the ceStoreCheckTrampoline, and hence have remember: answer its argument. Fix localization bug. Variables in initialize methods were not considered references (cuz there are excluded). This caused VMMaker.oscog-eem.816's extraction of zero/false vars to StackInterpreter>>#initialize to cause nextPollUsecs to be localized to checkForEventsMayContextSwitch:. Spur: Fix bug in scanClassPostBecome:effects: with new lazy selector following policy by... throwing it all away. The read barriers on method lookup (of the methodClass association in super sends, of the superclass link, of method dictionaries, method dictionary arrays, selectors and methods is cheap. So replace scanning classes and method dictionaries in the class table post become with read marriewrs on methodClass, superclass and method dictionary etc on lookup. The read barrier on an object from which we are going to fetch state (such as a class or method dictionary) is essentially free on modern machines because the class index and the state very likely share a cache line, and the register code for testing is so cheap compared to memory access. Further the read barrier on selectors is cheap because the method lookup cache is effective in reducing the number of message lookups and because nil entries need no check. So nuke all the followNecessaryForwardingInMethod: machinery including the cmUsesMethodClass hack. Nuke scanClassPostBecome:effects:. Rip out the forwardingCount: measurement code. It causes bad performance regressions (due to failing inlines?) Clean up, e.g. replace followNonImmediateField:ofObject: uses with followObjField:ofObject:. canPinObjects can be inlined. -- best, Eliot

2 1

4.5 welcome workspaces not shown
by Bert Freudenberg 15 Jul '14

15 Jul '14

Is this intentional? - Bert -

2 1

Spur RemoteString past end of file problems
by Frank Shearar 15 Jul '14

15 Jul '14

I'd wondered why whenever I played around with Spur I saw these errors, but CI bubbled along merrily. That's because CI worked off the published (base) trunk image, not a fully updated image. So with an _updated_ Spur trunk image, the update process fails thusly: RemoteString(Object)>>error: RemoteString>>text ClassOrganizer(BasicClassOrganizer)>>classComment DummyUIManager class(Class)>>asClassDefinition DummyUIManager class(Class)>>classDefinitions [] in [] in MCPackage>>snapshot [] in [] in OrderedCollection(Collection)>>do:displayingProgress:every: OrderedCollection>>do: [] in OrderedCollection(Collection)>>do:displayingProgress:every: [] in [] in MorphicUIManager>>displayProgress:at:from:to:during: BlockClosure>>on:do: [] in MorphicUIManager>>displayProgress:at:from:to:during: BlockClosure>>ensure: MorphicUIManager>>displayProgress:at:from:to:during: ProgressInitiationException>>defaultResumeValue ProgressInitiationException(Exception)>>resume ProgressInitiationException>>defaultAction UndefinedObject>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: ProgressInitiationException(Exception)>>signal ..... and so on. (http://build.squeak.org/job/SqueakTrunkOnSpur/34/console for the gory details) It's not just the update process, because in the last successful SqueakTrunkOnSpur run you can see certain tests failing with the same error: http://build.squeak.org/job/SqueakTrunkOnSpur/32/testReport/ToolsTests.Brow… whose stack trace looks like: RemoteString(Object)>>error: RemoteString>>text ClassOrganizer(BasicClassOrganizer)>>classComment Browser class(ClassDescription)>>comment BrowserTest>>testClassDefinitionAnnotation BrowserTest(TestCase)>>performTest Does anyone else see this? frank

1 0

Daily Commit Log
by commits＠source.squeak.org 15 Jul '14

15 Jul '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-July/007143.html Name: KernelTests-fbs.272 Ancestors: KernelTests-nice.271 Better error messages make for easier CI debugging. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007144.html Name: SUnit-fbs.100 Ancestors: SUnit-fbs.99 Better error messages make for easier CI debugging. (It would be better if we could just ask a Class for its uncategorised methods, but such a utility doesn't exist yet.) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007145.html Name: Tests-fbs.301 Ancestors: Tests-fbs.300 Better error messages for CI. Note that on Spur+Windows, this test passes, but fails in CI, which is Spur+Linux. =============================================

1 0

The Trunk: Tests-fbs.301.mcz
by commits＠source.squeak.org 14 Jul '14

14 Jul '14

Frank Shearar uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-fbs.301.mcz ==================== Summary ==================== Name: Tests-fbs.301 Author: fbs Time: 14 July 2014, 10:46:36.798 pm UUID: 33e9ec43-da40-8c4a-ba89-738e359a3043 Ancestors: Tests-fbs.300 Better error messages for CI. Note that on Spur+Windows, this test passes, but fails in CI, which is Spur+Linux. =============== Diff against Tests-fbs.300 =============== Item was changed: ----- Method: IslandVMTweaksTestCase>>testForgivingPrims (in category 'testing') ----- testForgivingPrims | aPoint anotherPoint array1 array2 | aPoint := Point x: 5 y: 6. anotherPoint := Point x: 7 y: 8. "make sure there are multiple points floating around" anotherPoint. "stop the compiler complaining about no uses" + self assert: Point equals: (self classOf: aPoint). + self assert: 5 equals: (self instVarOf: aPoint at: 1). - self should: [ (self classOf: aPoint) = Point ]. - self should: [ (self instVarOf: aPoint at: 1) = 5 ]. self instVarOf: aPoint at: 2 put: 10. + self assert: 10 equals: (self instVarOf: aPoint at: 2). - self should: [ (self instVarOf: aPoint at: 2) = 10 ]. self someObject. self nextObjectAfter: aPoint. + self assert: Point equals: (self someInstanceOf: Point) class. + self assert: Point equals: (self nextInstanceAfter: aPoint) class. - self should: [ (self someInstanceOf: Point) class = Point ]. - self should: [ (self nextInstanceAfter: aPoint) class = Point ]. array1 := Array with: 1 with: 2 with: 3. array2 := Array with: 4 with: 5 with: 6. self replaceIn: array1 from: 2 to: 3 with: array2 startingAt: 1. + self assert: #(1 4 5) equals: array1.! - self should: [ array1 = #(1 4 5) ]. - - !

1 0

The Trunk: SUnit-fbs.100.mcz
by commits＠source.squeak.org 14 Jul '14

14 Jul '14

Frank Shearar uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-fbs.100.mcz ==================== Summary ==================== Name: SUnit-fbs.100 Author: fbs Time: 14 July 2014, 10:30:22.506 pm UUID: f789d123-bd90-ce4d-b4be-0790efcb70d0 Ancestors: SUnit-fbs.99 Better error messages make for easier CI debugging. (It would be better if we could just ask a Class for its uncategorised methods, but such a utility doesn't exist yet.) =============== Diff against SUnit-fbs.99 =============== Item was changed: ----- Method: ClassTestCase>>testUnCategorizedMethods (in category 'tests') ----- testUnCategorizedMethods + | categories slips uncategorisedMethods | - | categories slips | categories := self categoriesForClass: self targetClass. slips := categories select: [:each | each = #'as yet unclassified']. + + uncategorisedMethods := self targetClass organization listAtCategoryNamed: #'as yet unclassified'. + + self assert: slips isEmpty description: ('{1} has uncategorised methods: {2}' format: {self targetClass. (uncategorisedMethods collect: #printString) asCommaString}).! - self should: [slips isEmpty]. !

1 0

The Trunk: KernelTests-fbs.272.mcz
by commits＠source.squeak.org 14 Jul '14

14 Jul '14

Frank Shearar uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-fbs.272.mcz ==================== Summary ==================== Name: KernelTests-fbs.272 Author: fbs Time: 14 July 2014, 10:29:20.989 pm UUID: 577e7a8d-7f08-2049-811f-fac2a7be330b Ancestors: KernelTests-nice.271 Better error messages make for easier CI debugging. =============== Diff against KernelTests-nice.271 =============== Item was changed: ----- Method: LargeNegativeIntegerTest>>testCompactClassIndex (in category 'tests') ----- testCompactClassIndex + self assert: 4 equals: LargeNegativeInteger indexIfCompact. - self assert: LargeNegativeInteger indexIfCompact = 4. ! Item was changed: ----- Method: LargePositiveIntegerTest>>testCompactClassIndex (in category 'tests') ----- testCompactClassIndex + self assert: 5 equals: LargePositiveInteger indexIfCompact.! - self assert: LargePositiveInteger indexIfCompact = 5.!

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
23
Older →

Jump to page: